Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021071Openbravo ERPA. Platformpublic2012-07-13 13:562012-07-27 12:57
Reporterguilleaer 
Assigned ToAugustoMauch 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP14 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2012-05-24
Regression introduced in release
Regression introduced by commit4a4ad33e5e27 -> 16636
Triggers an Emergency Packyes
Summary0021071: Admin others widget is broken.
DescriptionWhen the option "Admin Others" of the workspace doesn't work. The confirmation/close dialog has dissapeared and is not possible to go back to the user workspace.
Steps To Reproduce1. Log in as F&B Group admin
2. In the left column of the workspace (bellow) click "Admin others"
3. select role or org
4. select a role (E.g. System)
5. click edit button

The attached dialog doesn't appear and the workspace doesn't show the rol widgets.
You cannot go back to your workspace.
Proposed SolutionIt seems that this regression was introduced by a smartclient upgrade.
I can say that the origin of this error was in this changeset which is a merge.

4a4ad33e5e27 -> 16636

I was researching and I think that a change in behavior of method destroy of smartclient can be the cause of this regression.

I've attached a possible fix for this problem.
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff diffIssueWidgets.diff (1,564) 2012-07-13 14:01
https://issues.openbravo.com/file_download.php?file_id=5427&type=bug
png DisappearDialog.png (11,981) 2012-07-13 14:01
https://issues.openbravo.com/file_download.php?file_id=5428&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-07-13 13:56guilleaerNew Issue
2012-07-13 13:56guilleaerAssigned To => AugustoMauch
2012-07-13 13:56guilleaerWeb browser => Google Chrome
2012-07-13 13:56guilleaerModules => Core
2012-07-13 14:00guilleaerWeb browserGoogle Chrome => Google Chrome
2012-07-13 14:00guilleaerRegression level => Production - Confirmed Stable
2012-07-13 14:00guilleaerRegression date => 2012-05-24
2012-07-13 14:00guilleaerRegression introduced by commit => 4a4ad33e5e27 -> 16636
2012-07-13 14:00guilleaerProposed Solution updated
2012-07-13 14:01guilleaerFile Added: diffIssueWidgets.diff
2012-07-13 14:01guilleaerFile Added: DisappearDialog.png
2012-07-26 17:19hgbotCheckin
2012-07-26 17:19hgbotNote Added: 0050911
2012-07-26 17:19hgbotStatusnew => resolved
2012-07-26 17:19hgbotResolutionopen => fixed
2012-07-26 17:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a73133e6a7286c7c6b00aa9164b5a8b40b4d2178 [^]
2012-07-27 02:18hudsonbotCheckin
2012-07-27 02:18hudsonbotNote Added: 0050924
2012-07-27 12:57AugustoMauchNote Added: 0050937
2012-07-27 12:57AugustoMauchStatusresolved => closed
2012-07-27 12:57AugustoMauchFixed in Version => 3.0MP14

Notes
(0050911)
hgbot   
2012-07-26 17:19   
Repository: erp/devel/pi
Changeset: a73133e6a7286c7c6b00aa9164b5a8b40b4d2178
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jul 26 17:18:03 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a73133e6a7286c7c6b00aa9164b5a8b40b4d2178 [^]

Fixed issue 21071: In Admin Others, Publish dialog is shown again

---
M modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-myopenbravo.js
---
(0050924)
hudsonbot   
2012-07-27 02:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4cfe6f4cd84a [^]

Maturity status: Test
(0050937)
AugustoMauch   
2012-07-27 12:57   
Code reviewed and verified in pi@f119181062af