Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0020969
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2012-07-09 20:032018-06-26 11:30
ReporteremartinezView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR16Q3
StatusclosedFix in branchFixed in SCM revisiondbc7209657c9
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020969: Error when closing a ticket from Web POS and customer has not all info filled in ERP

DescriptionIf customer has not payment term, payment method, etc, when closing the ticket from Web POS it raises an error in Openbravo.log and POS Order is not generated in the ERP side.

In case of Payment method, it should not retrieve the payment method from the Customer Card, but from the Ticket being generated in Web POS.

In case of not filling Payment term (or any other field not specified in POS) it should not allow to:
 a) Don't allow saving a customer in ERP if any mandatory fields for saving sales order are missing
 b) If we allow to save the customer, then at least allow saving the sales order with default values that could be configured somewhere (for payment term for instance)

Don't know which is the best solution, but the error it shouldn't be givne.
Steps To Reproduce1) Go to ERP and select a customer, select blank option for payment method
2) Go to Webpos and refresh if you were already logged in
3) Select the Customer and generate a ticket
4) Pay the ticket with Credit Card
5) See successful message in Webpos
6) Open Openbravo.log and see the error attached that Sales Order was not generated
TagsNo tags attached.
Attached Filestxt file icon SalesOrderError.txt [^] (4,196 bytes) 2012-07-09 20:03 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate defect 0031145 closedRetail Orders for a customer whithout a defined payment method are not sync appearing in errors window 

-  Notes
(0050406)
xplacesc (viewer)
2012-07-09 23:20

 Another option could be that Web POS would only retrieve customers with the proper setup, for example payment terms. In this way no customers with empty payment term would be at least initially retrieved by the Web POS
(0085260)
hgbot (developer)
2016-03-22 11:06

 Repository: erp/pmods/org.openbravo.retail.testsampledata
Changeset: b4c4772c47c73b76e2459db25ae0e0e649c58104
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Mar 22 15:29:57 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.testsampledata/rev/b4c4772c47c73b76e2459db25ae0e0e649c58104 [^]

Related to issue 20969 : Adding Payment term & method to customer

---
M referencedata/sampledata/Retail_Test/C_BPARTNER.xml
A referencedata/sampledata/Retail_Test/C_PAYMENTTERM.xml
---
(0085386)
hgbot (developer)
2016-04-01 14:11

 Repository: tools/automation/pi-mobile
Changeset: 25472b34b38f928b0942b8704fd21e4da8e1ce1d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Apr 01 16:02:44 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/25472b34b38f928b0942b8704fd21e4da8e1ce1d [^]

Verifies issue 20969 : Added automated test 'I20969_LoadCustomerBasedOnPaymentTerm'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I20969_LoadCustomerBasedOnPaymentTerm.java
---
(0085540)
hgbot (developer)
2016-04-11 08:39

 Repository: tools/automation/pi-mobile
Changeset: 47e86979b21c32bd39fe681b68ecdbfaff112519
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Apr 11 12:06:45 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/47e86979b21c32bd39fe681b68ecdbfaff112519 [^]

Verifies issue 20969 : Added automated test 'I20969_LoadCustomerBasedOnPaymentTerm'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I20969_LoadCustomerBasedOnPaymentTerm.java
---
(0085542)
hgbot (developer)
2016-04-11 08:39

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1bb0ecf622e26324ffa37fc1e6d2170513eb2fdb
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Apr 11 12:07:12 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1bb0ecf622e26324ffa37fc1e6d2170513eb2fdb [^]

Fixes issue 20969 : Load customer only if Payment method & Payment terms are associated in Business Partner

---
M src/org/openbravo/retail/posterminal/master/BusinessPartner.java
---
(0085980)
marvintm (viewer)
2016-04-26 12:53

 The current solution basically prevents the Web POS from loading business partners which do not have defined payment terms. However, this can be confusing for users as they may be used to seeing those business partners in the system, and when creating a Sales Order from the backend, those will be available to be selected.

A better solution could be to choose a default value for the payment terms of the order, like the backend currently does. As it is a mandatory column with reference TableDir, the first value of the combo should be selected in case the business partner doesn't have payment terms defined.
(0086118)
hgbot (developer)
2016-05-02 12:39

 Repository: tools/automation/pi-mobile
Changeset: 465362e7d9f20b4e5d2d9628da61af4e971c6cde
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Apr 28 15:39:07 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/465362e7d9f20b4e5d2d9628da61af4e971c6cde [^]

Verifies issue 20969 : Added automated test 'I20969_LoadCustomerBasedOnPaymentTerm'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I20969_LoadCustomerBasedOnPaymentTerm.java
---
(0086119)
hgbot (developer)
2016-05-02 12:42

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: dbc7209657c9215d6c466d623764deea2787838c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 02 16:07:56 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dbc7209657c9215d6c466d623764deea2787838c [^]

Fixes issue 20969 : Order Payment terms & method should be loaded based on Customer default values
If Customer default values is not available, Organizational default values should be applied.
If Organization default value is not avaiable, First value should be loaded from the respective tables

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/master/BusinessPartner.java
---

- Issue History
Date Modified Username Field Change
2012-07-09 20:03 emartinez New Issue
2012-07-09 20:03 emartinez Assigned To => adrianromero
2012-07-09 20:03 emartinez File Added: SalesOrderError.txt
2012-07-09 23:20 xplacesc Note Added: 0050406
2012-11-09 14:38 alostale Status new => scheduled
2012-11-09 14:38 alostale Assigned To adrianromero => migueldejuana
2012-11-09 14:38 alostale fix_in_branch => pi
2014-03-24 19:49 malsasua OBNetwork customer => No
2014-03-24 19:49 malsasua Triggers an Emergency Pack => No
2014-03-24 19:49 malsasua Severity minor => major
2014-03-24 19:49 malsasua fix_in_branch pi =>
2015-01-20 22:07 mtaal Priority normal => high
2016-03-07 15:20 Orekaria Status scheduled => resolved
2016-03-07 15:20 Orekaria Resolution open => fixed
2016-03-07 15:20 Orekaria Status resolved => new
2016-03-07 15:20 Orekaria Resolution fixed => open
2016-03-07 15:21 Orekaria Assigned To migueldejuana => Retail
2016-03-16 11:44 ranjith_qualiantech_com Status new => acknowledged
2016-03-16 14:15 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2016-03-16 14:15 ranjith_qualiantech_com Status acknowledged => scheduled
2016-03-18 12:22 ranjith_qualiantech_com Relationship added related to 0031145
2016-03-20 16:09 Orekaria Relationship replaced has duplicate 0031145
2016-03-22 11:06 hgbot Checkin
2016-03-22 11:06 hgbot Note Added: 0085260
2016-04-01 14:11 hgbot Checkin
2016-04-01 14:11 hgbot Note Added: 0085386
2016-04-11 08:39 hgbot Checkin
2016-04-11 08:39 hgbot Note Added: 0085540
2016-04-11 08:39 hgbot Checkin
2016-04-11 08:39 hgbot Note Added: 0085542
2016-04-11 08:39 hgbot Status scheduled => resolved
2016-04-11 08:39 hgbot Resolution open => fixed
2016-04-11 08:39 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1bb0ecf622e26324ffa37fc1e6d2170513eb2fdb [^]
2016-04-26 12:53 marvintm Note Added: 0085980
2016-04-26 12:53 marvintm Status resolved => new
2016-04-26 12:53 marvintm Resolution fixed => open
2016-04-26 15:53 ranjith_qualiantech_com Status new => scheduled
2016-05-02 12:39 hgbot Checkin
2016-05-02 12:39 hgbot Note Added: 0086118
2016-05-02 12:42 hgbot Checkin
2016-05-02 12:42 hgbot Note Added: 0086119
2016-05-02 12:43 hgbot Status scheduled => resolved
2016-05-02 12:43 hgbot Resolution open => fixed
2016-05-02 12:43 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1bb0ecf622e26324ffa37fc1e6d2170513eb2fdb [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dbc7209657c9215d6c466d623764deea2787838c [^]
2016-05-18 09:47 guilleaer Review Assigned To => guilleaer
2016-05-18 09:47 guilleaer Status resolved => closed
2016-05-18 09:47 guilleaer Fixed in Version => RR16Q3
2018-06-26 11:30 hgbot Checkin
2018-06-26 11:30 hgbot Note Added: 0105382
2018-06-26 13:58 gorka_gil Note Deleted: 0105382

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker