Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020969Retail ModulesWeb POSpublic2012-07-09 20:032018-06-26 11:30
Reporteremartinez 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020969: Error when closing a ticket from Web POS and customer has not all info filled in ERP
DescriptionIf customer has not payment term, payment method, etc, when closing the ticket from Web POS it raises an error in Openbravo.log and POS Order is not generated in the ERP side.

In case of Payment method, it should not retrieve the payment method from the Customer Card, but from the Ticket being generated in Web POS.

In case of not filling Payment term (or any other field not specified in POS) it should not allow to:
 a) Don't allow saving a customer in ERP if any mandatory fields for saving sales order are missing
 b) If we allow to save the customer, then at least allow saving the sales order with default values that could be configured somewhere (for payment term for instance)

Don't know which is the best solution, but the error it shouldn't be givne.
Steps To Reproduce1) Go to ERP and select a customer, select blank option for payment method
2) Go to Webpos and refresh if you were already logged in
3) Select the Customer and generate a ticket
4) Pay the ticket with Credit Card
5) See successful message in Webpos
6) Open Openbravo.log and see the error attached that Sales Order was not generated
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0031145 closed Retail Orders for a customer whithout a defined payment method are not sync appearing in errors window 
Attached Filestxt SalesOrderError.txt (4,196) 2012-07-09 20:03
https://issues.openbravo.com/file_download.php?file_id=5372&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-07-09 20:03emartinezNew Issue
2012-07-09 20:03emartinezAssigned To => adrianromero
2012-07-09 20:03emartinezFile Added: SalesOrderError.txt
2012-07-09 23:20xplacescNote Added: 0050406
2012-11-09 14:38alostaleStatusnew => scheduled
2012-11-09 14:38alostaleAssigned Toadrianromero => migueldejuana
2012-11-09 14:38alostalefix_in_branch => pi
2014-03-24 19:49malsasuaTriggers an Emergency Pack => No
2014-03-24 19:49malsasuaSeverityminor => major
2014-03-24 19:49malsasuafix_in_branchpi =>
2015-01-20 22:07mtaalPrioritynormal => high
2016-03-07 15:20OrekariaStatusscheduled => resolved
2016-03-07 15:20OrekariaResolutionopen => fixed
2016-03-07 15:20OrekariaStatusresolved => new
2016-03-07 15:20OrekariaResolutionfixed => open
2016-03-07 15:21OrekariaAssigned Tomigueldejuana => Retail
2016-03-16 11:44ranjith_qualiantech_comStatusnew => acknowledged
2016-03-16 14:15ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-03-16 14:15ranjith_qualiantech_comStatusacknowledged => scheduled
2016-03-18 12:22ranjith_qualiantech_comRelationship addedrelated to 0031145
2016-03-20 16:09OrekariaRelationship replacedhas duplicate 0031145
2016-03-22 11:06hgbotCheckin
2016-03-22 11:06hgbotNote Added: 0085260
2016-04-01 14:11hgbotCheckin
2016-04-01 14:11hgbotNote Added: 0085386
2016-04-11 08:39hgbotCheckin
2016-04-11 08:39hgbotNote Added: 0085540
2016-04-11 08:39hgbotCheckin
2016-04-11 08:39hgbotNote Added: 0085542
2016-04-11 08:39hgbotStatusscheduled => resolved
2016-04-11 08:39hgbotResolutionopen => fixed
2016-04-11 08:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1bb0ecf622e26324ffa37fc1e6d2170513eb2fdb [^]
2016-04-26 12:53marvintmNote Added: 0085980
2016-04-26 12:53marvintmStatusresolved => new
2016-04-26 12:53marvintmResolutionfixed => open
2016-04-26 15:53ranjith_qualiantech_comStatusnew => scheduled
2016-05-02 12:39hgbotCheckin
2016-05-02 12:39hgbotNote Added: 0086118
2016-05-02 12:42hgbotCheckin
2016-05-02 12:42hgbotNote Added: 0086119
2016-05-02 12:43hgbotStatusscheduled => resolved
2016-05-02 12:43hgbotResolutionopen => fixed
2016-05-02 12:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1bb0ecf622e26324ffa37fc1e6d2170513eb2fdb [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dbc7209657c9215d6c466d623764deea2787838c [^]
2016-05-18 09:47guilleaerReview Assigned To => guilleaer
2016-05-18 09:47guilleaerStatusresolved => closed
2016-05-18 09:47guilleaerFixed in Version => RR16Q3
2018-06-26 11:30hgbotCheckin
2018-06-26 11:30hgbotNote Added: 0105382
2018-06-26 13:58gorka_gilNote Deleted: 0105382

Notes
(0050406)
xplacesc   
2012-07-09 23:20   
Another option could be that Web POS would only retrieve customers with the proper setup, for example payment terms. In this way no customers with empty payment term would be at least initially retrieved by the Web POS
(0085260)
hgbot   
2016-03-22 11:06   
Repository: erp/pmods/org.openbravo.retail.testsampledata
Changeset: b4c4772c47c73b76e2459db25ae0e0e649c58104
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Mar 22 15:29:57 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.testsampledata/rev/b4c4772c47c73b76e2459db25ae0e0e649c58104 [^]

Related to issue 20969 : Adding Payment term & method to customer

---
M referencedata/sampledata/Retail_Test/C_BPARTNER.xml
A referencedata/sampledata/Retail_Test/C_PAYMENTTERM.xml
---
(0085386)
hgbot   
2016-04-01 14:11   
Repository: tools/automation/pi-mobile
Changeset: 25472b34b38f928b0942b8704fd21e4da8e1ce1d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Apr 01 16:02:44 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/25472b34b38f928b0942b8704fd21e4da8e1ce1d [^]

Verifies issue 20969 : Added automated test 'I20969_LoadCustomerBasedOnPaymentTerm'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I20969_LoadCustomerBasedOnPaymentTerm.java
---
(0085540)
hgbot   
2016-04-11 08:39   
Repository: tools/automation/pi-mobile
Changeset: 47e86979b21c32bd39fe681b68ecdbfaff112519
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Apr 11 12:06:45 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/47e86979b21c32bd39fe681b68ecdbfaff112519 [^]

Verifies issue 20969 : Added automated test 'I20969_LoadCustomerBasedOnPaymentTerm'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I20969_LoadCustomerBasedOnPaymentTerm.java
---
(0085542)
hgbot   
2016-04-11 08:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1bb0ecf622e26324ffa37fc1e6d2170513eb2fdb
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Apr 11 12:07:12 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1bb0ecf622e26324ffa37fc1e6d2170513eb2fdb [^]

Fixes issue 20969 : Load customer only if Payment method & Payment terms are associated in Business Partner

---
M src/org/openbravo/retail/posterminal/master/BusinessPartner.java
---
(0085980)
marvintm   
2016-04-26 12:53   
The current solution basically prevents the Web POS from loading business partners which do not have defined payment terms. However, this can be confusing for users as they may be used to seeing those business partners in the system, and when creating a Sales Order from the backend, those will be available to be selected.

A better solution could be to choose a default value for the payment terms of the order, like the backend currently does. As it is a mandatory column with reference TableDir, the first value of the combo should be selected in case the business partner doesn't have payment terms defined.
(0086118)
hgbot   
2016-05-02 12:39   
Repository: tools/automation/pi-mobile
Changeset: 465362e7d9f20b4e5d2d9628da61af4e971c6cde
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Apr 28 15:39:07 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/465362e7d9f20b4e5d2d9628da61af4e971c6cde [^]

Verifies issue 20969 : Added automated test 'I20969_LoadCustomerBasedOnPaymentTerm'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I20969_LoadCustomerBasedOnPaymentTerm.java
---
(0086119)
hgbot   
2016-05-02 12:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: dbc7209657c9215d6c466d623764deea2787838c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 02 16:07:56 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dbc7209657c9215d6c466d623764deea2787838c [^]

Fixes issue 20969 : Order Payment terms & method should be loaded based on Customer default values
If Customer default values is not available, Organizational default values should be applied.
If Organization default value is not avaiable, First value should be loaded from the respective tables

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/master/BusinessPartner.java
---