0020841: Prevent null pointer exception in the FIC component

Description

The FIC component has this code:

      if (currentValue != null && currentValue.equals("null")) {
        currentValue = null;
      }
        RequestContext.get().setRequestParameter("inp" + Sqlc.TransformaNombreColumna(columnName),
            currentValue.toString());

This will result in a NPE as currentValue can be null, in which case currentValue.toString() will throw a NPE

Steps To Reproduce

Not easily reproducible, code is clearly wrong

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0050049) hgbot (developer) 2012-06-22 23:24	Repository: erp/devel/pi Changeset: 8839b720e9f99e6c6d9dcce061026177b0979911 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Fri Jun 22 14:58:32 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/8839b720e9f99e6c6d9dcce061026177b0979911 [^] Fixes issue 20841: Prevent null pointer exception in the FIC component Prevent NPE by adding an if statement and treating null differently --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java ---

(0050070) AugustoMauch (administrator) 2012-06-25 17:24	Code reviewed and verified in pi@bd848324099c

(0050161) hudsonbot (viewer) 2012-06-27 05:29	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf3a7135839f [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2012-06-22 14:57	mtaal	New Issue
2012-06-22 14:57	mtaal	Assigned To	=> mtaal
2012-06-22 14:57	mtaal	Modules	=> Core
2012-06-22 14:57	mtaal	OBNetwork customer	=> No
2012-06-22 23:24	hgbot	Checkin
2012-06-22 23:24	hgbot	Note Added: 0050049
2012-06-22 23:24	hgbot	Status	new => resolved
2012-06-22 23:24	hgbot	Resolution	open => fixed
2012-06-22 23:24	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/8839b720e9f99e6c6d9dcce061026177b0979911 [^]
2012-06-25 17:24	AugustoMauch	Note Added: 0050070
2012-06-25 17:24	AugustoMauch	Status	resolved => closed
2012-06-25 17:24	AugustoMauch	Fixed in Version	=> 3.0MP13
2012-06-27 05:29	hudsonbot	Checkin
2012-06-27 05:29	hudsonbot	Note Added: 0050161