Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020841Openbravo ERPA. Platformpublic2012-06-22 14:572012-06-27 05:29
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP13Fixed in Version3.0MP13 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020841: Prevent null pointer exception in the FIC component
DescriptionThe FIC component has this code:

      if (currentValue != null && currentValue.equals("null")) {
        currentValue = null;
      }
        RequestContext.get().setRequestParameter("inp" + Sqlc.TransformaNombreColumna(columnName),
            currentValue.toString());

This will result in a NPE as currentValue can be null, in which case currentValue.toString() will throw a NPE
Steps To ReproduceNot easily reproducible, code is clearly wrong
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-06-22 14:57mtaalNew Issue
2012-06-22 14:57mtaalAssigned To => mtaal
2012-06-22 14:57mtaalModules => Core
2012-06-22 14:57mtaalOBNetwork customer => No
2012-06-22 23:24hgbotCheckin
2012-06-22 23:24hgbotNote Added: 0050049
2012-06-22 23:24hgbotStatusnew => resolved
2012-06-22 23:24hgbotResolutionopen => fixed
2012-06-22 23:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8839b720e9f99e6c6d9dcce061026177b0979911 [^]
2012-06-25 17:24AugustoMauchNote Added: 0050070
2012-06-25 17:24AugustoMauchStatusresolved => closed
2012-06-25 17:24AugustoMauchFixed in Version => 3.0MP13
2012-06-27 05:29hudsonbotCheckin
2012-06-27 05:29hudsonbotNote Added: 0050161

Notes
(0050049)
hgbot   
2012-06-22 23:24   
Repository: erp/devel/pi
Changeset: 8839b720e9f99e6c6d9dcce061026177b0979911
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Jun 22 14:58:32 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8839b720e9f99e6c6d9dcce061026177b0979911 [^]

Fixes issue 20841: Prevent null pointer exception in the FIC component
Prevent NPE by adding an if statement and treating null differently

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
---
(0050070)
AugustoMauch   
2012-06-25 17:24   
Code reviewed and verified in pi@bd848324099c
(0050161)
hudsonbot   
2012-06-27 05:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf3a7135839f [^]

Maturity status: Test