Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0020748 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 00. Application dictionary | trivial | always | 2012-06-13 13:04 | 2012-06-27 05:28 | |||
| Reporter | Sandrahuguet | View Status | public | |||||
| Assigned To | Sandrahuguet | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0MP13 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | b6f8b7ef982c | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 32 bit | Database | PostgreSQL | Java version | 1.6.0_18 | |||
| OS Version | Professional Appliance | Database version | 8.3.9 | Ant version | 1.7.1 | |||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | Google Chrome | |||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0020748: API Change: change classname length | |||||||
| Description | In the application, there are some tables that contains a column named Classname, this column is used to store the classpath of a Java class. But not all the columns are defined equally. For example: The length of the Classname column inside the AD_AcctProcess table is 60 | |||||||
| Steps To Reproduce | The length of the Classname column inside the AD_AcctProcess table is 60, and it is clearly not enough. It should be at least 255 (as for example the AD_Module.JavaPackage column). Go to Accounting Process window, create a new record and try to enter a long java Class name. | |||||||
| Proposed Solution | The propose solution is change all the columns that have a different length to 1000. They can be found in the tables: AD_Session_Usage_Audit size=200 AD_Process size=200 AD_Form size=200 AD_AcctProcess size=60 AD_Table size=60 | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0049811) Sandrahuguet (developer) 2012-06-13 13:32 edited on: 2012-06-15 11:37 |
Risk statement "classname" column (used in several tables) size is not consistent through the application, most common sizes are 200 and 1000. We think 200 is enough for storing the java class (+ package), but there are two columns with a tight size (60 character long): - AD_ACCTPROCESS.CLASSNAME - AD_TABLE.CLASSNAME We propose to change both columns size to 1000. Any process assuming the classname column size is <= 60, now (depending on how the process is handling) it could fail. For example, if the ad_acctprocess.classname column is synchronized with an external module in a clone of this table (with classname column 60 character long), the process will fail if the received value size is > 60. We think the risk is low. The api-check considers this change as a warning. This is the result: [checkAPI] 39630 WARN - +++++++++++++++++++++++++++++++++++++++++++++++++++ [checkAPI] 39634 WARN - Warnings in API model validation [checkAPI] 39638 WARN - +++++++++++++++++++++++++++++++++++++++++++++++++++ [checkAPI] 39642 WARN - Column size changed from 60 to 1000: column: AD_ACCTPROCESS.CLASSNAME [checkAPI] 39655 WARN - Column size changed from 60 to 1000: column: AD_TABLE.CLASSNAME |
|
(0049877) iciordia (manager) 2012-06-18 10:02 |
Approved. Ismael |
|
(0049943) hgbot (developer) 2012-06-20 11:11 |
Repository: erp/devel/api-checks Changeset: b3ccf1348b66cf5192fe0399f90571fada20c841 Author: Mikel Irurita <mikel.irurita <at> openbravo.com> Date: Wed Jun 20 11:00:36 2012 +0200 URL: http://code.openbravo.com/erp/devel/api-checks/rev/b3ccf1348b66cf5192fe0399f90571fada20c841 [^] Fixes issue 20748: API Change - change AD_ACCTPROCESS.CLASSNAME column length --- M model/src-db/database/model/tables/AD_ACCTPROCESS.xml M model/src-db/database/sourcedata/AD_COLUMN.xml M model/src-db/database/sourcedata/AD_FIELD.xml --- |
|
(0049945) hgbot (developer) 2012-06-20 11:11 |
Repository: erp/devel/pi Changeset: 8b095a62669cdd7528af4709c9972c0355eecff3 Author: Mikel Irurita <mikel.irurita <at> openbravo.com> Date: Wed Jun 20 10:57:48 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/8b095a62669cdd7528af4709c9972c0355eecff3 [^] Related to issue 20748: increase column/field lenght --- M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_FIELD.xml --- |
|
(0050053) hgbot (developer) 2012-06-25 09:53 |
Repository: erp/devel/api-checks Changeset: b6f8b7ef982c98fab139d15ce8443fc98fde8b8e Author: Mikel Irurita <mikel.irurita <at> openbravo.com> Date: Mon Jun 25 09:52:46 2012 +0200 URL: http://code.openbravo.com/erp/devel/api-checks/rev/b6f8b7ef982c98fab139d15ce8443fc98fde8b8e [^] Fixes issue 20748: API Change - change AD_ACCTPROCESS.CLASSNAME column length --- M model/src-db/database/model/tables/AD_ACCTPROCESS.xml M model/src-db/database/sourcedata/AD_COLUMN.xml M model/src-db/database/sourcedata/AD_FIELD.xml --- |
|
(0050129) hudsonbot (developer) 2012-06-27 05:28 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf3a7135839f [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-06-13 13:04 | Sandrahuguet | New Issue | |
| 2012-06-13 13:04 | Sandrahuguet | Assigned To | => Sandrahuguet |
| 2012-06-13 13:04 | Sandrahuguet | Web browser | => Google Chrome |
| 2012-06-13 13:04 | Sandrahuguet | Modules | => Core |
| 2012-06-13 13:09 | Sandrahuguet | Relationship added | depends on 0020675 |
| 2012-06-13 13:32 | Sandrahuguet | Note Added: 0049811 | |
| 2012-06-14 11:59 | Sandrahuguet | Note Edited: 0049811 | View Revisions |
| 2012-06-14 12:00 | Sandrahuguet | Note Edited: 0049811 | View Revisions |
| 2012-06-15 11:37 | mirurita | Note Edited: 0049811 | View Revisions |
| 2012-06-18 10:00 | Sandrahuguet | Assigned To | Sandrahuguet => iciordia |
| 2012-06-18 10:02 | iciordia | Note Added: 0049877 | |
| 2012-06-18 10:02 | iciordia | Assigned To | iciordia => Sandrahuguet |
| 2012-06-20 11:11 | hgbot | Checkin | |
| 2012-06-20 11:11 | hgbot | Note Added: 0049943 | |
| 2012-06-20 11:11 | hgbot | Status | new => resolved |
| 2012-06-20 11:11 | hgbot | Resolution | open => fixed |
| 2012-06-20 11:11 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/api-checks/rev/b3ccf1348b66cf5192fe0399f90571fada20c841 [^] |
| 2012-06-20 11:11 | hgbot | Checkin | |
| 2012-06-20 11:11 | hgbot | Note Added: 0049945 | |
| 2012-06-21 11:52 | mirurita | Status | resolved => closed |
| 2012-06-21 11:52 | mirurita | Fixed in Version | => 3.0MP13 |
| 2012-06-25 09:53 | hgbot | Checkin | |
| 2012-06-25 09:53 | hgbot | Note Added: 0050053 | |
| 2012-06-25 09:53 | hgbot | Status | closed => resolved |
| 2012-06-25 09:53 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/api-checks/rev/b3ccf1348b66cf5192fe0399f90571fada20c841 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/b6f8b7ef982c98fab139d15ce8443fc98fde8b8e [^] |
| 2012-06-26 17:26 | mirurita | Status | resolved => closed |
| 2012-06-27 05:28 | hudsonbot | Checkin | |
| 2012-06-27 05:28 | hudsonbot | Note Added: 0050129 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |