Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020748Openbravo ERP00. Application dictionarypublic2012-06-13 13:042012-06-27 05:28
ReporterSandrahuguet 
Assigned ToSandrahuguet 
PriorityimmediateSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionProfessional Appliance
Product Version 
Target VersionFixed in Version3.0MP13 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020748: API Change: change classname length
DescriptionIn the application, there are some tables that contains a column named Classname, this column is used to store the classpath of a Java class.
But not all the columns are defined equally.
For example:
The length of the Classname column inside the AD_AcctProcess table is 60
Steps To ReproduceThe length of the Classname column inside the AD_AcctProcess table is 60, and it is clearly not enough. It should be at least 255 (as for example the AD_Module.JavaPackage column).
Go to Accounting Process window, create a new record and try to enter a long java Class name.
Proposed SolutionThe propose solution is change all the columns that have a different length to 1000. They can be found in the tables:

AD_Session_Usage_Audit size=200
AD_Process size=200
AD_Form size=200
AD_AcctProcess size=60
AD_Table size=60
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0020675 closed Sandrahuguet AD_AcctProcess.Classname column length 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-06-13 13:04SandrahuguetNew Issue
2012-06-13 13:04SandrahuguetAssigned To => Sandrahuguet
2012-06-13 13:04SandrahuguetWeb browser => Google Chrome
2012-06-13 13:04SandrahuguetModules => Core
2012-06-13 13:09SandrahuguetRelationship addeddepends on 0020675
2012-06-13 13:32SandrahuguetNote Added: 0049811
2012-06-14 11:59SandrahuguetNote Edited: 0049811bug_revision_view_page.php?bugnote_id=0049811#r3551
2012-06-14 12:00SandrahuguetNote Edited: 0049811bug_revision_view_page.php?bugnote_id=0049811#r3552
2012-06-15 11:37miruritaNote Edited: 0049811bug_revision_view_page.php?bugnote_id=0049811#r3553
2012-06-18 10:00SandrahuguetAssigned ToSandrahuguet => iciordia
2012-06-18 10:02iciordiaNote Added: 0049877
2012-06-18 10:02iciordiaAssigned Toiciordia => Sandrahuguet
2012-06-20 11:11hgbotCheckin
2012-06-20 11:11hgbotNote Added: 0049943
2012-06-20 11:11hgbotStatusnew => resolved
2012-06-20 11:11hgbotResolutionopen => fixed
2012-06-20 11:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/b3ccf1348b66cf5192fe0399f90571fada20c841 [^]
2012-06-20 11:11hgbotCheckin
2012-06-20 11:11hgbotNote Added: 0049945
2012-06-21 11:52miruritaStatusresolved => closed
2012-06-21 11:52miruritaFixed in Version => 3.0MP13
2012-06-25 09:53hgbotCheckin
2012-06-25 09:53hgbotNote Added: 0050053
2012-06-25 09:53hgbotStatusclosed => resolved
2012-06-25 09:53hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/api-checks/rev/b3ccf1348b66cf5192fe0399f90571fada20c841 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/b6f8b7ef982c98fab139d15ce8443fc98fde8b8e [^]
2012-06-26 17:26miruritaStatusresolved => closed
2012-06-27 05:28hudsonbotCheckin
2012-06-27 05:28hudsonbotNote Added: 0050129

Notes
(0049811)
Sandrahuguet   
2012-06-13 13:32   
(edited on: 2012-06-15 11:37)
Risk statement
 "classname" column (used in several tables) size is not consistent through the application, most common sizes are 200 and 1000.
 We think 200 is enough for storing the java class (+ package), but there are two columns with a tight size (60 character long):
   - AD_ACCTPROCESS.CLASSNAME
   - AD_TABLE.CLASSNAME

 We propose to change both columns size to 1000.
 
 Any process assuming the classname column size is <= 60, now (depending on how the process is handling) it could fail.
 For example, if the ad_acctprocess.classname column is synchronized with an external module in a clone of this table (with classname column 60 character long), the process will fail if the received value size is > 60.
 
 We think the risk is low.
 
 The api-check considers this change as a warning. This is the result:
 [checkAPI] 39630 WARN - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 39634 WARN - Warnings in API model validation
 [checkAPI] 39638 WARN - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 39642 WARN - Column size changed from 60 to 1000: column: AD_ACCTPROCESS.CLASSNAME
 [checkAPI] 39655 WARN - Column size changed from 60 to 1000: column: AD_TABLE.CLASSNAME
(0049877)
iciordia   
2012-06-18 10:02   
Approved.

Ismael
(0049943)
hgbot   
2012-06-20 11:11   
Repository: erp/devel/api-checks
Changeset: b3ccf1348b66cf5192fe0399f90571fada20c841
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Wed Jun 20 11:00:36 2012 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/b3ccf1348b66cf5192fe0399f90571fada20c841 [^]

Fixes issue 20748: API Change - change AD_ACCTPROCESS.CLASSNAME column length

---
M model/src-db/database/model/tables/AD_ACCTPROCESS.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0049945)
hgbot   
2012-06-20 11:11   
Repository: erp/devel/pi
Changeset: 8b095a62669cdd7528af4709c9972c0355eecff3
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Wed Jun 20 10:57:48 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8b095a62669cdd7528af4709c9972c0355eecff3 [^]

Related to issue 20748: increase column/field lenght

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0050053)
hgbot   
2012-06-25 09:53   
Repository: erp/devel/api-checks
Changeset: b6f8b7ef982c98fab139d15ce8443fc98fde8b8e
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Mon Jun 25 09:52:46 2012 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/b6f8b7ef982c98fab139d15ce8443fc98fde8b8e [^]

Fixes issue 20748: API Change - change AD_ACCTPROCESS.CLASSNAME column length

---
M model/src-db/database/model/tables/AD_ACCTPROCESS.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0050129)
hudsonbot   
2012-06-27 05:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf3a7135839f [^]

Maturity status: Test