Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0020727
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] A. Platformminoralways2012-06-12 09:452022-02-01 08:09
ReporteriperdomoView Statuspublic 
Assigned ToTriage Platform Base 
PrioritynormalResolutionopenFixed in Version
StatusacknowledgedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava versionOpenJDK 1.6.0_24
OS Version3.3.7-1-ARCHDatabase version9.1.3Ant version1.8.2
Product VersionSCM revision 
Review Assigned To
Web browserGoogle Chrome
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020727: WADValidation should check the mapping name of *all* servlets, not only the ones associated to process or windows

DescriptionAccording to Modularity's naming rules, the mapping names of manual code (servlets) need to start with the Java package of the module.

"...mapping for all manual objects (forms, searchs, reports and processes) must start now with the module's package. For example, the mapping for a report in a module with package (org.myCompany.moduleTest) could be /org.myCompany.moduleTesr.reports/MyReport.html."

http://forge.openbravo.com/projects/openbravoerp/forum/viewtopic.php?group_id=100&forumid=549512&topicid=7006555 [^]

Currently you can register a Servlet breaking this naming rule and WADValidation doesn't warn about it
Steps To Reproduce* Create a module with javapackage: org.openbravo.issues.wadvalidation
* Create a new AD Implementation in the Application Dictionary for a new servlet
* Add a mapping name: /org.openbravo.service.json/test.html
* Compile: ant smartbuild

* Expected result: WADValidation should warn the user of an invalid mapping name
* Actual result: No problem is reported to the user
Proposed SolutionWADValidation should WARN on any servlet mapping name:

select m.javapackage, mo.ad_module_id, mo.classname, mom.mappingname, mom.isactive
  from ad_model_object mo, ad_model_object_mapping mom, ad_module m
 where mo.ad_module_id is not null
   and mo.ad_module_id <> '0'
   and mom.ad_model_object_id = mo.ad_model_object_id
   and mo.ad_module_id = m.ad_module_id
   and mo.object_type = 'S'
   and mom.mappingname not like '/'||m.javapackage||'%'
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0052322)
AugustoMauch (manager)
2012-09-24 12:35

Effort: 1
Impact: low
Plan: mid

- Issue History
Date Modified Username Field Change
2012-06-12 09:45 iperdomo New Issue
2012-06-12 09:45 iperdomo Assigned To => alostale
2012-06-12 09:45 iperdomo Web browser => Google Chrome
2012-06-12 09:45 iperdomo Modules => Core
2012-06-12 12:17 alostale Web browser Google Chrome => Google Chrome
2012-06-12 12:17 alostale Type defect => design defect
2012-09-24 12:35 AugustoMauch Web browser Google Chrome => Google Chrome
2012-09-24 12:35 AugustoMauch Note Added: 0052322
2012-09-24 12:35 AugustoMauch Priority urgent => normal
2012-09-24 12:35 AugustoMauch Status new => scheduled
2017-03-31 14:36 alostale Status scheduled => acknowledged
2017-04-10 14:33 alostale Assigned To alostale => platform
2022-02-01 08:09 alostale Assigned To platform => Triage Platform Base


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker