Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0020727Openbravo ERPA. Platformpublic2012-06-12 09:452022-02-01 08:09
iperdomo 
Triage Platform Base 
normalminoralways
acknowledgedopen 
303.3.7-1-ARCH
 
 
Google Chrome
Core
No
0020727: WADValidation should check the mapping name of *all* servlets, not only the ones associated to process or windows
According to Modularity's naming rules, the mapping names of manual code (servlets) need to start with the Java package of the module.

"...mapping for all manual objects (forms, searchs, reports and processes) must start now with the module's package. For example, the mapping for a report in a module with package (org.myCompany.moduleTest) could be /org.myCompany.moduleTesr.reports/MyReport.html."

http://forge.openbravo.com/projects/openbravoerp/forum/viewtopic.php?group_id=100&forumid=549512&topicid=7006555 [^]

Currently you can register a Servlet breaking this naming rule and WADValidation doesn't warn about it
* Create a module with javapackage: org.openbravo.issues.wadvalidation
* Create a new AD Implementation in the Application Dictionary for a new servlet
* Add a mapping name: /org.openbravo.service.json/test.html
* Compile: ant smartbuild

* Expected result: WADValidation should warn the user of an invalid mapping name
* Actual result: No problem is reported to the user
WADValidation should WARN on any servlet mapping name:

select m.javapackage, mo.ad_module_id, mo.classname, mom.mappingname, mom.isactive
  from ad_model_object mo, ad_model_object_mapping mom, ad_module m
 where mo.ad_module_id is not null
   and mo.ad_module_id <> '0'
   and mom.ad_model_object_id = mo.ad_model_object_id
   and mo.ad_module_id = m.ad_module_id
   and mo.object_type = 'S'
   and mom.mappingname not like '/'||m.javapackage||'%'
No tags attached.
Issue History
2012-06-12 09:45iperdomoNew Issue
2012-06-12 09:45iperdomoAssigned To => alostale
2012-06-12 09:45iperdomoWeb browser => Google Chrome
2012-06-12 09:45iperdomoModules => Core
2012-06-12 12:17alostaleWeb browserGoogle Chrome => Google Chrome
2012-06-12 12:17alostaleTypedefect => design defect
2012-09-24 12:35AugustoMauchWeb browserGoogle Chrome => Google Chrome
2012-09-24 12:35AugustoMauchNote Added: 0052322
2012-09-24 12:35AugustoMauchPriorityurgent => normal
2012-09-24 12:35AugustoMauchStatusnew => scheduled
2017-03-31 14:36alostaleStatusscheduled => acknowledged
2017-04-10 14:33alostaleAssigned Toalostale => platform
2022-02-01 08:09alostaleAssigned Toplatform => Triage Platform Base

Notes
(0052322)
AugustoMauch   
2012-09-24 12:35   
Effort: 1
Impact: low
Plan: mid