Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0020652
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 04. Warehouse managementmajoralways2012-05-31 09:372012-07-26 02:42
ReporterdmiguelezView Statuspublic 
Assigned Todmiguelez 
PrioritynormalResolutionfixedFixed in Version3.0MP14
StatusclosedFix in branchpiFixed in SCM revisionb591fe7bbc28
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020652: Bill of Materials validation results in a false positive

DescriptionBill of Materials validation returns a message of a cycle when creating a BOM, but it is not true.

A Product D is created from three different products A, B and C.
Then a Product E is created using D and A.

A ----\
B ---- > D ----\
C ----/ \ E
                /
         A ----/

This is not a cycle and it should work.
Steps To ReproduceLogin as Openbravo/openbravo

Change rol to QA Testing Admin.

Go to Product Window and create a new Product:
"Organization": USA
"Search Key": PD
"Name": Product D
"Product Category": Bill of Materials
"Bill of Materials": Checked

Move to Bill of Materials tab.
Create a new record.
"BOM Product":Raw Material A
"BOM Quantity": 1
Create a new record.
"BOM Product":Raw Material B
"BOM Quantity": 1
Create a new record.
"BOM Product":Raw Material C
"BOM Quantity": 1

Click on Verify BOM, thenk OK. "Process completed successfully"

Create a new Product:
"Organization": USA
"Search Key": PE
"Name": Product E
"Product Category": Bill of Materials
"Bill of Materials": Checked

Move to Bill of Materials tab.
Create a new record.
"BOM Product":Raw Material A
"BOM Quantity": 1
Create a new record.
"BOM Product":Product E
"BOM Quantity": 1

Click on Verify BOM, thenk OK.
Error "BOM Tree Contains a Cycle"
TagsNo tags attached.
Attached Filesjpg file icon trees.jpg [^] (35,725 bytes) 2012-06-04 17:51

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0020711 closeddmiguelez API Change Request 

-  Notes
(0049609)
dmiguelez (developer)
2012-06-04 17:50

Test Plan:

Login as Openbravo/openbravo

Change rol to QA Testing Admin.

Go to Product Window and create a new Product:
"Organization": USA
"Search Key": PA
"Name": ProductA
"Product Category": Bill of Materials
"Bill of Materials": Checked

Create a new Product:
"Organization": USA
"Search Key": PB
"Name": ProductB
"Product Category": Bill of Materials
"Bill of Materials": Checked

Create a new Product:
"Organization": USA
"Search Key": PC
"Name": ProductC
"Product Category": Bill of Materials
"Bill of Materials": Checked

Create a new Product:
"Organization": USA
"Search Key": PD
"Name": ProductD
"Product Category": Bill of Materials
"Bill of Materials": Checked

Create a new Product:
"Organization": USA
"Search Key": PE
"Name": ProductE
"Product Category": Bill of Materials
"Bill of Materials": Checked

Attached there is a picture of the different trees that need to be created for testing this issue.
If next to the picture there is a green dot, then the "Verify BOM" should result in a succesful message.
If the dot is red, then an error message should appear.

For creating the tree structure, BOM definitions must be enter for each product.
Here is an example of how to do it.

Move to Bill of Materials tab.
Create a new record.
"BOM Product":Raw Material A
"BOM Quantity": 1
Create a new record.
"BOM Product":Raw Material B
"BOM Quantity": 1
Create a new record.
"BOM Product":Raw Material C
"BOM Quantity": 1

For verifying the tree:
Click on Verify BOM, thenk OK.
(0050496)
hgbot (developer)
2012-07-11 16:31

Repository: erp/devel/pi
Changeset: 60e449f25f2309834f96b2e7b885daae58c93a9e
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jul 11 13:59:11 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/60e449f25f2309834f96b2e7b885daae58c93a9e [^]

Fixes issue 20652: Bill of Materials validation results in a false positive

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_PROCESS.xml
A src/org/openbravo/erpCommon/ad_process/VerifyBOM.java
---
(0050497)
hgbot (developer)
2012-07-11 16:31

Repository: erp/devel/pi
Changeset: a53efff1a3c8d5dbaee1e617bd77ed75a5b262af
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jul 11 16:10:29 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a53efff1a3c8d5dbaee1e617bd77ed75a5b262af [^]

Related to issue 20652: Remove M_PRODUCT_BOM_CHECK

---
R src-db/database/model/functions/M_PRODUCT_BOM_CHECK.xml
---
(0050501)
mirurita (developer)
2012-07-11 16:56

code review + testing OK

Note: in the steps to reproduce when creating the BOM for product E, there is a mistake, because if you select the product E as BOM for product E your tree will contain a cycle. You should select product D.

All the scenarios described in the attached screenshot are working fine.
(0050582)
hgbot (developer)
2012-07-15 17:37

Repository: erp/devel/pi
Changeset: 8b6b5db94fcbd66773893560a23aa66a79f2ae78
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Jul 15 12:42:19 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8b6b5db94fcbd66773893560a23aa66a79f2ae78 [^]

Issue 20652: Temporarily backout 60e449f25f23 as it should not be promoted to MP13

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_PROCESS.xml
R src/org/openbravo/erpCommon/ad_process/VerifyBOM.java
---
(0050583)
hgbot (developer)
2012-07-15 17:37

Repository: erp/devel/pi
Changeset: f4befe4e2802c8a6b0f0ebbbbe418e6ddf4365bc
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Jul 15 12:42:49 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f4befe4e2802c8a6b0f0ebbbbe418e6ddf4365bc [^]

Issue 20652: Temporarily backout a53efff1a3c8 as it should not be promoted to MP13

---
A src-db/database/model/functions/M_PRODUCT_BOM_CHECK.xml
---
(0050585)
shuehner (administrator)
2012-07-15 17:38

The change needed to fix this has been temporarily backed out to not be promoted to mp13.
It will be reapplied as soon as the code for mp13 ready.
(0050741)
hgbot (developer)
2012-07-18 19:05

Repository: erp/devel/pi
Changeset: bd9d962a26a555fddd70e6346d814e835d0e4b23
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Jul 18 18:59:26 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bd9d962a26a555fddd70e6346d814e835d0e4b23 [^]

Issue 20652: backout the temporary backout done in 8b6b5db94fcb thus restoring
the original changeset from revision 60e449f25f23

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_PROCESS.xml
A src/org/openbravo/erpCommon/ad_process/VerifyBOM.java
---
(0050742)
hgbot (developer)
2012-07-18 19:06

Repository: erp/devel/pi
Changeset: b591fe7bbc283157c0b1ba410cf850931ad45da6
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Jul 18 19:01:00 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b591fe7bbc283157c0b1ba410cf850931ad45da6 [^]

Issue 20652: backout the temporary backout done in f4befe4e2802 thus restoring
the original changeset from revision a53efff1a3c8

---
R src-db/database/model/functions/M_PRODUCT_BOM_CHECK.xml
---
(0050744)
mirurita (developer)
2012-07-19 10:38

closed again after the backout to do not promoted to mp13
(0050857)
hudsonbot (developer)
2012-07-26 02:42

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^]

Maturity status: Test
(0050858)
hudsonbot (developer)
2012-07-26 02:42

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-05-31 09:37 dmiguelez New Issue
2012-05-31 09:37 dmiguelez Assigned To => mirurita
2012-05-31 09:37 dmiguelez Modules => Core
2012-06-01 13:51 dmiguelez Assigned To mirurita => dmiguelez
2012-06-01 13:51 dmiguelez Status new => scheduled
2012-06-01 13:51 dmiguelez fix_in_branch => pi
2012-06-04 17:50 dmiguelez Note Added: 0049609
2012-06-04 17:51 dmiguelez File Added: trees.jpg
2012-06-08 12:27 dmiguelez Relationship added related to 0020711
2012-07-11 16:31 hgbot Checkin
2012-07-11 16:31 hgbot Note Added: 0050496
2012-07-11 16:31 hgbot Status scheduled => resolved
2012-07-11 16:31 hgbot Resolution open => fixed
2012-07-11 16:31 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/60e449f25f2309834f96b2e7b885daae58c93a9e [^]
2012-07-11 16:31 hgbot Checkin
2012-07-11 16:31 hgbot Note Added: 0050497
2012-07-11 16:56 mirurita Note Added: 0050501
2012-07-11 16:56 mirurita Status resolved => closed
2012-07-11 16:56 mirurita Fixed in Version => 3.0MP14
2012-07-15 17:37 hgbot Checkin
2012-07-15 17:37 hgbot Note Added: 0050582
2012-07-15 17:37 hgbot Checkin
2012-07-15 17:37 hgbot Note Added: 0050583
2012-07-15 17:38 shuehner Note Added: 0050585
2012-07-15 17:38 shuehner Status closed => new
2012-07-15 17:38 shuehner Resolution fixed => open
2012-07-15 17:38 shuehner Fixed in Version 3.0MP14 =>
2012-07-18 19:05 hgbot Checkin
2012-07-18 19:05 hgbot Note Added: 0050741
2012-07-18 19:06 hgbot Checkin
2012-07-18 19:06 hgbot Note Added: 0050742
2012-07-18 19:08 shuehner Status new => scheduled
2012-07-18 19:08 shuehner Status scheduled => resolved
2012-07-18 19:08 shuehner Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/60e449f25f2309834f96b2e7b885daae58c93a9e [^] => http://code.openbravo.com/erp/devel/pi/rev/b591fe7bbc283157c0b1ba410cf850931ad45da6 [^]
2012-07-18 19:08 shuehner Resolution open => fixed
2012-07-19 10:38 mirurita Note Added: 0050744
2012-07-19 10:38 mirurita Status resolved => closed
2012-07-19 10:38 mirurita Fixed in Version => 3.0MP14
2012-07-26 02:42 hudsonbot Checkin
2012-07-26 02:42 hudsonbot Note Added: 0050857
2012-07-26 02:42 hudsonbot Checkin
2012-07-26 02:42 hudsonbot Note Added: 0050858


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker