Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020652Openbravo ERP04. Warehouse managementpublic2012-05-31 09:372012-07-26 02:42
Reporterdmiguelez 
Assigned Todmiguelez 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version3.0MP14 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020652: Bill of Materials validation results in a false positive
DescriptionBill of Materials validation returns a message of a cycle when creating a BOM, but it is not true.

A Product D is created from three different products A, B and C.
Then a Product E is created using D and A.

A ----\
B ---- > D ----\
C ----/ \ E
                /
         A ----/

This is not a cycle and it should work.
Steps To ReproduceLogin as Openbravo/openbravo

Change rol to QA Testing Admin.

Go to Product Window and create a new Product:
"Organization": USA
"Search Key": PD
"Name": Product D
"Product Category": Bill of Materials
"Bill of Materials": Checked

Move to Bill of Materials tab.
Create a new record.
"BOM Product":Raw Material A
"BOM Quantity": 1
Create a new record.
"BOM Product":Raw Material B
"BOM Quantity": 1
Create a new record.
"BOM Product":Raw Material C
"BOM Quantity": 1

Click on Verify BOM, thenk OK. "Process completed successfully"

Create a new Product:
"Organization": USA
"Search Key": PE
"Name": Product E
"Product Category": Bill of Materials
"Bill of Materials": Checked

Move to Bill of Materials tab.
Create a new record.
"BOM Product":Raw Material A
"BOM Quantity": 1
Create a new record.
"BOM Product":Product E
"BOM Quantity": 1

Click on Verify BOM, thenk OK.
Error "BOM Tree Contains a Cycle"
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0020711 closed dmiguelez API Change Request 
Attached Filesjpg trees.jpg (35,725) 2012-06-04 17:51
https://issues.openbravo.com/file_download.php?file_id=5276&type=bug
jpg
Issue History
Date ModifiedUsernameFieldChange
2012-05-31 09:37dmiguelezNew Issue
2012-05-31 09:37dmiguelezAssigned To => mirurita
2012-05-31 09:37dmiguelezModules => Core
2012-05-31 09:37dmiguelezOBNetwork customer => No
2012-06-01 13:51dmiguelezAssigned Tomirurita => dmiguelez
2012-06-01 13:51dmiguelezStatusnew => scheduled
2012-06-01 13:51dmiguelezfix_in_branch => pi
2012-06-04 17:50dmiguelezNote Added: 0049609
2012-06-04 17:51dmiguelezFile Added: trees.jpg
2012-06-08 12:27dmiguelezRelationship addedrelated to 0020711
2012-07-11 16:31hgbotCheckin
2012-07-11 16:31hgbotNote Added: 0050496
2012-07-11 16:31hgbotStatusscheduled => resolved
2012-07-11 16:31hgbotResolutionopen => fixed
2012-07-11 16:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/60e449f25f2309834f96b2e7b885daae58c93a9e [^]
2012-07-11 16:31hgbotCheckin
2012-07-11 16:31hgbotNote Added: 0050497
2012-07-11 16:56miruritaNote Added: 0050501
2012-07-11 16:56miruritaStatusresolved => closed
2012-07-11 16:56miruritaFixed in Version => 3.0MP14
2012-07-15 17:37hgbotCheckin
2012-07-15 17:37hgbotNote Added: 0050582
2012-07-15 17:37hgbotCheckin
2012-07-15 17:37hgbotNote Added: 0050583
2012-07-15 17:38shuehnerNote Added: 0050585
2012-07-15 17:38shuehnerStatusclosed => new
2012-07-15 17:38shuehnerResolutionfixed => open
2012-07-15 17:38shuehnerFixed in Version3.0MP14 =>
2012-07-18 19:05hgbotCheckin
2012-07-18 19:05hgbotNote Added: 0050741
2012-07-18 19:06hgbotCheckin
2012-07-18 19:06hgbotNote Added: 0050742
2012-07-18 19:08shuehnerStatusnew => scheduled
2012-07-18 19:08shuehnerStatusscheduled => resolved
2012-07-18 19:08shuehnerFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/60e449f25f2309834f96b2e7b885daae58c93a9e [^] => http://code.openbravo.com/erp/devel/pi/rev/b591fe7bbc283157c0b1ba410cf850931ad45da6 [^]
2012-07-18 19:08shuehnerResolutionopen => fixed
2012-07-19 10:38miruritaNote Added: 0050744
2012-07-19 10:38miruritaStatusresolved => closed
2012-07-19 10:38miruritaFixed in Version => 3.0MP14
2012-07-26 02:42hudsonbotCheckin
2012-07-26 02:42hudsonbotNote Added: 0050857
2012-07-26 02:42hudsonbotCheckin
2012-07-26 02:42hudsonbotNote Added: 0050858

Notes
(0049609)
dmiguelez   
2012-06-04 17:50   
Test Plan:

Login as Openbravo/openbravo

Change rol to QA Testing Admin.

Go to Product Window and create a new Product:
"Organization": USA
"Search Key": PA
"Name": ProductA
"Product Category": Bill of Materials
"Bill of Materials": Checked

Create a new Product:
"Organization": USA
"Search Key": PB
"Name": ProductB
"Product Category": Bill of Materials
"Bill of Materials": Checked

Create a new Product:
"Organization": USA
"Search Key": PC
"Name": ProductC
"Product Category": Bill of Materials
"Bill of Materials": Checked

Create a new Product:
"Organization": USA
"Search Key": PD
"Name": ProductD
"Product Category": Bill of Materials
"Bill of Materials": Checked

Create a new Product:
"Organization": USA
"Search Key": PE
"Name": ProductE
"Product Category": Bill of Materials
"Bill of Materials": Checked

Attached there is a picture of the different trees that need to be created for testing this issue.
If next to the picture there is a green dot, then the "Verify BOM" should result in a succesful message.
If the dot is red, then an error message should appear.

For creating the tree structure, BOM definitions must be enter for each product.
Here is an example of how to do it.

Move to Bill of Materials tab.
Create a new record.
"BOM Product":Raw Material A
"BOM Quantity": 1
Create a new record.
"BOM Product":Raw Material B
"BOM Quantity": 1
Create a new record.
"BOM Product":Raw Material C
"BOM Quantity": 1

For verifying the tree:
Click on Verify BOM, thenk OK.
(0050496)
hgbot   
2012-07-11 16:31   
Repository: erp/devel/pi
Changeset: 60e449f25f2309834f96b2e7b885daae58c93a9e
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jul 11 13:59:11 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/60e449f25f2309834f96b2e7b885daae58c93a9e [^]

Fixes issue 20652: Bill of Materials validation results in a false positive

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_PROCESS.xml
A src/org/openbravo/erpCommon/ad_process/VerifyBOM.java
---
(0050497)
hgbot   
2012-07-11 16:31   
Repository: erp/devel/pi
Changeset: a53efff1a3c8d5dbaee1e617bd77ed75a5b262af
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jul 11 16:10:29 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a53efff1a3c8d5dbaee1e617bd77ed75a5b262af [^]

Related to issue 20652: Remove M_PRODUCT_BOM_CHECK

---
R src-db/database/model/functions/M_PRODUCT_BOM_CHECK.xml
---
(0050501)
mirurita   
2012-07-11 16:56   
code review + testing OK

Note: in the steps to reproduce when creating the BOM for product E, there is a mistake, because if you select the product E as BOM for product E your tree will contain a cycle. You should select product D.

All the scenarios described in the attached screenshot are working fine.
(0050582)
hgbot   
2012-07-15 17:37   
Repository: erp/devel/pi
Changeset: 8b6b5db94fcbd66773893560a23aa66a79f2ae78
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Jul 15 12:42:19 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8b6b5db94fcbd66773893560a23aa66a79f2ae78 [^]

Issue 20652: Temporarily backout 60e449f25f23 as it should not be promoted to MP13

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_PROCESS.xml
R src/org/openbravo/erpCommon/ad_process/VerifyBOM.java
---
(0050583)
hgbot   
2012-07-15 17:37   
Repository: erp/devel/pi
Changeset: f4befe4e2802c8a6b0f0ebbbbe418e6ddf4365bc
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Jul 15 12:42:49 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f4befe4e2802c8a6b0f0ebbbbe418e6ddf4365bc [^]

Issue 20652: Temporarily backout a53efff1a3c8 as it should not be promoted to MP13

---
A src-db/database/model/functions/M_PRODUCT_BOM_CHECK.xml
---
(0050585)
shuehner   
2012-07-15 17:38   
The change needed to fix this has been temporarily backed out to not be promoted to mp13.
It will be reapplied as soon as the code for mp13 ready.
(0050741)
hgbot   
2012-07-18 19:05   
Repository: erp/devel/pi
Changeset: bd9d962a26a555fddd70e6346d814e835d0e4b23
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Jul 18 18:59:26 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bd9d962a26a555fddd70e6346d814e835d0e4b23 [^]

Issue 20652: backout the temporary backout done in 8b6b5db94fcb thus restoring
the original changeset from revision 60e449f25f23

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_PROCESS.xml
A src/org/openbravo/erpCommon/ad_process/VerifyBOM.java
---
(0050742)
hgbot   
2012-07-18 19:06   
Repository: erp/devel/pi
Changeset: b591fe7bbc283157c0b1ba410cf850931ad45da6
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Jul 18 19:01:00 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b591fe7bbc283157c0b1ba410cf850931ad45da6 [^]

Issue 20652: backout the temporary backout done in f4befe4e2802 thus restoring
the original changeset from revision a53efff1a3c8

---
R src-db/database/model/functions/M_PRODUCT_BOM_CHECK.xml
---
(0050744)
mirurita   
2012-07-19 10:38   
closed again after the backout to do not promoted to mp13
(0050857)
hudsonbot   
2012-07-26 02:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^]

Maturity status: Test
(0050858)
hudsonbot   
2012-07-26 02:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^]

Maturity status: Test