Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0020457
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2012-05-09 12:482012-05-25 12:11
ReportermarvintmView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revisione720f25cba62
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020457: Link to window in the toolbar even if the role doesn't have access to the window

DescriptionLinks in fields are dynamically hidden if the role doesn't have access to the window. So, for example, the field "Transaction document" in Sales Invoice is not shown if the role doesn't have access to the Document Types window.

However, this doesn't work in the case of the fields in the toolbar. In that case, the link is shown in all cases, and if the user clicks on it while being logged in a role without access to that window, the window is opened, but an ugly red message is shown.
Steps To ReproduceIn a role without access to the Currency window, click on the Currency link in a Sales Invoice.
The currency window will be shown, and a not nice red error will also be shown.
Proposed SolutionThe link should be hidden like it is on normal non-toolbar fields.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0016874 closedguilleaer Title of field with not-accessible entity still clickable 

-  Notes
(0048510)
hgbot (developer)
2012-05-09 15:44

Repository: erp/devel/pi
Changeset: e720f25cba6280ec0cc7731ae6f4157cf9f85d25
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed May 09 15:43:52 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e720f25cba6280ec0cc7731ae6f4157cf9f85d25 [^]

Fixes issue 20457: Link removed in status bar if window not accessible

If a field with a link was shown in the status bar, the link was active regardless of the accessibility to the target window. Now, there will only be a link if the target window is accessible by the current role.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-statusbar.js
---
(0048511)
AugustoMauch (developer)
2012-05-09 15:52

Test plan:
- Login as F&B Admin
- Open the role Window
- Select the F&B Admin role
- Delete from the Window Access tab the Currency entry
- Log out and Login again as F&B Admin
- Open the Sales Order window
- Open any registry in form view.
- The currency field should be shown in form view, but it should not be a link to the Currency window.

Check that the links in the status keep working (there are some in the Accounting tab of the Financial Account window).
(0048512)
AugustoMauch (developer)
2012-05-09 15:52

This fix is not risky.
(0048523)
guilleaer (developer)
2012-05-09 17:52

Code reviewed and tested in pi@e720f25cba62
(0049082)
hudsonbot (developer)
2012-05-25 12:11

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-05-09 12:48 marvintm New Issue
2012-05-09 12:48 marvintm Assigned To => AugustoMauch
2012-05-09 12:48 marvintm Modules => Core
2012-05-09 15:01 AugustoMauch Relationship added related to 0016874
2012-05-09 15:44 hgbot Checkin
2012-05-09 15:44 hgbot Note Added: 0048510
2012-05-09 15:44 hgbot Status new => resolved
2012-05-09 15:44 hgbot Resolution open => fixed
2012-05-09 15:44 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e720f25cba6280ec0cc7731ae6f4157cf9f85d25 [^]
2012-05-09 15:52 AugustoMauch Note Added: 0048511
2012-05-09 15:52 AugustoMauch Note Added: 0048512
2012-05-09 17:52 guilleaer Note Added: 0048523
2012-05-09 17:52 guilleaer Status resolved => closed
2012-05-09 17:52 guilleaer Fixed in Version => pi
2012-05-25 12:11 hudsonbot Checkin
2012-05-25 12:11 hudsonbot Note Added: 0049082


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker