Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020457Openbravo ERPA. Platformpublic2012-05-09 12:482012-05-25 12:11
Reportermarvintm 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020457: Link to window in the toolbar even if the role doesn't have access to the window
DescriptionLinks in fields are dynamically hidden if the role doesn't have access to the window. So, for example, the field "Transaction document" in Sales Invoice is not shown if the role doesn't have access to the Document Types window.

However, this doesn't work in the case of the fields in the toolbar. In that case, the link is shown in all cases, and if the user clicks on it while being logged in a role without access to that window, the window is opened, but an ugly red message is shown.
Steps To ReproduceIn a role without access to the Currency window, click on the Currency link in a Sales Invoice.
The currency window will be shown, and a not nice red error will also be shown.
Proposed SolutionThe link should be hidden like it is on normal non-toolbar fields.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0016874 closed guilleaer Title of field with not-accessible entity still clickable 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-05-09 12:48marvintmNew Issue
2012-05-09 12:48marvintmAssigned To => AugustoMauch
2012-05-09 12:48marvintmModules => Core
2012-05-09 15:01AugustoMauchRelationship addedrelated to 0016874
2012-05-09 15:44hgbotCheckin
2012-05-09 15:44hgbotNote Added: 0048510
2012-05-09 15:44hgbotStatusnew => resolved
2012-05-09 15:44hgbotResolutionopen => fixed
2012-05-09 15:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e720f25cba6280ec0cc7731ae6f4157cf9f85d25 [^]
2012-05-09 15:52AugustoMauchNote Added: 0048511
2012-05-09 15:52AugustoMauchNote Added: 0048512
2012-05-09 17:52guilleaerNote Added: 0048523
2012-05-09 17:52guilleaerStatusresolved => closed
2012-05-09 17:52guilleaerFixed in Version => pi
2012-05-25 12:11hudsonbotCheckin
2012-05-25 12:11hudsonbotNote Added: 0049082

Notes
(0048510)
hgbot   
2012-05-09 15:44   
Repository: erp/devel/pi
Changeset: e720f25cba6280ec0cc7731ae6f4157cf9f85d25
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed May 09 15:43:52 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e720f25cba6280ec0cc7731ae6f4157cf9f85d25 [^]

Fixes issue 20457: Link removed in status bar if window not accessible

If a field with a link was shown in the status bar, the link was active regardless of the accessibility to the target window. Now, there will only be a link if the target window is accessible by the current role.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-statusbar.js
---
(0048511)
AugustoMauch   
2012-05-09 15:52   
Test plan:
- Login as F&B Admin
- Open the role Window
- Select the F&B Admin role
- Delete from the Window Access tab the Currency entry
- Log out and Login again as F&B Admin
- Open the Sales Order window
- Open any registry in form view.
- The currency field should be shown in form view, but it should not be a link to the Currency window.

Check that the links in the status keep working (there are some in the Accounting tab of the Financial Account window).
(0048512)
AugustoMauch   
2012-05-09 15:52   
This fix is not risky.
(0048523)
guilleaer   
2012-05-09 17:52   
Code reviewed and tested in pi@e720f25cba62
(0049082)
hudsonbot   
2012-05-25 12:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test