Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0020438
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajorhave not tried2012-05-07 23:082012-05-25 12:11
ReportermtaalView Statuspublic 
Assigned Tomirurita 
PrioritynormalResolutionfixedFixed in Version3.0MP12
StatusclosedFix in branchFixed in SCM revision2723f376b165
ProjectionnoneETAnoneTarget Version3.0MP12
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020438: Date filter in selector popup grid does not work because of invalid override in other js file

DescriptionThe date filter of the selector grid in the match transaction window does not work. The date field is always set back to the current date. The reason is that internally for formatting Openbravo uses the javascript Date object, the setFullYear method.
However this method is overridden/overwritten in the file calendar.js (web/js/jscalendar/calendar.js). The calendar.js does this in an incorrect way, the second and third parameter are ignored.
Steps To ReproduceTo reproduce:
Go to "Financial Account"
Select record "Bank - Account 2"

In form mode do this change: Matching Algorithm -> Standard

Now go to its child tab "Imported Bank Statement"
Create new one and fill
Name: "test"

Now go to its child tab "Bank Statement Lines"
Create new one and fill
Reference No: Line1
Amout IN: 10

Create new one and fill
Reference No: Line2
Amout IN: 20

Click button "Process"

Click button "Match Statement"

Click the magnifier glass icon.

The grid opens, enter a date in the first column, when you tab out the date is changed to the current date.
Proposed SolutionDo not use the calendar.js in this html page, removing it should resolve this issue.
TagsNo tags attached.
Attached Filespng file icon Screenshot at 2012-05-07 23:08:10.png [^] (40,902 bytes) 2012-05-07 23:08

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0020412 closedmtaal "Match Statement" popup doesn't show the grid 

-  Notes
(0048425)
dbaz (developer)
2012-05-07 23:37

Note that it fails at least from MP11
(0048519)
naiaramartinez (developer)
2012-05-09 17:39

Test Plan:
  Go to "Financial Account"
  Select record "Bank - Account 2"

  In form mode do this change if it is not already done: Matching Algorithm -> Standard

  Now go to its child tab "Imported Bank Statement"
  Create new one and fill
  Name: "test"

  Now go to its child tab "Bank Statement Lines"
  Create new one and fill
  Reference No: Line1
  Amout IN: 10

  Create new one and fill
  Reference No: Line2
  Amout IN: 20

  Click button "Process"

  Click button "Match Statement"

  Click the magnifier glass icon.

  The grid opens, enter a date in the first column, notice that the date is not changing to current date.
(0048620)
hgbot (developer)
2012-05-14 14:03

Repository: erp/devel/pi
Changeset: 2723f376b165731f69e708b49b0e7d568c7ad80e
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Wed May 09 17:36:36 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2723f376b165731f69e708b49b0e7d568c7ad80e [^]

fixed bug 20438 Delete calendar.js from MatchTransaction.html

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.html
---
(0048621)
hgbot (developer)
2012-05-14 14:03

Repository: erp/devel/pi
Changeset: 6219c9731ca78f85d759dea0c6ae3f36d8cc1669
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Mon May 14 13:37:08 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6219c9731ca78f85d759dea0c6ae3f36d8cc1669 [^]

Related to issue 20438: remove calendar-es.js file import

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.html
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.xml
---
(0048826)
mirurita (developer)
2012-05-21 18:07

code review + testing OK
(0049118)
hudsonbot (developer)
2012-05-25 12:11

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0049119)
hudsonbot (developer)
2012-05-25 12:11

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-05-07 23:08 mtaal New Issue
2012-05-07 23:08 mtaal Assigned To => vmromanos
2012-05-07 23:08 mtaal File Added: Screenshot at 2012-05-07 23:08:10.png
2012-05-07 23:08 mtaal Modules => Core
2012-05-07 23:08 mtaal Relationship added related to 0020412
2012-05-07 23:08 mtaal Assigned To vmromanos => mirurita
2012-05-07 23:37 dbaz Note Added: 0048425
2012-05-09 17:39 naiaramartinez Note Added: 0048519
2012-05-14 14:03 hgbot Checkin
2012-05-14 14:03 hgbot Note Added: 0048620
2012-05-14 14:03 hgbot Status new => resolved
2012-05-14 14:03 hgbot Resolution open => fixed
2012-05-14 14:03 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2723f376b165731f69e708b49b0e7d568c7ad80e [^]
2012-05-14 14:03 hgbot Checkin
2012-05-14 14:03 hgbot Note Added: 0048621
2012-05-21 18:07 mirurita Note Added: 0048826
2012-05-21 18:07 mirurita Status resolved => closed
2012-05-21 18:07 mirurita Fixed in Version => 3.0MP12
2012-05-25 12:11 hudsonbot Checkin
2012-05-25 12:11 hudsonbot Note Added: 0049118
2012-05-25 12:11 hudsonbot Checkin
2012-05-25 12:11 hudsonbot Note Added: 0049119


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker