Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0020438Openbravo ERP09. Financial managementpublic2012-05-07 23:082012-05-25 12:11
mtaal 
mirurita 
normalmajorhave not tried
closedfixed 
5
 
3.0MP123.0MP12 
Core
No
0020438: Date filter in selector popup grid does not work because of invalid override in other js file
The date filter of the selector grid in the match transaction window does not work. The date field is always set back to the current date. The reason is that internally for formatting Openbravo uses the javascript Date object, the setFullYear method.
However this method is overridden/overwritten in the file calendar.js (web/js/jscalendar/calendar.js). The calendar.js does this in an incorrect way, the second and third parameter are ignored.
To reproduce:
Go to "Financial Account"
Select record "Bank - Account 2"

In form mode do this change: Matching Algorithm -> Standard

Now go to its child tab "Imported Bank Statement"
Create new one and fill
Name: "test"

Now go to its child tab "Bank Statement Lines"
Create new one and fill
Reference No: Line1
Amout IN: 10

Create new one and fill
Reference No: Line2
Amout IN: 20

Click button "Process"

Click button "Match Statement"

Click the magnifier glass icon.

The grid opens, enter a date in the first column, when you tab out the date is changed to the current date.
Do not use the calendar.js in this html page, removing it should resolve this issue.
No tags attached.
related to defect 0020412 closed mtaal "Match Statement" popup doesn't show the grid 
png Screenshot at 2012-05-07 23:08:10.png (40,902) 2012-05-07 23:08
https://issues.openbravo.com/file_download.php?file_id=5192&type=bug
png
Issue History
2012-05-07 23:08mtaalNew Issue
2012-05-07 23:08mtaalAssigned To => vmromanos
2012-05-07 23:08mtaalFile Added: Screenshot at 2012-05-07 23:08:10.png
2012-05-07 23:08mtaalModules => Core
2012-05-07 23:08mtaalRelationship addedrelated to 0020412
2012-05-07 23:08mtaalAssigned Tovmromanos => mirurita
2012-05-07 23:37dbazNote Added: 0048425
2012-05-09 17:39naiaramartinezNote Added: 0048519
2012-05-14 14:03hgbotCheckin
2012-05-14 14:03hgbotNote Added: 0048620
2012-05-14 14:03hgbotStatusnew => resolved
2012-05-14 14:03hgbotResolutionopen => fixed
2012-05-14 14:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2723f376b165731f69e708b49b0e7d568c7ad80e [^]
2012-05-14 14:03hgbotCheckin
2012-05-14 14:03hgbotNote Added: 0048621
2012-05-21 18:07miruritaNote Added: 0048826
2012-05-21 18:07miruritaStatusresolved => closed
2012-05-21 18:07miruritaFixed in Version => 3.0MP12
2012-05-25 12:11hudsonbotCheckin
2012-05-25 12:11hudsonbotNote Added: 0049118
2012-05-25 12:11hudsonbotCheckin
2012-05-25 12:11hudsonbotNote Added: 0049119

Notes
(0048425)
dbaz   
2012-05-07 23:37   
Note that it fails at least from MP11
(0048519)
naiaramartinez   
2012-05-09 17:39   
Test Plan:
  Go to "Financial Account"
  Select record "Bank - Account 2"

  In form mode do this change if it is not already done: Matching Algorithm -> Standard

  Now go to its child tab "Imported Bank Statement"
  Create new one and fill
  Name: "test"

  Now go to its child tab "Bank Statement Lines"
  Create new one and fill
  Reference No: Line1
  Amout IN: 10

  Create new one and fill
  Reference No: Line2
  Amout IN: 20

  Click button "Process"

  Click button "Match Statement"

  Click the magnifier glass icon.

  The grid opens, enter a date in the first column, notice that the date is not changing to current date.
(0048620)
hgbot   
2012-05-14 14:03   
Repository: erp/devel/pi
Changeset: 2723f376b165731f69e708b49b0e7d568c7ad80e
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Wed May 09 17:36:36 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2723f376b165731f69e708b49b0e7d568c7ad80e [^]

fixed bug 20438 Delete calendar.js from MatchTransaction.html

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.html
---
(0048621)
hgbot   
2012-05-14 14:03   
Repository: erp/devel/pi
Changeset: 6219c9731ca78f85d759dea0c6ae3f36d8cc1669
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Mon May 14 13:37:08 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6219c9731ca78f85d759dea0c6ae3f36d8cc1669 [^]

Related to issue 20438: remove calendar-es.js file import

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.html
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.xml
---
(0048826)
mirurita   
2012-05-21 18:07   
code review + testing OK
(0049118)
hudsonbot   
2012-05-25 12:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0049119)
hudsonbot   
2012-05-25 12:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test