Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0020424
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] B. User interfacecriticalalways2012-05-04 16:452012-05-25 12:10
ReporterdbazView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version3.0MP12
StatusclosedFix in branchpiFixed in SCM revision98ca8ddc5e0e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020424: Change role takes 10 secons since you press "Apply" button

DescriptionChange role takes 10 secons since you press "Apply" button.

This has raised in a push of the exact date: 3-May
Steps To ReproduceLogin
Change role to "System"
Press "Apply button"
TagsPerformance, Regression QA
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on defect 0020129 closedAugustoMauch OBContext class getters returning a reference to the class instance attributes (not a new instance of the attribute) 

-  Notes
(0048393)
alostale (manager)
2012-05-04 18:03

This issue seems to be caused by 0020129.

For example executing UserInfoWidgetActionHandler, which is called in session switch, takes now ~2s and before it took ~200ms.

Apparently the problem is OBContext making copies of BaseOBObjects, this copies are very slow to complete (they are querying to DB, not only for the object itself but also for its children). It must be considered whether it even makes sense to return a copy for these objects as this is managed by DAL.

Note this affects not only switch role but across all the application.
(0048405)
hgbot (developer)
2012-05-07 11:18

Repository: erp/devel/pi
Changeset: 98ca8ddc5e0ef280ba10c5a94bdf3fbd00295f0d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon May 07 11:17:14 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/98ca8ddc5e0ef280ba10c5a94bdf3fbd00295f0d [^]

Fixes issue 20424: DalUtil copies reverted

In the fix of issue 20129 some DalUtil copies were introduced. They are very time-consuming and have a strong impact in performance, so they have been reverted.

---
M src-test/org/openbravo/test/dal/IssuesTest.java
M src/org/openbravo/dal/core/OBContext.java
---
(0048675)
alostale (manager)
2012-05-16 09:03

Code reviewed and verified on pi@d4ef642f1e2a
(0049033)
hudsonbot (developer)
2012-05-25 12:10

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-05-04 16:45 dbaz New Issue
2012-05-04 16:45 dbaz Assigned To => alostale
2012-05-04 16:45 dbaz Modules => Core
2012-05-04 16:45 dbaz Tag Attached: Regression QA
2012-05-04 17:57 alostale Relationship added depends on 0020129
2012-05-04 18:03 alostale Note Added: 0048393
2012-05-04 18:04 alostale Tag Attached: Performance
2012-05-07 08:37 shuehner Issue Monitored: shuehner
2012-05-07 08:49 alostale Assigned To alostale => AugustoMauch
2012-05-07 11:18 hgbot Checkin
2012-05-07 11:18 hgbot Note Added: 0048405
2012-05-07 11:18 hgbot Status new => resolved
2012-05-07 11:18 hgbot Resolution open => fixed
2012-05-07 11:18 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/98ca8ddc5e0ef280ba10c5a94bdf3fbd00295f0d [^]
2012-05-16 09:03 alostale Note Added: 0048675
2012-05-16 09:03 alostale Status resolved => closed
2012-05-16 09:03 alostale Status closed => new
2012-05-16 09:03 alostale Resolution fixed => open
2012-05-16 09:03 alostale Status new => scheduled
2012-05-16 09:03 alostale fix_in_branch => pi
2012-05-16 09:03 alostale Status scheduled => resolved
2012-05-16 09:03 alostale Resolution open => fixed
2012-05-16 09:04 alostale Status resolved => closed
2012-05-16 09:04 alostale Fixed in Version => 3.0MP12
2012-05-25 12:10 hudsonbot Checkin
2012-05-25 12:10 hudsonbot Note Added: 0049033


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker