Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020424Openbravo ERPB. User interfacepublic2012-05-04 16:452012-05-25 12:10
Reporterdbaz 
Assigned ToAugustoMauch 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP12 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020424: Change role takes 10 secons since you press "Apply" button
DescriptionChange role takes 10 secons since you press "Apply" button.

This has raised in a push of the exact date: 3-May
Steps To ReproduceLogin
Change role to "System"
Press "Apply button"
Proposed Solution
Additional Information
TagsPerformance, Regression QA
Relationships
depends on defect 0020129 closed AugustoMauch OBContext class getters returning a reference to the class instance attributes (not a new instance of the attribute) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-05-04 16:45dbazNew Issue
2012-05-04 16:45dbazAssigned To => alostale
2012-05-04 16:45dbazModules => Core
2012-05-04 16:45dbazTag Attached: Regression QA
2012-05-04 17:57alostaleRelationship addeddepends on 0020129
2012-05-04 18:03alostaleNote Added: 0048393
2012-05-04 18:04alostaleTag Attached: Performance
2012-05-07 08:37shuehnerIssue Monitored: shuehner
2012-05-07 08:49alostaleAssigned Toalostale => AugustoMauch
2012-05-07 11:18hgbotCheckin
2012-05-07 11:18hgbotNote Added: 0048405
2012-05-07 11:18hgbotStatusnew => resolved
2012-05-07 11:18hgbotResolutionopen => fixed
2012-05-07 11:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/98ca8ddc5e0ef280ba10c5a94bdf3fbd00295f0d [^]
2012-05-16 09:03alostaleNote Added: 0048675
2012-05-16 09:03alostaleStatusresolved => closed
2012-05-16 09:03alostaleStatusclosed => new
2012-05-16 09:03alostaleResolutionfixed => open
2012-05-16 09:03alostaleStatusnew => scheduled
2012-05-16 09:03alostalefix_in_branch => pi
2012-05-16 09:03alostaleStatusscheduled => resolved
2012-05-16 09:03alostaleResolutionopen => fixed
2012-05-16 09:04alostaleStatusresolved => closed
2012-05-16 09:04alostaleFixed in Version => 3.0MP12
2012-05-25 12:10hudsonbotCheckin
2012-05-25 12:10hudsonbotNote Added: 0049033

Notes
(0048393)
alostale   
2012-05-04 18:03   
This issue seems to be caused by 0020129.

For example executing UserInfoWidgetActionHandler, which is called in session switch, takes now ~2s and before it took ~200ms.

Apparently the problem is OBContext making copies of BaseOBObjects, this copies are very slow to complete (they are querying to DB, not only for the object itself but also for its children). It must be considered whether it even makes sense to return a copy for these objects as this is managed by DAL.

Note this affects not only switch role but across all the application.
(0048405)
hgbot   
2012-05-07 11:18   
Repository: erp/devel/pi
Changeset: 98ca8ddc5e0ef280ba10c5a94bdf3fbd00295f0d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon May 07 11:17:14 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/98ca8ddc5e0ef280ba10c5a94bdf3fbd00295f0d [^]

Fixes issue 20424: DalUtil copies reverted

In the fix of issue 20129 some DalUtil copies were introduced. They are very time-consuming and have a strong impact in performance, so they have been reverted.

---
M src-test/org/openbravo/test/dal/IssuesTest.java
M src/org/openbravo/dal/core/OBContext.java
---
(0048675)
alostale   
2012-05-16 09:03   
Code reviewed and verified on pi@d4ef642f1e2a
(0049033)
hudsonbot   
2012-05-25 12:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test