0020311: Null pointer exception error when the user tries to send an email of one voided invoice

d8485916 2012-04-19 11:06:16,983 [http-8080-7] WARN org.openbravo.xmlEngine.XmlDocument - Data: structure2 not found in designorg/openbravo/erpCommon/utility/reporting/printing/EmailOptions?multipleCustomer?null?discardSelect d8485916 2012-04-19 11:06:17,081 [http-8080-7] ERROR org.openbravo.erpCommon.utility.reporting.printing.PrintInvoices - Error captured: java.lang.NullPointerException at org.openbravo.xmlEngine.XmlDocument.setData(XmlDocument.java:160) at org.openbravo.erpCommon.utility.reporting.printing.PrintController.createEmailOptionsPage(PrintController.java:1071) at org.openbravo.erpCommon.utility.reporting.printing.PrintController.post(PrintController.java:301) at org.openbravo.erpCommon.utility.reporting.printing.PrintInvoices.doPost(PrintInvoices.java:57) at org.openbravo.base.HttpBaseServlet.doGet(HttpBaseServlet.java:287) at javax.servlet.http.HttpServlet.service(HttpServlet.java:617) at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:225) at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:426) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62) at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46) at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81) at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46) at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:291) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:859) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:602) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489) at java.lang.Thread.run(Thread.java:662)

Notes
(0047769) alostale (manager) 2012-04-20 09:05	This issue is not a regression (verified in 3.0MP7.3). The actual problem is can happen in these two situations: 1. When trying to print at the same time more than one record having them different document types. In this situation in consistently raises NPE. 2. Printing a document and later printing another document with a different document type. This occurs randomly because different selected document types variable is not properly initialized/reused (see issue 0020319). This case is a variant of 1st one and it is the described case. Note this is the described situation, perceived as regression because of its random nature. Steps to reproduce/test plan: * Go go Sales Invoice window. In grid mode show Transaction Document column. * To reproduce case 1: -Select 2 completed records with different Transaction Document. -Click on email button -> NPE * To reproduce case 2 (and reported issue): -Create a new Sales Invoice with AR Invoice document type. -Add lines and complete -Email it. OK -Void this document. Note there is a new record with Reversed Sales Invoice document type -Print this new record -> Randomly NPE can happen The provided fix is not risky. It doesn't solve thread safety (to be solved by 0020319) but multi document type email.

(0047770) hgbot (developer) 2012-04-20 09:11	Repository: erp/devel/pi Changeset: 4cda1ec9b931cd2d443266973afde1c824401037 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Fri Apr 20 09:11:01 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/4cda1ec9b931cd2d443266973afde1c824401037 [^] fixed bug 20311: NPE when printing multiple documents Hidden tags in this case was inccorectly set. --- M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java ---

(0047850) hudsonbot (developer) 2012-04-21 14:24	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2eb57286c1fc [^] Maturity status: Test

(0048009) AugustoMauch (administrator) 2012-04-26 12:23	Code reviewed and verified in pi@52d3acc5d1d4

Issue History
Date Modified	Username	Field	Change
2012-04-19 11:32	VictorVillar	New Issue
2012-04-19 11:32	VictorVillar	Assigned To	=> vmromanos
2012-04-19 11:32	VictorVillar	File Added: erroremail.png
2012-04-19 11:32	VictorVillar	Modules	=> Core
2012-04-19 11:32	VictorVillar	Resolution time	=> 1337724000
2012-04-19 11:33	VictorVillar	File Added: emailerrorlog.txt
2012-04-19 11:33	VictorVillar	Issue Monitored: networkb
2012-04-19 13:34	jonalegriaesarte	Tag Attached: Regression
2012-04-19 13:35	jonalegriaesarte	Assigned To	vmromanos => alostale
2012-04-19 13:45	jonalegriaesarte	Priority	urgent => immediate
2012-04-19 15:17	alostale	Assigned To	alostale => guilleaer
2012-04-19 15:28	shuehner	Issue Monitored: shuehner
2012-04-20 08:53	alostale	Tag Detached: Regression
2012-04-20 09:05	alostale	Note Added: 0047769
2012-04-20 09:10	alostale	Assigned To	guilleaer => alostale
2012-04-20 09:11	hgbot	Checkin
2012-04-20 09:11	hgbot	Note Added: 0047770
2012-04-20 09:11	hgbot	Status	new => resolved
2012-04-20 09:11	hgbot	Resolution	open => fixed
2012-04-20 09:11	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/4cda1ec9b931cd2d443266973afde1c824401037 [^]
2012-04-21 14:24	hudsonbot	Checkin
2012-04-21 14:24	hudsonbot	Note Added: 0047850
2012-04-26 12:23	AugustoMauch	Note Added: 0048009
2012-04-26 12:23	AugustoMauch	Status	resolved => closed
2012-04-26 12:23	AugustoMauch	Fixed in Version	=> 3.0MP11

Relationships [ Relation Graph ] [ Dependency Graph ]