|
Notes |
|
|
|
This issue is not a regression (verified in 3.0MP7.3).
The actual problem is can happen in these two situations:
1. When trying to print at the same time more than one record having them different document types. In this situation in consistently raises NPE.
2. Printing a document and later printing another document with a different document type. This occurs randomly because different selected document types variable is not properly initialized/reused (see issue 0020319). This case is a variant of 1st one and it is the described case. Note this is the described situation, perceived as regression because of its random nature.
Steps to reproduce/test plan:
* Go go Sales Invoice window. In grid mode show Transaction Document column.
* To reproduce case 1:
-Select 2 completed records with different Transaction Document.
-Click on email button -> NPE
* To reproduce case 2 (and reported issue):
-Create a new Sales Invoice with AR Invoice document type.
-Add lines and complete
-Email it. OK
-Void this document. Note there is a new record with Reversed Sales Invoice document type
-Print this new record -> Randomly NPE can happen
The provided fix is not risky. It doesn't solve thread safety (to be solved by 0020319) but multi document type email. |
|
|
|
(0047770)
|
|
hgbot
|
|
2012-04-20 09:11
|
|
Repository: erp/devel/pi
Changeset: 4cda1ec9b931cd2d443266973afde1c824401037
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Apr 20 09:11:01 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4cda1ec9b931cd2d443266973afde1c824401037 [^]
fixed bug 20311: NPE when printing multiple documents
Hidden tags in this case was inccorectly set.
---
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---
|
|
|
|
|
|
|
|
|
|
Code reviewed and verified in pi@52d3acc5d1d4 |
|
erroremail.png (199,079) 2012-04-19 11:32
emailerrorlog.txt (3,819) 2012-04-19 11:33