Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0020216
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] A. Platformminoralways2012-04-06 20:542012-04-26 10:43
ReporterdbazView Statuspublic 
Assigned Todbaz 
PriorityhighResolutionfixedFixed in Version3.0MP11
StatusclosedFix in branchFixed in SCM revision9c2636367b2d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020216: "ISC_History.js" can be within "ISC_Combined.js"

DescriptionInside index.jsp there are two js calls

* ISC_Combined.js: Contains compressed Smartclient library components
* ISC_History.js: Standalone Smartclient "history" component

ISC_History.js could be also be inside "ISC_Combined.js"
Steps To ReproduceOpen src/index.jsp and notice the two js loads:

<script type="text/javascript" src="./web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js"></script>
<script type="text/javascript" src="./web/org.openbravo.userinterface.smartclient/isomorphic/ISC_History.js"></script>
Proposed SolutionAdd "ISC_History.js" content at the end of "ISC_Combined.js"
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0047398)
hgbot (developer)
2012-04-06 20:57

 Repository: erp/devel/pi
Changeset: 9c2636367b2dcd4b1f21342ac3663d68fb9a0a86
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Apr 06 20:56:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9c2636367b2dcd4b1f21342ac3663d68fb9a0a86 [^]

Fixed issue 20216: Added 'ISC_History.js' content inside 'ISC_Combined.js'

---
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js
M src/index.jsp
R modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_History.js
---
(0047401)
hgbot (developer)
2012-04-06 23:27

 Repository: erp/mods/org.openbravo.userinterface.smartclient.dev
Changeset: 67270e2b0cea8a4d025efb11911402e2896c87f8
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Apr 06 23:27:11 2012 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.smartclient.dev/rev/67270e2b0cea8a4d025efb11911402e2896c87f8 [^]

Backed out change related to issue 20216

---
M build.xml
M readme.txt
M upgrade.sh
M web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.uncompressed.js
A web/org.openbravo.userinterface.smartclient/isomorphic/ISC_History.uncompressed.js
---
(0047402)
hgbot (developer)
2012-04-06 23:29

 Repository: erp/devel/pi
Changeset: 6f6968bae182e24570dd638ecbdc66e073612d15
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Apr 06 23:29:11 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6f6968bae182e24570dd638ecbdc66e073612d15 [^]

Related to issue 20216: Backed out changeset

---
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js
M src/index.jsp
A modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_History.js
---
(0047403)
dbaz (viewer)
2012-04-06 23:34

 ISC_History.js creates a new <form> tab at the beggining of the html.

Merge it with ISC_Combined.js could cause problems in classic windows using new selectors, since there are a lot of "documents.forms[0]" references in "utils.js", so this is the part (the corresponding to ISC_History.js) should not be inside ISC_Combined.js.

NOTE: Of course, these classic windows using new selectors only load ISC_Combined.js and not ISC_History.js
(0047614)
hudsonbot (viewer)
2012-04-17 05:31

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cedf57621434 [^]

Maturity status: Test
(0047616)
hudsonbot (viewer)
2012-04-17 05:31

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cedf57621434 [^]

Maturity status: Test
(0047995)
alostale (viewer)
2012-04-26 10:43

 Code reviewed and verified on pi@9d54745371d5

- Issue History
Date Modified Username Field Change
2012-04-06 20:54 dbaz New Issue
2012-04-06 20:54 dbaz Assigned To => dbaz
2012-04-06 20:54 dbaz Modules => Core
2012-04-06 20:54 dbaz OBNetwork customer => No
2012-04-06 20:57 hgbot Checkin
2012-04-06 20:57 hgbot Note Added: 0047398
2012-04-06 20:57 hgbot Status new => resolved
2012-04-06 20:57 hgbot Resolution open => fixed
2012-04-06 20:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9c2636367b2dcd4b1f21342ac3663d68fb9a0a86 [^]
2012-04-06 23:27 hgbot Checkin
2012-04-06 23:27 hgbot Note Added: 0047401
2012-04-06 23:29 hgbot Checkin
2012-04-06 23:29 hgbot Note Added: 0047402
2012-04-06 23:34 dbaz Note Added: 0047403
2012-04-17 05:31 hudsonbot Checkin
2012-04-17 05:31 hudsonbot Note Added: 0047614
2012-04-17 05:31 hudsonbot Checkin
2012-04-17 05:31 hudsonbot Note Added: 0047616
2012-04-26 10:43 alostale Note Added: 0047995
2012-04-26 10:43 alostale Status resolved => closed
2012-04-26 10:43 alostale Fixed in Version => 3.0MP11

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker