Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020216Openbravo ERPA. Platformpublic2012-04-06 20:542012-04-26 10:43
Reporterdbaz 
Assigned Todbaz 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP11 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020216: "ISC_History.js" can be within "ISC_Combined.js"
DescriptionInside index.jsp there are two js calls

* ISC_Combined.js: Contains compressed Smartclient library components
* ISC_History.js: Standalone Smartclient "history" component

ISC_History.js could be also be inside "ISC_Combined.js"
Steps To ReproduceOpen src/index.jsp and notice the two js loads:

<script type="text/javascript" src="./web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js"></script>
<script type="text/javascript" src="./web/org.openbravo.userinterface.smartclient/isomorphic/ISC_History.js"></script>
Proposed SolutionAdd "ISC_History.js" content at the end of "ISC_Combined.js"
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-04-06 20:54dbazNew Issue
2012-04-06 20:54dbazAssigned To => dbaz
2012-04-06 20:54dbazModules => Core
2012-04-06 20:57hgbotCheckin
2012-04-06 20:57hgbotNote Added: 0047398
2012-04-06 20:57hgbotStatusnew => resolved
2012-04-06 20:57hgbotResolutionopen => fixed
2012-04-06 20:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9c2636367b2dcd4b1f21342ac3663d68fb9a0a86 [^]
2012-04-06 23:27hgbotCheckin
2012-04-06 23:27hgbotNote Added: 0047401
2012-04-06 23:29hgbotCheckin
2012-04-06 23:29hgbotNote Added: 0047402
2012-04-06 23:34dbazNote Added: 0047403
2012-04-17 05:31hudsonbotCheckin
2012-04-17 05:31hudsonbotNote Added: 0047614
2012-04-17 05:31hudsonbotCheckin
2012-04-17 05:31hudsonbotNote Added: 0047616
2012-04-26 10:43alostaleNote Added: 0047995
2012-04-26 10:43alostaleStatusresolved => closed
2012-04-26 10:43alostaleFixed in Version => 3.0MP11

Notes
(0047398)
hgbot   
2012-04-06 20:57   
Repository: erp/devel/pi
Changeset: 9c2636367b2dcd4b1f21342ac3663d68fb9a0a86
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Apr 06 20:56:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9c2636367b2dcd4b1f21342ac3663d68fb9a0a86 [^]

Fixed issue 20216: Added 'ISC_History.js' content inside 'ISC_Combined.js'

---
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js
M src/index.jsp
R modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_History.js
---
(0047401)
hgbot   
2012-04-06 23:27   
Repository: erp/mods/org.openbravo.userinterface.smartclient.dev
Changeset: 67270e2b0cea8a4d025efb11911402e2896c87f8
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Apr 06 23:27:11 2012 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.smartclient.dev/rev/67270e2b0cea8a4d025efb11911402e2896c87f8 [^]

Backed out change related to issue 20216

---
M build.xml
M readme.txt
M upgrade.sh
M web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.uncompressed.js
A web/org.openbravo.userinterface.smartclient/isomorphic/ISC_History.uncompressed.js
---
(0047402)
hgbot   
2012-04-06 23:29   
Repository: erp/devel/pi
Changeset: 6f6968bae182e24570dd638ecbdc66e073612d15
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Apr 06 23:29:11 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6f6968bae182e24570dd638ecbdc66e073612d15 [^]

Related to issue 20216: Backed out changeset

---
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js
M src/index.jsp
A modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_History.js
---
(0047403)
dbaz   
2012-04-06 23:34   
ISC_History.js creates a new <form> tab at the beggining of the html.

Merge it with ISC_Combined.js could cause problems in classic windows using new selectors, since there are a lot of "documents.forms[0]" references in "utils.js", so this is the part (the corresponding to ISC_History.js) should not be inside ISC_Combined.js.

NOTE: Of course, these classic windows using new selectors only load ISC_Combined.js and not ISC_History.js
(0047614)
hudsonbot   
2012-04-17 05:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cedf57621434 [^]

Maturity status: Test
(0047616)
hudsonbot   
2012-04-17 05:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cedf57621434 [^]

Maturity status: Test
(0047995)
alostale   
2012-04-26 10:43   
Code reviewed and verified on pi@9d54745371d5