Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0020152 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 09. Financial management | major | always | 2012-03-29 14:22 | 2012-04-02 06:13 | |||
| Reporter | dalsasua | View Status | public | |||||
| Assigned To | dalsasua | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | 3.0MP10 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 8bac1304f99c | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 32 bit | Database | Oracle | Java version | 1.6.0_21 | |||
| OS Version | Ubuntu 10.10 | Database version | 11.2.0 SE | Ant version | 1.8.0 | |||
| Product Version | 3.0MP8.1 | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Advanced Payables and Receivables Mngmt | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0020152: If payment process fails, there is no rollback executed | |||||||
| Description | If payment process fails, there is no rollback executed | |||||||
| Steps To Reproduce | Create a new Financial Account for 'F&B US, Inc.' organization Set as payment method for the new financial account "Cash" Create a new payment in for 'F&B US, Inc.' organization, and the new financial account. Save Change, through database, financial account organization to 'F&B Spain'. Go to the payment, press Add Details Select a payment Process It fails, the detail is created, and the payment not processed. | |||||||
| Proposed Solution | diff --git a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java @@ -99,6 +99,7 @@ msg.setMessage(Utility.parseTranslation(conProvider, vars, language, "@APRM_FinancialAccountNotInNaturalTree@")); bundle.setResult(msg); + OBDal.getInstance().rollbackAndClose(); return; } Set<String> invoiceDocNos = new TreeSet<String>(); @@ -122,6 +123,7 @@ msg.setMessage(Utility.parseTranslation(conProvider, vars, language, "@APRM_PaymentNoLines@")); bundle.setResult(msg); + OBDal.getInstance().rollbackAndClose(); return; } for (FIN_PaymentDetail paymentDetail : paymentDetails) { @@ -260,6 +262,7 @@ msg.setMessage(Utility.parseTranslation(conProvider, vars, language, "@NoExecutionProcessFound@")); bundle.setResult(msg); + OBDal.getInstance().rollbackAndClose(); return; } catch (final Exception e) { e.printStackTrace(System.err); @@ -267,6 +270,7 @@ msg.setMessage(Utility.parseTranslation(conProvider, vars, language, "@IssueOnExecutionProcess@")); bundle.setResult(msg); + OBDal.getInstance().rollbackAndClose(); return; } } else { @@ -350,6 +354,7 @@ msg.setMessage(Utility.parseTranslation(conProvider, vars, language, "@PostedDocument@" + ": " + payment.getDocumentNo())); bundle.setResult(msg); + OBDal.getInstance().rollbackAndClose(); return; } // Transaction exists @@ -359,6 +364,7 @@ msg.setMessage(Utility.parseTranslation(conProvider, vars, language, "@APRM_TransactionExists@")); bundle.setResult(msg); + OBDal.getInstance().rollbackAndClose(); return; } // Payment with generated credit already used on other payments. @@ -369,6 +375,7 @@ msg.setMessage(Utility.parseTranslation(conProvider, vars, language, "@APRM_PaymentGeneratedCreditIsUsed@")); bundle.setResult(msg); + OBDal.getInstance().rollbackAndClose(); return; } @@ -556,6 +563,7 @@ msg.setMessage(Utility.parseTranslation(conProvider, vars, language, "@PostedDocument@" + ": " + payment.getDocumentNo())); bundle.setResult(msg); + OBDal.getInstance().rollbackAndClose(); return; } // Transaction exists @@ -565,6 +573,7 @@ msg.setMessage(Utility.parseTranslation(conProvider, vars, language, "@APRM_TransactionExists@")); bundle.setResult(msg); + OBDal.getInstance().rollbackAndClose(); return; } // Payment with generated credit already used on other payments. @@ -575,6 +584,7 @@ msg.setMessage(Utility.parseTranslation(conProvider, vars, language, "@APRM_PaymentGeneratedCreditIsUsed@")); bundle.setResult(msg); + OBDal.getInstance().rollbackAndClose(); return; } // Payment not in Awaiting Execution @@ -584,6 +594,7 @@ msg.setMessage(Utility.parseTranslation(conProvider, vars, language, "@APRM_PaymentNotRPAE_NotVoid@")); bundle.setResult(msg); + OBDal.getInstance().rollbackAndClose(); return; } @@ -689,6 +700,7 @@ msg.setMessage(Utility.parseTranslation(conProvider, vars, language, "@CouldNotUpdateOriginalPaymentPlan@")); bundle.setResult(msg); + OBDal.getInstance().rollbackAndClose(); return; } | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0046886) hgbot (developer) 2012-03-29 14:25 |
Repository: erp/devel/pi Changeset: 8bac1304f99c72a01bea205485b6490ed7cdf23d Author: David Alsasua <david.alsasua <at> openbravo.com> Date: Thu Mar 29 14:24:33 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/8bac1304f99c72a01bea205485b6490ed7cdf23d [^] Fixes issue 20152. --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java --- |
|
(0046907) vmromanos (manager) 2012-03-29 16:57 |
code review + testing OK. In case of any error, a rollback is done and the proper error message is displayed |
|
(0047268) hudsonbot (developer) 2012-04-02 06:13 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-03-29 14:22 | dalsasua | New Issue | |
| 2012-03-29 14:22 | dalsasua | Assigned To | => vmromanos |
| 2012-03-29 14:22 | dalsasua | Modules | => Advanced Payables and Receivables Mngmt |
| 2012-03-29 14:25 | hgbot | Checkin | |
| 2012-03-29 14:25 | hgbot | Note Added: 0046886 | |
| 2012-03-29 14:25 | hgbot | Status | new => resolved |
| 2012-03-29 14:25 | hgbot | Resolution | open => fixed |
| 2012-03-29 14:25 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/8bac1304f99c72a01bea205485b6490ed7cdf23d [^] |
| 2012-03-29 14:31 | dalsasua | Steps to Reproduce Updated | View Revisions |
| 2012-03-29 14:32 | dalsasua | Assigned To | vmromanos => dalsasua |
| 2012-03-29 15:33 | dalsasua | Issue Monitored: gregor1com | |
| 2012-03-29 16:57 | vmromanos | Note Added: 0046907 | |
| 2012-03-29 16:57 | vmromanos | Status | resolved => closed |
| 2012-03-29 16:57 | vmromanos | Fixed in Version | => 3.0MP10 |
| 2012-04-02 06:13 | hudsonbot | Checkin | |
| 2012-04-02 06:13 | hudsonbot | Note Added: 0047268 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |