Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020152Openbravo ERP09. Financial managementpublic2012-03-29 14:222012-04-02 06:13
Reporterdalsasua 
Assigned Todalsasua 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 10.10
Product Version3.0MP8.1 
Target VersionFixed in Version3.0MP10 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020152: If payment process fails, there is no rollback executed
DescriptionIf payment process fails, there is no rollback executed
Steps To ReproduceCreate a new Financial Account for 'F&B US, Inc.' organization
Set as payment method for the new financial account "Cash"
Create a new payment in for 'F&B US, Inc.' organization, and the new financial account.
Save
Change, through database, financial account organization to 'F&B Spain'.
Go to the payment, press Add Details
Select a payment
Process
It fails, the detail is created, and the payment not processed.
Proposed Solutiondiff --git a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
--- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
+++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
@@ -99,6 +99,7 @@
           msg.setMessage(Utility.parseTranslation(conProvider, vars, language,
               "@APRM_FinancialAccountNotInNaturalTree@"));
           bundle.setResult(msg);
+ OBDal.getInstance().rollbackAndClose();
           return;
         }
         Set<String> invoiceDocNos = new TreeSet<String>();
@@ -122,6 +123,7 @@
             msg.setMessage(Utility.parseTranslation(conProvider, vars, language,
                 "@APRM_PaymentNoLines@"));
             bundle.setResult(msg);
+ OBDal.getInstance().rollbackAndClose();
             return;
           }
           for (FIN_PaymentDetail paymentDetail : paymentDetails) {
@@ -260,6 +262,7 @@
               msg.setMessage(Utility.parseTranslation(conProvider, vars, language,
                   "@NoExecutionProcessFound@"));
               bundle.setResult(msg);
+ OBDal.getInstance().rollbackAndClose();
               return;
             } catch (final Exception e) {
               e.printStackTrace(System.err);
@@ -267,6 +270,7 @@
               msg.setMessage(Utility.parseTranslation(conProvider, vars, language,
                   "@IssueOnExecutionProcess@"));
               bundle.setResult(msg);
+ OBDal.getInstance().rollbackAndClose();
               return;
             }
           } else {
@@ -350,6 +354,7 @@
           msg.setMessage(Utility.parseTranslation(conProvider, vars, language, "@PostedDocument@"
               + ": " + payment.getDocumentNo()));
           bundle.setResult(msg);
+ OBDal.getInstance().rollbackAndClose();
           return;
         }
         // Transaction exists
@@ -359,6 +364,7 @@
           msg.setMessage(Utility.parseTranslation(conProvider, vars, language,
               "@APRM_TransactionExists@"));
           bundle.setResult(msg);
+ OBDal.getInstance().rollbackAndClose();
           return;
         }
         // Payment with generated credit already used on other payments.
@@ -369,6 +375,7 @@
           msg.setMessage(Utility.parseTranslation(conProvider, vars, language,
               "@APRM_PaymentGeneratedCreditIsUsed@"));
           bundle.setResult(msg);
+ OBDal.getInstance().rollbackAndClose();
           return;
         }
 
@@ -556,6 +563,7 @@
               msg.setMessage(Utility.parseTranslation(conProvider, vars, language,
                   "@PostedDocument@" + ": " + payment.getDocumentNo()));
               bundle.setResult(msg);
+ OBDal.getInstance().rollbackAndClose();
               return;
             }
             // Transaction exists
@@ -565,6 +573,7 @@
               msg.setMessage(Utility.parseTranslation(conProvider, vars, language,
                   "@APRM_TransactionExists@"));
               bundle.setResult(msg);
+ OBDal.getInstance().rollbackAndClose();
               return;
             }
             // Payment with generated credit already used on other payments.
@@ -575,6 +584,7 @@
               msg.setMessage(Utility.parseTranslation(conProvider, vars, language,
                   "@APRM_PaymentGeneratedCreditIsUsed@"));
               bundle.setResult(msg);
+ OBDal.getInstance().rollbackAndClose();
               return;
             }
             // Payment not in Awaiting Execution
@@ -584,6 +594,7 @@
               msg.setMessage(Utility.parseTranslation(conProvider, vars, language,
                   "@APRM_PaymentNotRPAE_NotVoid@"));
               bundle.setResult(msg);
+ OBDal.getInstance().rollbackAndClose();
               return;
             }
 
@@ -689,6 +700,7 @@
         msg.setMessage(Utility.parseTranslation(conProvider, vars, language,
             "@CouldNotUpdateOriginalPaymentPlan@"));
         bundle.setResult(msg);
+ OBDal.getInstance().rollbackAndClose();
         return;
       }
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-03-29 14:22dalsasuaNew Issue
2012-03-29 14:22dalsasuaAssigned To => vmromanos
2012-03-29 14:22dalsasuaModules => Advanced Payables and Receivables Mngmt
2012-03-29 14:22dalsasuaOBNetwork customer => No
2012-03-29 14:25hgbotCheckin
2012-03-29 14:25hgbotNote Added: 0046886
2012-03-29 14:25hgbotStatusnew => resolved
2012-03-29 14:25hgbotResolutionopen => fixed
2012-03-29 14:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8bac1304f99c72a01bea205485b6490ed7cdf23d [^]
2012-03-29 14:31dalsasuaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=3318#r3318
2012-03-29 14:32dalsasuaAssigned Tovmromanos => dalsasua
2012-03-29 15:33dalsasuaIssue Monitored: gregor1com
2012-03-29 16:57vmromanosNote Added: 0046907
2012-03-29 16:57vmromanosStatusresolved => closed
2012-03-29 16:57vmromanosFixed in Version => 3.0MP10
2012-04-02 06:13hudsonbotCheckin
2012-04-02 06:13hudsonbotNote Added: 0047268

Notes
(0046886)
hgbot   
2012-03-29 14:25   
Repository: erp/devel/pi
Changeset: 8bac1304f99c72a01bea205485b6490ed7cdf23d
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Thu Mar 29 14:24:33 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8bac1304f99c72a01bea205485b6490ed7cdf23d [^]

Fixes issue 20152.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
---
(0046907)
vmromanos   
2012-03-29 16:57   
code review + testing OK.

In case of any error, a rollback is done and the proper error message is displayed
(0047268)
hudsonbot   
2012-04-02 06:13   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test