Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0020146
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2012-03-29 10:552012-04-13 09:30
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Version3.0MP10
StatusclosedFix in branchFixed in SCM revisiona844ff835130
ProjectionnoneETAnoneTarget Version3.0MP10
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020146: AlertActionHandler PreparedStatement is not closed

DescriptionPrepared statements used to query the number of active alerts are never closed.

This affects application performance, specially in oracle, because cursors are not closed and memory usage is constantly increasing making the application to degrade over time.

This issue was introduced by fix for 0019985
Steps To ReproduceUsing an Oracle env:
 -To faster simulate this degradation, change in ob-alert-manager.js delay from 50000 ms to 500 ms
 -Log in the application and add Admin user as recipient of all alert rules
 -Open 6 concurrent sessions with Admin user
 -Check:
   *The number of open cursors rapidly increases (perform this query with DBA rights) :
      SELECT SID, sql_text, COUNT(*)
      FROM v$open_cursor
      GROUP BY SID, sql_text
      ORDER BY COUNT(*) DESC
   *After some time (~10min) java heap memory consumption is high and it is not collected by garbage collector (see attached screensot showing big consumption of org.hibernate.connection.DriverManagerConnectionProvider because of this fact)

  
TagsPerformance, Regression QA
Attached Filespng file icon Selection_046.png [^] (28,191 bytes) 2012-03-29 10:57

- Relationships Relation Graph ] Dependency Graph ]
related to defect 00199853.0MP10 closedalostale AlertActionHandler response is unnecessary big 
related to defect 00202613.0MP11 closedalostale SessionInfo PreparedStatement is not closed 

-  Notes
(0046865)
alostale (manager)
2012-03-29 11:12

This fix is not risky.

Test plan: execute steps to reproduce and verify it is working fine now.
(0046867)
hgbot (developer)
2012-03-29 11:19

Repository: erp/devel/pi
Changeset: a844ff835130b17bf2df8624b76b634d7b261c8c
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Mar 29 11:19:23 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a844ff835130b17bf2df8624b76b634d7b261c8c [^]

fixed bug 20146: AlertActionHandler PreparedStatement is not closed

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/AlertActionHandler.java
---
(0047264)
hudsonbot (developer)
2012-04-02 06:12

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-03-29 10:55 alostale New Issue
2012-03-29 10:55 alostale Assigned To => alostale
2012-03-29 10:55 alostale Modules => Core
2012-03-29 10:57 alostale File Added: Selection_046.png
2012-03-29 10:57 alostale Tag Attached: Regression QA
2012-03-29 10:58 alostale Relationship added related to 0019985
2012-03-29 11:12 alostale Note Added: 0046865
2012-03-29 11:19 alostale Summary AlertActionHandler preparedStatement is not closed => AlertActionHandler PreparedStatement is not closed
2012-03-29 11:19 hgbot Checkin
2012-03-29 11:19 hgbot Note Added: 0046867
2012-03-29 11:19 hgbot Status new => resolved
2012-03-29 11:19 hgbot Resolution open => fixed
2012-03-29 11:19 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a844ff835130b17bf2df8624b76b634d7b261c8c [^]
2012-03-30 15:27 marvintm Status resolved => closed
2012-03-30 15:27 marvintm Fixed in Version => 3.0MP10
2012-04-02 06:12 hudsonbot Checkin
2012-04-02 06:12 hudsonbot Note Added: 0047264
2012-04-13 09:29 alostale Relationship added blocks 0020261
2012-04-13 09:29 alostale Relationship replaced related to 0020261
2012-04-13 09:30 alostale Tag Attached: Performance


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker