0020146: AlertActionHandler PreparedStatement is not closed

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0020146

Openbravo ERP

A. Platform

public

2012-03-29 10:55

2012-04-13 09:30

Reporter

alostale

Assigned To

alostale

Priority

immediate

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

3.0MP10

Fixed in Version

3.0MP10

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0020146: AlertActionHandler PreparedStatement is not closed

Description

Prepared statements used to query the number of active alerts are never closed.

This affects application performance, specially in oracle, because cursors are not closed and memory usage is constantly increasing making the application to degrade over time.

This issue was introduced by fix for 0019985

Steps To Reproduce

Using an Oracle env:
-To faster simulate this degradation, change in ob-alert-manager.js delay from 50000 ms to 500 ms
-Log in the application and add Admin user as recipient of all alert rules
-Open 6 concurrent sessions with Admin user
-Check:
   *The number of open cursors rapidly increases (perform this query with DBA rights) :
      SELECT SID, sql_text, COUNT(*)
      FROM v$open_cursor
      GROUP BY SID, sql_text
      ORDER BY COUNT(*) DESC
   *After some time (~10min) java heap memory consumption is high and it is not collected by garbage collector (see attached screensot showing big consumption of org.hibernate.connection.DriverManagerConnectionProvider because of this fact)

Proposed Solution

Additional Information

Tags

Performance, Regression QA

Relationships

related to	defect	0019985	3.0MP10	closed	alostale	AlertActionHandler response is unnecessary big
related to	defect	0020261	3.0MP11	closed	alostale	SessionInfo PreparedStatement is not closed