Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0020023 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2012-03-14 16:01 | 2012-04-02 06:12 | |||
| Reporter | plujan | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0MP10 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 1c2fe2c0d87c | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | main | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | Internet Explorer | |||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0020023: Autosave is throwing a wrong error message | |||||||
| Description | When creating a new Business Partner, if using autosave to make changes on children tabs an error is shown when should not. | |||||||
| Steps To Reproduce | 1. Login as QAAdmin 2. Go to Business Partner window 3. Create a new Business Partner. Search key: vids, name Vendor Discount, category Vendor. 4. Do not save, and click the "Vendor/Creditor" tab. Do nothing on that tab. (see screenshot 1) 5. Click the Customer tab 6. Unmark the check "Customer" and click again the "Vendor/Creditor" tab (see screenshot 2) 7. Mark the check "Vendor" and click the tab "Location/Address" 8. An error message is displayed when it should not (see screenshot 3) | |||||||
| Tags | RiskyReleaseTestingCycle | |||||||
| Attached Files |  Autosave_error_1.png [^] (63,816 bytes) 2012-03-14 16:01
Autosave_error_2.png [^] (63,273 bytes) 2012-03-14 16:01
Autosave_error_3.png [^] (62,336 bytes) 2012-03-14 16:01
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0046419) alostale (manager) 2012-03-14 16:38 |
This is happening in BP window because there are many tabs for the same entity. |
|
(0046509) hgbot (developer) 2012-03-16 11:31 |
Repository: erp/devel/pi Changeset: 34e835ecddebdefba7e83437305ee02461d15679 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Fri Mar 16 11:20:42 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/34e835ecddebdefba7e83437305ee02461d15679 [^] Fixes issue 20023: Autosave is throwing a wrong error message. The error message was shown because a tab that belonged to the same entity had been previously saved, and in that case all tabs belonging to that entity must be refreshed. This was already being done to the child tabs of the tab being saved, but not to the same-level tabs. Now, when a tab is saved, all the views of the window check if they have to be refreshed. They will be refreshed if: - They belong to the same entity of the tab just saved and - They are not in the list of excluded tab. This list prevents the refreshing of tabs that do not need to be refreshed (the tab being saved and its parent tab, if any) --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js --- |
|
(0046510) AugustoMauch (manager) 2012-03-16 11:34 |
If the steps described in the Steps To Reproduce section are followed, the error message should not appear, and the register should be successfully saved. |
|
(0046511) AugustoMauch (manager) 2012-03-16 11:34 |
This change is not risky. |
|
(0046698) alostale (manager) 2012-03-23 15:11 |
I'm still able to reproduce it: -Select a BP -Go to Vendor and modify -Go to Customer: vendor is properly saved -Modify Customer and go to vendor -> Fail, customer is not saved and message is not shown as it should. |
|
(0046705) alostale (manager) 2012-03-26 10:00 |
Not working in case there are no subtabs in Customer/Vendor, can be reproduced not showing accounting tabs. |
|
(0046711) hgbot (developer) 2012-03-26 10:48 |
Repository: erp/devel/pi Changeset: 1c2fe2c0d87cb2f7d0b02a1d3926eb6d8e32ca09 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Mon Mar 26 10:34:23 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/1c2fe2c0d87cb2f7d0b02a1d3926eb6d8e32ca09 [^] Fixes issue 20023: Autosave now works in tabs childless tabs There was an error in the previous fix that prevented the autosave from working in tabs that had no child tabs. This error (a check that the childTabSet of the view was not null) has been fixed. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js --- |
|
(0046737) hgbot (developer) 2012-03-26 17:01 |
Repository: erp/devel/pi Changeset: e80e1596cfbc3ec4d425adccd3c55e8f4b0395a9 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Mon Mar 26 17:00:07 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/e80e1596cfbc3ec4d425adccd3c55e8f4b0395a9 [^] Related to issue 20023: Prevents error when saving a view The previous fix removed from the function refreshMeAndMyChildViewsWithEntity the checking of this.childTabSet. This checking should not have been removed, just relocated. Now the check is placed where it should be, before the tab calls executes the function on its child views. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js --- |
|
(0046812) alostale (manager) 2012-03-28 11:58 |
Code reviewed and tested on pi@0fc0c86395e6 |
|
(0047156) hudsonbot (developer) 2012-04-02 06:10 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^] Maturity status: Test |
|
(0047222) hudsonbot (developer) 2012-04-02 06:12 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^] Maturity status: Test |
|
(0047235) hudsonbot (developer) 2012-04-02 06:12 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-03-14 16:01 | plujan | New Issue | |
| 2012-03-14 16:01 | plujan | Assigned To | => alostale |
| 2012-03-14 16:01 | plujan | File Added: Autosave_error_1.png | |
| 2012-03-14 16:01 | plujan | Web browser | => Internet Explorer |
| 2012-03-14 16:01 | plujan | Modules | => Core |
| 2012-03-14 16:01 | plujan | File Added: Autosave_error_2.png | |
| 2012-03-14 16:01 | plujan | File Added: Autosave_error_3.png | |
| 2012-03-14 16:01 | plujan | Tag Attached: RiskyReleaseTestingCycle | |
| 2012-03-14 16:37 | alostale | Relationship added | related to 0019740 |
| 2012-03-14 16:38 | alostale | Note Added: 0046419 | |
| 2012-03-14 16:38 | alostale | Assigned To | alostale => AugustoMauch |
| 2012-03-14 17:33 | plujan | Web browser | Internet Explorer => Internet Explorer |
| 2012-03-14 17:33 | plujan | version | => main |
| 2012-03-16 11:31 | hgbot | Checkin | |
| 2012-03-16 11:31 | hgbot | Note Added: 0046509 | |
| 2012-03-16 11:31 | hgbot | Status | new => resolved |
| 2012-03-16 11:31 | hgbot | Resolution | open => fixed |
| 2012-03-16 11:31 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/34e835ecddebdefba7e83437305ee02461d15679 [^] |
| 2012-03-16 11:34 | AugustoMauch | Note Added: 0046510 | |
| 2012-03-16 11:34 | AugustoMauch | Note Added: 0046511 | |
| 2012-03-23 15:11 | alostale | Note Added: 0046698 | |
| 2012-03-23 15:11 | alostale | Status | resolved => new |
| 2012-03-23 15:11 | alostale | Resolution | fixed => open |
| 2012-03-26 10:00 | alostale | Note Added: 0046705 | |
| 2012-03-26 10:48 | hgbot | Checkin | |
| 2012-03-26 10:48 | hgbot | Note Added: 0046711 | |
| 2012-03-26 10:48 | hgbot | Status | new => resolved |
| 2012-03-26 10:48 | hgbot | Resolution | open => fixed |
| 2012-03-26 10:48 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/34e835ecddebdefba7e83437305ee02461d15679 [^] => http://code.openbravo.com/erp/devel/pi/rev/1c2fe2c0d87cb2f7d0b02a1d3926eb6d8e32ca09 [^] |
| 2012-03-26 17:01 | hgbot | Checkin | |
| 2012-03-26 17:01 | hgbot | Note Added: 0046737 | |
| 2012-03-28 11:58 | alostale | Note Added: 0046812 | |
| 2012-03-28 11:58 | alostale | Status | resolved => closed |
| 2012-03-28 11:58 | alostale | Fixed in Version | => 3.0MP10 |
| 2012-04-02 06:10 | hudsonbot | Checkin | |
| 2012-04-02 06:10 | hudsonbot | Note Added: 0047156 | |
| 2012-04-02 06:12 | hudsonbot | Checkin | |
| 2012-04-02 06:12 | hudsonbot | Note Added: 0047222 | |
| 2012-04-02 06:12 | hudsonbot | Checkin | |
| 2012-04-02 06:12 | hudsonbot | Note Added: 0047235 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |