|
Notes |
|
|
|
|
This is happening in BP window because there are many tabs for the same entity. |
|
|
|
(0046509)
|
|
hgbot
|
|
2012-03-16 11:31
|
|
Repository: erp/devel/pi
Changeset: 34e835ecddebdefba7e83437305ee02461d15679
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Mar 16 11:20:42 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/34e835ecddebdefba7e83437305ee02461d15679 [^]
Fixes issue 20023: Autosave is throwing a wrong error message.
The error message was shown because a tab that belonged to the same entity had been previously saved, and in that case all tabs belonging to that entity must be refreshed.
This was already being done to the child tabs of the tab being saved, but not to the same-level tabs.
Now, when a tab is saved, all the views of the window check if they have to be refreshed. They will be refreshed if:
- They belong to the same entity of the tab just saved and
- They are not in the list of excluded tab. This list prevents the refreshing of tabs that do not need to be refreshed (the tab being saved and its parent tab, if any)
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
---
|
|
|
|
|
|
If the steps described in the Steps To Reproduce section are followed, the error message should not appear, and the register should be successfully saved. |
|
|
|
|
|
This change is not risky. |
|
|
|
|
I'm still able to reproduce it:
-Select a BP
-Go to Vendor and modify
-Go to Customer: vendor is properly saved
-Modify Customer and go to vendor -> Fail, customer is not saved and message is not shown as it should. |
|
|
|
|
|
Not working in case there are no subtabs in Customer/Vendor, can be reproduced not showing accounting tabs. |
|
|
|
(0046711)
|
|
hgbot
|
|
2012-03-26 10:48
|
|
Repository: erp/devel/pi
Changeset: 1c2fe2c0d87cb2f7d0b02a1d3926eb6d8e32ca09
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Mar 26 10:34:23 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1c2fe2c0d87cb2f7d0b02a1d3926eb6d8e32ca09 [^]
Fixes issue 20023: Autosave now works in tabs childless tabs
There was an error in the previous fix that prevented the autosave from working in tabs that had no child tabs. This error (a check that the childTabSet of the view was not null) has been fixed.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
|
|
|
|
(0046737)
|
|
hgbot
|
|
2012-03-26 17:01
|
|
Repository: erp/devel/pi
Changeset: e80e1596cfbc3ec4d425adccd3c55e8f4b0395a9
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Mar 26 17:00:07 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e80e1596cfbc3ec4d425adccd3c55e8f4b0395a9 [^]
Related to issue 20023: Prevents error when saving a view
The previous fix removed from the function refreshMeAndMyChildViewsWithEntity the checking of this.childTabSet. This checking should not have been removed, just relocated. Now the check is placed where it should be, before the tab calls executes the function on its child views.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
|
|
|
|
|
|
Code reviewed and tested on pi@0fc0c86395e6 |
|
|
|
|
|
|
|
|
|
|
|
|
|
Autosave_error_1.png (63,816) 2012-03-14 16:01