Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0019833 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 07. Sales management | major | always | 2012-02-22 04:11 | 2012-04-02 06:11 | |||
| Reporter | gregor1com | View Status | public | |||||
| Assigned To | eduardo_Argal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0MP10 | |||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | d48f465c19a7 | |||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0019833: Flagship: Posting error: no cost is not descriptive enough to resolve issue | |||||||
| Description | In the goods issue form, transactions fail posting because of a zero cost line. This can be seen in an alert and in the window itself. However, a company may have hundreds of lines on for given shipment it could be any one or more that are failing for this reason. The user needs to bring up the shipment, navigate to the lines, link on to the product for the first line, select the cost tab, and manually inspect the costs to ensure that the line has a cost that is valid for the transaction date. Then, when they discover that it is okay, they need to do it for the next line, and so on. this is too much of a burden on usability. | |||||||
| Steps To Reproduce | See above. In the live builds environment you can reproduce this by shipping goods on a multi-line order. Take any product and make sure that there is no valid cost for the transaction date. Also, make sure that you include many shipment lines of various products to see the burden that this involves. Follow the instructions given in the description above. Try to post. The post fails due to no cost. Then, attempt to resolve as a user who does not know where the problem is. You will see that not enough information is given. | |||||||
| Proposed Solution | Choice #1: when posting, a message will be provided at the moment of failure that indicates which line(s) do not have cost. The message should be descriptive enough to indicate the product name(s) and could ideally allow for direct link to places where the problem arose. CHoice #2: the alert will be raised with the same information. This is necessary anyway, in the case of #1. However, it is possible to do this only through the alert even though less desirable. Moment of error is the most important. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0046386) eduardo_Argal (developer) 2012-03-14 12:50 |
Test plan: 1 Create a shipment selecting a product in lines for which date and product there is no cost defined in the system. 2 Realize when trying to post that system now pops up a message indicating which product and for which date there is no cost defined 3 fix cost by defining one for that product and date range and post again. Now transaction should be posted correctly to the ledger Repeat previous steps with material movements and production documents |
|
(0046612) hgbot (developer) 2012-03-21 17:58 |
Repository: erp/devel/pi Changeset: d48f465c19a78ef486ca963964447783075cb1c0 Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com> Date: Wed Mar 14 13:33:19 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/d48f465c19a78ef486ca963964447783075cb1c0 [^] Fixes bug 19833: Flagship: Posting error: no cost is not descriptive enough to resolve issue --- M src-db/database/sourcedata/AD_MESSAGE.xml M src/org/openbravo/erpCommon/ad_forms/AcctServer.java M src/org/openbravo/erpCommon/ad_forms/DocInOut.java M src/org/openbravo/erpCommon/ad_forms/DocInventory.java M src/org/openbravo/erpCommon/ad_forms/DocMovement.java M src/org/openbravo/erpCommon/ad_forms/DocProduction.java --- |
|
(0046843) vmromanos (manager) 2012-03-28 17:17 |
Code review + testing OK. The error message properly informs about the product and date. Nice to have for code: Change throw new IllegalStateException() by throw new RuntimeException(). IllegalStateException inherits from RuntimeException and it's used when the JVM state is not right for attending the request. |
|
(0047187) hudsonbot (developer) 2012-04-02 06:11 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-02-22 04:11 | gregor1com | New Issue | |
| 2012-02-22 04:11 | gregor1com | Assigned To | => vmromanos |
| 2012-02-22 04:11 | gregor1com | Modules | => Core |
| 2012-03-06 10:42 | dalsasua | Summary | GFR: Posting error: no cost is not descriptive enough to resolve issue => Flagship: Posting error: no cost is not descriptive enough to resolve issue |
| 2012-03-14 10:38 | eduardo_Argal | Assigned To | vmromanos => eduardo_Argal |
| 2012-03-14 12:50 | eduardo_Argal | Status | new => scheduled |
| 2012-03-14 12:50 | eduardo_Argal | Note Added: 0046386 | |
| 2012-03-14 12:50 | eduardo_Argal | fix_in_branch | => pi |
| 2012-03-21 17:58 | hgbot | Checkin | |
| 2012-03-21 17:58 | hgbot | Note Added: 0046612 | |
| 2012-03-21 17:58 | hgbot | Status | scheduled => resolved |
| 2012-03-21 17:58 | hgbot | Resolution | open => fixed |
| 2012-03-21 17:58 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/d48f465c19a78ef486ca963964447783075cb1c0 [^] |
| 2012-03-28 17:17 | vmromanos | Note Added: 0046843 | |
| 2012-03-28 17:17 | vmromanos | Status | resolved => closed |
| 2012-03-28 17:17 | vmromanos | Fixed in Version | => 3.0MP9 |
| 2012-03-30 08:28 | mirurita | Status | closed => new |
| 2012-03-30 08:28 | mirurita | Resolution | fixed => open |
| 2012-03-30 08:28 | mirurita | Fixed in Version | 3.0MP9 => |
| 2012-03-30 08:28 | mirurita | Status | new => scheduled |
| 2012-03-30 08:28 | mirurita | Status | scheduled => resolved |
| 2012-03-30 08:28 | mirurita | Fixed in Version | => 3.0MP10 |
| 2012-03-30 08:28 | mirurita | Resolution | open => fixed |
| 2012-03-30 08:28 | mirurita | Status | resolved => closed |
| 2012-04-02 06:11 | hudsonbot | Checkin | |
| 2012-04-02 06:11 | hudsonbot | Note Added: 0047187 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |