Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019833Openbravo ERP07. Sales managementpublic2012-02-22 04:112012-04-02 06:11
Reportergregor1com 
Assigned Toeduardo_Argal 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP10 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019833: Flagship: Posting error: no cost is not descriptive enough to resolve issue
DescriptionIn the goods issue form, transactions fail posting because of a zero cost line. This can be seen in an alert and in the window itself. However, a company may have hundreds of lines on for given shipment it could be any one or more that are failing for this reason.

The user needs to bring up the shipment, navigate to the lines, link on to the product for the first line, select the cost tab, and manually inspect the costs to ensure that the line has a cost that is valid for the transaction date. Then, when they discover that it is okay, they need to do it for the next line, and so on. this is too much of a burden on usability.

Steps To ReproduceSee above.
In the live builds environment you can reproduce this by shipping goods on a multi-line order. Take any product and make sure that there is no valid cost for the transaction date. Also, make sure that you include many shipment lines of various products to see the burden that this involves.

Follow the instructions given in the description above. Try to post. The post fails due to no cost. Then, attempt to resolve as a user who does not know where the problem is. You will see that not enough information is given.
Proposed SolutionChoice #1: when posting, a message will be provided at the moment of failure that indicates which line(s) do not have cost. The message should be descriptive enough to indicate the product name(s) and could ideally allow for direct link to places where the problem arose. CHoice #2: the alert will be raised with the same information. This is necessary anyway, in the case of #1. However, it is possible to do this only through the alert even though less desirable. Moment of error is the most important.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-02-22 04:11gregor1comNew Issue
2012-02-22 04:11gregor1comAssigned To => vmromanos
2012-02-22 04:11gregor1comModules => Core
2012-03-06 10:42dalsasuaSummaryGFR: Posting error: no cost is not descriptive enough to resolve issue => Flagship: Posting error: no cost is not descriptive enough to resolve issue
2012-03-14 10:38eduardo_ArgalAssigned Tovmromanos => eduardo_Argal
2012-03-14 12:50eduardo_ArgalStatusnew => scheduled
2012-03-14 12:50eduardo_ArgalNote Added: 0046386
2012-03-14 12:50eduardo_Argalfix_in_branch => pi
2012-03-21 17:58hgbotCheckin
2012-03-21 17:58hgbotNote Added: 0046612
2012-03-21 17:58hgbotStatusscheduled => resolved
2012-03-21 17:58hgbotResolutionopen => fixed
2012-03-21 17:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d48f465c19a78ef486ca963964447783075cb1c0 [^]
2012-03-28 17:17vmromanosNote Added: 0046843
2012-03-28 17:17vmromanosStatusresolved => closed
2012-03-28 17:17vmromanosFixed in Version => 3.0MP9
2012-03-30 08:28miruritaStatusclosed => new
2012-03-30 08:28miruritaResolutionfixed => open
2012-03-30 08:28miruritaFixed in Version3.0MP9 =>
2012-03-30 08:28miruritaStatusnew => scheduled
2012-03-30 08:28miruritaStatusscheduled => resolved
2012-03-30 08:28miruritaFixed in Version => 3.0MP10
2012-03-30 08:28miruritaResolutionopen => fixed
2012-03-30 08:28miruritaStatusresolved => closed
2012-04-02 06:11hudsonbotCheckin
2012-04-02 06:11hudsonbotNote Added: 0047187

Notes
(0046386)
eduardo_Argal   
2012-03-14 12:50   
Test plan:
1 Create a shipment selecting a product in lines for which date and product there is no cost defined in the system.
2 Realize when trying to post that system now pops up a message indicating which product and for which date there is no cost defined
3 fix cost by defining one for that product and date range and post again. Now transaction should be posted correctly to the ledger


Repeat previous steps with material movements and production documents
(0046612)
hgbot   
2012-03-21 17:58   
Repository: erp/devel/pi
Changeset: d48f465c19a78ef486ca963964447783075cb1c0
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Wed Mar 14 13:33:19 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d48f465c19a78ef486ca963964447783075cb1c0 [^]

Fixes bug 19833: Flagship: Posting error: no cost is not descriptive enough to resolve issue

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_forms/AcctServer.java
M src/org/openbravo/erpCommon/ad_forms/DocInOut.java
M src/org/openbravo/erpCommon/ad_forms/DocInventory.java
M src/org/openbravo/erpCommon/ad_forms/DocMovement.java
M src/org/openbravo/erpCommon/ad_forms/DocProduction.java
---
(0046843)
vmromanos   
2012-03-28 17:17   
Code review + testing OK.
The error message properly informs about the product and date.

Nice to have for code:
Change throw new IllegalStateException() by throw new RuntimeException().
IllegalStateException inherits from RuntimeException and it's used when the JVM state is not right for attending the request.
(0047187)
hudsonbot   
2012-04-02 06:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test