Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0019805 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2012-02-17 14:45 | 2012-04-02 10:24 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0MP9 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 5821df1f30bc | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | main | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0019805: Inconsistent column-width in grid comparing chromium to FF10 | |||||||
| Description | When opening the Sales Invoice window and checking column line width then one column does always take up all available remaining space so is much wider. - Using FF10 this is the 'Product' column - Using chromium this is the 'UOM' column Happens in current live.builds/main and also pi Does also happen in demo.openbravo.com, So also present in MP7.1 | |||||||
| Steps To Reproduce | see description. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  sales_invoices_line_ff10.png [^] (75,727 bytes) 2012-02-17 14:46
sales_invoices_line_chromium.png [^] (99,307 bytes) 2012-02-17 14:46
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0045465) hgbot (developer) 2012-02-27 11:49 |
Repository: erp/devel/pi Changeset: 5d04ccfa2cd8970d958ca1988700e2e12e60241f Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Mon Feb 27 11:18:21 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/5d04ccfa2cd8970d958ca1988700e2e12e60241f [^] Related to issue 19805: Modify grid properties of String and Foreign Key fields Include info about the length of ForeignKeyUIDefinition in the getGridFieldProperties method. Edit the info about the length of StringUIDefinition so it is taken from field.getDisplayedLength() istead of field.getColumn().getLength(). This length info is then used to select the field that will be automatically expanded in the grid (if any). --- M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/StringUIDefinition.java --- |
|
(0045466) hgbot (developer) 2012-02-27 11:49 |
Repository: erp/devel/pi Changeset: 4d25a7e6f421c76c078af6714f7db2c896a7276e Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Mon Feb 27 11:30:01 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/4d25a7e6f421c76c078af6714f7db2c896a7276e [^] Fixes issue 19805: Fix function that sorts an array by the length property To decide which field should be automatically expanded in the field, the array that contains all the fields is sorted by the length property. Then the available field with the highest length will the one being auto expanded. The function used to sort the array was faulty, now it is fixed: it puts first in descending order the fields that have defined the length property, and after them it puts the fields that do not have that property defined. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js --- |
|
(0045467) AugustoMauch (administrator) 2012-02-27 11:54 |
The code that has been changed is only used to select the field (if any) that will be auto expanded in the grid. This feature is now working properly (the field with the highest displayed length will be selected for auto expanding). This fix is not risky. |
|
(0045962) hudsonbot (developer) 2012-03-02 15:39 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^] Maturity status: Test |
|
(0045963) hudsonbot (developer) 2012-03-02 15:39 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^] Maturity status: Test |
|
(0046348) dbaz (developer) 2012-03-13 15:31 |
I can reproduce it in changeset 15787 - 65db26640ba6 |
|
(0046357) hgbot (developer) 2012-03-13 17:01 |
Repository: erp/devel/pi Changeset: adc3dd7a561d56f19c557851c85b7c94693b415d Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Tue Mar 13 16:57:44 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/adc3dd7a561d56f19c557851c85b7c94693b415d [^] Fixes issue 19805: Column width in grid is now consistent. When there were more than one field with the same displaylength, the way they were positioned in the ordered array varied. Now if two fields have the same displaylength, their length property is checked. If the value of that property is also the same, the name of the fields is taken into account. This way, all the browsers produ ce the same ordered array. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js --- |
|
(0047006) hgbot (developer) 2012-04-01 20:33 |
Repository: erp/devel/pi Changeset: 5821df1f30bc067c2355d2801fe9a6d6de2e08f0 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Tue Mar 13 16:57:44 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/5821df1f30bc067c2355d2801fe9a6d6de2e08f0 [^] Fixes issue 19805: Column width in grid is now consistent. When there were more than one field with the same displaylength, the way they were positioned in the ordered array varied. Now if two fields have the same displaylength, their length property is checked. If the value of that property is also the same, the name of the fields is taken into account. This way, all the browsers produ ce the same ordered array. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js --- |
|
(0047123) hudsonbot (developer) 2012-04-02 06:10 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-02-17 14:45 | shuehner | New Issue | |
| 2012-02-17 14:45 | shuehner | Assigned To | => alostale |
| 2012-02-17 14:45 | shuehner | Modules | => Core |
| 2012-02-17 14:46 | shuehner | File Added: sales_invoices_line_ff10.png | |
| 2012-02-17 14:46 | shuehner | File Added: sales_invoices_line_chromium.png | |
| 2012-02-22 15:57 | alostale | Assigned To | alostale => AugustoMauch |
| 2012-02-27 11:49 | hgbot | Checkin | |
| 2012-02-27 11:49 | hgbot | Note Added: 0045465 | |
| 2012-02-27 11:49 | hgbot | Checkin | |
| 2012-02-27 11:49 | hgbot | Note Added: 0045466 | |
| 2012-02-27 11:49 | hgbot | Status | new => resolved |
| 2012-02-27 11:49 | hgbot | Resolution | open => fixed |
| 2012-02-27 11:49 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/4d25a7e6f421c76c078af6714f7db2c896a7276e [^] |
| 2012-02-27 11:54 | AugustoMauch | Note Added: 0045467 | |
| 2012-02-28 17:36 | marvintm | Status | resolved => closed |
| 2012-03-02 15:39 | hudsonbot | Checkin | |
| 2012-03-02 15:39 | hudsonbot | Note Added: 0045962 | |
| 2012-03-02 15:39 | hudsonbot | Checkin | |
| 2012-03-02 15:39 | hudsonbot | Note Added: 0045963 | |
| 2012-03-08 16:46 | AugustoMauch | Relationship added | related to 0019984 |
| 2012-03-13 15:31 | dbaz | Note Added: 0046348 | |
| 2012-03-13 15:31 | dbaz | Status | closed => new |
| 2012-03-13 15:31 | dbaz | Resolution | fixed => open |
| 2012-03-13 17:01 | hgbot | Checkin | |
| 2012-03-13 17:01 | hgbot | Note Added: 0046357 | |
| 2012-03-13 17:01 | hgbot | Status | new => resolved |
| 2012-03-13 17:01 | hgbot | Resolution | open => fixed |
| 2012-03-13 17:01 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/4d25a7e6f421c76c078af6714f7db2c896a7276e [^] => http://code.openbravo.com/erp/devel/pi/rev/adc3dd7a561d56f19c557851c85b7c94693b415d [^] |
| 2012-03-13 17:30 | marvintm | Status | resolved => closed |
| 2012-04-01 20:33 | hgbot | Checkin | |
| 2012-04-01 20:33 | hgbot | Note Added: 0047006 | |
| 2012-04-01 20:33 | hgbot | Status | closed => resolved |
| 2012-04-01 20:33 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/adc3dd7a561d56f19c557851c85b7c94693b415d [^] => http://code.openbravo.com/erp/devel/pi/rev/5821df1f30bc067c2355d2801fe9a6d6de2e08f0 [^] |
| 2012-04-02 06:10 | hudsonbot | Checkin | |
| 2012-04-02 06:10 | hudsonbot | Note Added: 0047123 | |
| 2012-04-02 10:24 | AugustoMauch | Status | resolved => closed |
| 2012-04-02 10:24 | AugustoMauch | Fixed in Version | => 3.0MP9 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |