Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019805Openbravo ERPA. Platformpublic2012-02-17 14:452012-04-02 10:24
Reportershuehner 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in Version3.0MP9 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019805: Inconsistent column-width in grid comparing chromium to FF10
DescriptionWhen opening the Sales Invoice window and checking column line width then one column does always take up all available remaining space so is much wider.

- Using FF10 this is the 'Product' column
- Using chromium this is the 'UOM' column

Happens in current live.builds/main and also pi

Does also happen in demo.openbravo.com, So also present in MP7.1
Steps To Reproducesee description.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00199843.0MP9 closed AugustoMauch Values of string and textarea grid items are being truncated. 
Attached Filespng sales_invoices_line_ff10.png (75,727) 2012-02-17 14:46
https://issues.openbravo.com/file_download.php?file_id=5003&type=bug
png

png sales_invoices_line_chromium.png (99,307) 2012-02-17 14:46
https://issues.openbravo.com/file_download.php?file_id=5004&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-02-17 14:45shuehnerNew Issue
2012-02-17 14:45shuehnerAssigned To => alostale
2012-02-17 14:45shuehnerModules => Core
2012-02-17 14:46shuehnerFile Added: sales_invoices_line_ff10.png
2012-02-17 14:46shuehnerFile Added: sales_invoices_line_chromium.png
2012-02-22 15:57alostaleAssigned Toalostale => AugustoMauch
2012-02-27 11:49hgbotCheckin
2012-02-27 11:49hgbotNote Added: 0045465
2012-02-27 11:49hgbotCheckin
2012-02-27 11:49hgbotNote Added: 0045466
2012-02-27 11:49hgbotStatusnew => resolved
2012-02-27 11:49hgbotResolutionopen => fixed
2012-02-27 11:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4d25a7e6f421c76c078af6714f7db2c896a7276e [^]
2012-02-27 11:54AugustoMauchNote Added: 0045467
2012-02-28 17:36marvintmStatusresolved => closed
2012-03-02 15:39hudsonbotCheckin
2012-03-02 15:39hudsonbotNote Added: 0045962
2012-03-02 15:39hudsonbotCheckin
2012-03-02 15:39hudsonbotNote Added: 0045963
2012-03-08 16:46AugustoMauchRelationship addedrelated to 0019984
2012-03-13 15:31dbazNote Added: 0046348
2012-03-13 15:31dbazStatusclosed => new
2012-03-13 15:31dbazResolutionfixed => open
2012-03-13 17:01hgbotCheckin
2012-03-13 17:01hgbotNote Added: 0046357
2012-03-13 17:01hgbotStatusnew => resolved
2012-03-13 17:01hgbotResolutionopen => fixed
2012-03-13 17:01hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/4d25a7e6f421c76c078af6714f7db2c896a7276e [^] => http://code.openbravo.com/erp/devel/pi/rev/adc3dd7a561d56f19c557851c85b7c94693b415d [^]
2012-03-13 17:30marvintmStatusresolved => closed
2012-04-01 20:33hgbotCheckin
2012-04-01 20:33hgbotNote Added: 0047006
2012-04-01 20:33hgbotStatusclosed => resolved
2012-04-01 20:33hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/adc3dd7a561d56f19c557851c85b7c94693b415d [^] => http://code.openbravo.com/erp/devel/pi/rev/5821df1f30bc067c2355d2801fe9a6d6de2e08f0 [^]
2012-04-02 06:10hudsonbotCheckin
2012-04-02 06:10hudsonbotNote Added: 0047123
2012-04-02 10:24AugustoMauchStatusresolved => closed
2012-04-02 10:24AugustoMauchFixed in Version => 3.0MP9

Notes
(0045465)
hgbot   
2012-02-27 11:49   
Repository: erp/devel/pi
Changeset: 5d04ccfa2cd8970d958ca1988700e2e12e60241f
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Feb 27 11:18:21 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5d04ccfa2cd8970d958ca1988700e2e12e60241f [^]

Related to issue 19805: Modify grid properties of String and Foreign Key fields

Include info about the length of ForeignKeyUIDefinition in the getGridFieldProperties method. Edit the info about the length of StringUIDefinition so it is taken from field.getDisplayedLength() istead of field.getColumn().getLength(). This length info is then used to select the field that will be automatically expanded in the grid (if any).

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/StringUIDefinition.java
---
(0045466)
hgbot   
2012-02-27 11:49   
Repository: erp/devel/pi
Changeset: 4d25a7e6f421c76c078af6714f7db2c896a7276e
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Feb 27 11:30:01 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4d25a7e6f421c76c078af6714f7db2c896a7276e [^]

Fixes issue 19805: Fix function that sorts an array by the length property

To decide which field should be automatically expanded in the field, the array that contains all the fields is sorted by the length property. Then the available field with the highest length will the one being auto expanded. The function used to sort the array was faulty, now it is fixed: it puts first in descending order the fields that have defined the length property, and after them it puts the fields that do not have that property defined.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0045467)
AugustoMauch   
2012-02-27 11:54   
The code that has been changed is only used to select the field (if any) that will be auto expanded in the grid. This feature is now working properly (the field with the highest displayed length will be selected for auto expanding).

This fix is not risky.
(0045962)
hudsonbot   
2012-03-02 15:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045963)
hudsonbot   
2012-03-02 15:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0046348)
dbaz   
2012-03-13 15:31   
I can reproduce it in changeset 15787 - 65db26640ba6
(0046357)
hgbot   
2012-03-13 17:01   
Repository: erp/devel/pi
Changeset: adc3dd7a561d56f19c557851c85b7c94693b415d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 13 16:57:44 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/adc3dd7a561d56f19c557851c85b7c94693b415d [^]

Fixes issue 19805: Column width in grid is now consistent.

When there were more than one field with the same displaylength, the way they were positioned in the ordered array varied.
Now if two fields have the same displaylength, their length property is checked. If the value of that property is also the same, the name of the fields is taken into account. This way, all the browsers produ
ce the same ordered array.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0047006)
hgbot   
2012-04-01 20:33   
Repository: erp/devel/pi
Changeset: 5821df1f30bc067c2355d2801fe9a6d6de2e08f0
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 13 16:57:44 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5821df1f30bc067c2355d2801fe9a6d6de2e08f0 [^]

Fixes issue 19805: Column width in grid is now consistent.

When there were more than one field with the same displaylength, the way they were positioned in the ordered array varied.
Now if two fields have the same displaylength, their length property is checked. If the value of that property is also the same, the name of the fields is taken into account. This way, all the browsers produ
ce the same ordered array.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0047123)
hudsonbot   
2012-04-02 06:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test