0019724: See database id when stepping through records of different orgs

Notes
(0045000) hgbot (developer) 2012-02-10 11:26	Repository: erp/devel/pi Changeset: bcbda0ffe5d873d2dbf98a96e8dfb67bc7a50965 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Fri Feb 10 11:26:01 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/bcbda0ffe5d873d2dbf98a96e8dfb67bc7a50965 [^] Fixes issue 19724: See database id when stepping through records of different orgs Clear the form values before opening the form If the value is not present in the valuemap then return an empty string to be displayed --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js ---

(0045106) iperdomo (reporter) 2012-02-14 13:41	Tested on pi @ rev d960e016aae1 * Using QA Testing client - Create several sales order in different orgs (Spain, USA) - Using the next/previous buttons, move across records - Check the BP dropdown

(0045796) hudsonbot (developer) 2012-03-02 15:35	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^] Maturity status: Test

(0048056) hgbot (developer) 2012-04-26 17:30	Repository: erp/devel/pi Changeset: 37ae4fda88808dc1f7f14d533cda143e256abf63 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Thu Apr 26 17:29:26 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/37ae4fda88808dc1f7f14d533cda143e256abf63 [^] Fixed issue 20352. Do not remove an invalid value from the selector. Reverted change done in changeset bcbda0ffe5d8. This change was causing the following behaviour to happen: - When a field is used as part of a displaylogic of a different field, a redraw of the window will be done in case the selector value happens. - This redraw will cause a call to the mapValueToDisplay method. - If the user is typing the name of the business partner, the value will not be one of the valid business partner names (yet). - With the previous version of the method, the value was then discarded. This produced the very annoying effect of reverting what the user had typed just after he had done it, if he hadn't been 'fast enough' to type the whole identifier of the business partner. With the change done, the selector will not be cleared if a user types a (not yet completely correct) value in the selector, even if there is a valueMap which doesn't contain what the user has typed. The issue which was supposedly fixed with this part of the mentioned changeset (issue 19724) still works fine as far as I can tell, even after having removed this part of the change. --- M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js ---

(0048063) hgbot (developer) 2012-04-26 18:40	Repository: erp/devel/pi Changeset: 0a1670b979e2c0d42e97e8c8b045b4a760df9a28 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Thu Apr 26 18:37:11 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/0a1670b979e2c0d42e97e8c8b045b4a760df9a28 [^] Fixed issue 20352. Fixed also in case of combos. Provided a better solution which doesn't cancel previous fix. - After the previous fix, we've realized that the same problem happened in the case of combos. - Also, the previous fix reverted the fix of issue 19724, which could still be reproduceable in very specific circumstances. Due to this, a new fix has been done. Instead of never removing the value if it didn't comply with any of the values in the map, we remove it if and only if the value is a UUID. This way, we avoid the problem in issue 19724 while still fixing the problem which happens when the user types a value. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js ---

(0048165) hudsonbot (developer) 2012-04-28 02:31	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cd923b317af4 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2012-02-10 11:03	mtaal	New Issue
2012-02-10 11:03	mtaal	Assigned To	=> mtaal
2012-02-10 11:03	mtaal	Modules	=> Core
2012-02-10 11:26	hgbot	Checkin
2012-02-10 11:26	hgbot	Note Added: 0045000
2012-02-10 11:26	hgbot	Status	new => resolved
2012-02-10 11:26	hgbot	Resolution	open => fixed
2012-02-10 11:26	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/bcbda0ffe5d873d2dbf98a96e8dfb67bc7a50965 [^]
2012-02-14 13:41	iperdomo	Note Added: 0045106
2012-02-14 13:41	iperdomo	Status	resolved => closed
2012-03-02 15:35	hudsonbot	Checkin
2012-03-02 15:35	hudsonbot	Note Added: 0045796
2012-04-26 17:10	marvintm	Relationship added	related to 0020352
2012-04-26 17:30	hgbot	Checkin
2012-04-26 17:30	hgbot	Note Added: 0048056
2012-04-26 18:40	hgbot	Checkin
2012-04-26 18:40	hgbot	Note Added: 0048063
2012-04-28 02:31	hudsonbot	Checkin
2012-04-28 02:31	hudsonbot	Note Added: 0048165