Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0019711
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2012-02-09 15:492012-03-02 15:35
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version3.0MP9
StatusclosedFix in branchpiFixed in SCM revisionf6b39343e8da
ProjectionnoneETAnoneTarget Version3.0MP9
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0019711: Last view can not be removed/overridden without saving a view

DescriptionThe last view is stored when changing the grid or form layout. The last view is automatically used when a window is opened, if there is no default view.

However, it is not possible to get rid of the last view, to go back to the default system view.
Steps To ReproduceFor example open product category window
change the form or grid layout
close the window and re-open
the changed form/grid layout is shown (correct)
to get back to the default layout, click standard view in the view dropdown
the system default is restored
close the window
open it again, you again see your changed form/grid layout
and not the system default anymore
Proposed SolutionWhen clicking on the standard view option, remove any default last form/grid layout

if a last view is used then show in the view drop down that the standard view is not selected (don't show the triangle in front of it).
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0019554 newTriage Platform Base Inconsistent behavior in last saved state vs saved views. 

-  Notes
(0044982)
mtaal (manager)
2012-02-10 07:05

To test this change:
First test:
- run prof instance
- open a window which does not have a saved view
- change the grid and form layout
- close and open the window and see that the changes are re-applied
- click on the views button
- see that the standard view has no triangle
- click standard view
- the window/form should be set back to the system default
- when closing/opening the window the system default should have been chosen
- check in the preference table and the window personalization that no record exist on form level and that the grid configuration preference is empty
- in the views drop down menu the standard view should have a triangle

Second test:
- run prof instance
- open a window which does not have a saved view
- change the grid and form layout
- close and open the window and see that the changes are re-applied
- make some more layout changes
- save as a view (not the default)
- close and open window
- the first changes should be applied again
- select the created view
- the view layout should be there
- close and open window
- the first changes should be applied again
- now set the saved view above as the default
- close and open the window
- the default saved view should be applied and it should show a triangle
(0044983)
hgbot (developer)
2012-02-10 07:19

Repository: erp/devel/pi
Changeset: f6b39343e8da079e969d5c3f6f59d7fd9d12d464
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Feb 10 07:19:23 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f6b39343e8da079e969d5c3f6f59d7fd9d12d464 [^]

Fixes issue 19711: Last view can not be removed/overridden without saving a view
Clear preference and remove window personalization record when standard view is chosen
Do not show triangle in front of standard view if preference/window personalization applies

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views-toolbar.js
---
(0045123)
dbaz (developer)
2012-02-14 17:57

Maybe I haven't understood well the second test case, but for me it fails:

* I open "Product Category"
* I increse "Search Key" column width
* I go away and come back
* "Search Key" column has increased width (it's ok)
* I increase "Name" column width
* I save the view (no default)
* I go away and come back
* "Search Key" column has increased width (it's ok), but "Name" column has increased width too (according to the second test definition, ONLY the first changes should be applied again)

PD: In this las "come back", my created view is not selected (it's ok, since it is not default)
(0045134)
mtaal (manager)
2012-02-14 22:00

Sorry David, wrong test description for the 2nd case...

Second test:
- run prof instance
- open a window which does not have a saved view
- change the grid and form layout
- close and open the window and see that the changes are re-applied
- make some more layout changes
- save as a view (not the default)
- close and open window
- the last changes should be applied again
- select the created view
- the view layout should be there and show as selected (triangle)
- close and open window
- the last changes should be applied again
- now set the saved view above as the default
- close and open the window
- the default saved view should be applied and it should show a triangle

Can you retry and if you are happy close the issue?
(0045254)
dbaz (developer)
2012-02-18 22:17

Reviewed @ changeset 15532 - c5f71c891935
(0045791)
hudsonbot (developer)
2012-03-02 15:35

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-02-09 15:49 mtaal New Issue
2012-02-09 15:49 mtaal Assigned To => mtaal
2012-02-09 15:49 mtaal Modules => Core
2012-02-09 15:50 mtaal Relationship added related to 0019554
2012-02-09 15:58 mtaal Issue Monitored: rgoris
2012-02-10 07:05 mtaal Note Added: 0044982
2012-02-10 07:19 hgbot Checkin
2012-02-10 07:19 hgbot Note Added: 0044983
2012-02-10 07:19 hgbot Status new => resolved
2012-02-10 07:19 hgbot Resolution open => fixed
2012-02-10 07:19 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f6b39343e8da079e969d5c3f6f59d7fd9d12d464 [^]
2012-02-14 17:57 dbaz Note Added: 0045123
2012-02-14 17:57 dbaz Status resolved => new
2012-02-14 17:57 dbaz Resolution fixed => open
2012-02-14 22:00 mtaal Note Added: 0045134
2012-02-18 22:17 dbaz Status new => scheduled
2012-02-18 22:17 dbaz fix_in_branch => pi
2012-02-18 22:17 dbaz Status scheduled => resolved
2012-02-18 22:17 dbaz Fixed in Version => 3.0MP9
2012-02-18 22:17 dbaz Resolution open => fixed
2012-02-18 22:17 dbaz Note Added: 0045254
2012-02-18 22:17 dbaz Status resolved => closed
2012-03-02 15:35 hudsonbot Checkin
2012-03-02 15:35 hudsonbot Note Added: 0045791


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker