Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019711Openbravo ERPA. Platformpublic2012-02-09 15:492012-03-02 15:35
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP9Fixed in Version3.0MP9 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019711: Last view can not be removed/overridden without saving a view
DescriptionThe last view is stored when changing the grid or form layout. The last view is automatically used when a window is opened, if there is no default view.

However, it is not possible to get rid of the last view, to go back to the default system view.
Steps To ReproduceFor example open product category window
change the form or grid layout
close the window and re-open
the changed form/grid layout is shown (correct)
to get back to the default layout, click standard view in the view dropdown
the system default is restored
close the window
open it again, you again see your changed form/grid layout
and not the system default anymore
Proposed SolutionWhen clicking on the standard view option, remove any default last form/grid layout

if a last view is used then show in the view drop down that the standard view is not selected (don't show the triangle in front of it).
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0019554 new Triage Platform Base Inconsistent behavior in last saved state vs saved views. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-02-09 15:49mtaalNew Issue
2012-02-09 15:49mtaalAssigned To => mtaal
2012-02-09 15:49mtaalModules => Core
2012-02-09 15:50mtaalRelationship addedrelated to 0019554
2012-02-09 15:58mtaalIssue Monitored: rgoris
2012-02-10 07:05mtaalNote Added: 0044982
2012-02-10 07:19hgbotCheckin
2012-02-10 07:19hgbotNote Added: 0044983
2012-02-10 07:19hgbotStatusnew => resolved
2012-02-10 07:19hgbotResolutionopen => fixed
2012-02-10 07:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f6b39343e8da079e969d5c3f6f59d7fd9d12d464 [^]
2012-02-14 17:57dbazNote Added: 0045123
2012-02-14 17:57dbazStatusresolved => new
2012-02-14 17:57dbazResolutionfixed => open
2012-02-14 22:00mtaalNote Added: 0045134
2012-02-18 22:17dbazStatusnew => scheduled
2012-02-18 22:17dbazfix_in_branch => pi
2012-02-18 22:17dbazStatusscheduled => resolved
2012-02-18 22:17dbazFixed in Version => 3.0MP9
2012-02-18 22:17dbazResolutionopen => fixed
2012-02-18 22:17dbazNote Added: 0045254
2012-02-18 22:17dbazStatusresolved => closed
2012-03-02 15:35hudsonbotCheckin
2012-03-02 15:35hudsonbotNote Added: 0045791

Notes
(0044982)
mtaal   
2012-02-10 07:05   
To test this change:
First test:
- run prof instance
- open a window which does not have a saved view
- change the grid and form layout
- close and open the window and see that the changes are re-applied
- click on the views button
- see that the standard view has no triangle
- click standard view
- the window/form should be set back to the system default
- when closing/opening the window the system default should have been chosen
- check in the preference table and the window personalization that no record exist on form level and that the grid configuration preference is empty
- in the views drop down menu the standard view should have a triangle

Second test:
- run prof instance
- open a window which does not have a saved view
- change the grid and form layout
- close and open the window and see that the changes are re-applied
- make some more layout changes
- save as a view (not the default)
- close and open window
- the first changes should be applied again
- select the created view
- the view layout should be there
- close and open window
- the first changes should be applied again
- now set the saved view above as the default
- close and open the window
- the default saved view should be applied and it should show a triangle
(0044983)
hgbot   
2012-02-10 07:19   
Repository: erp/devel/pi
Changeset: f6b39343e8da079e969d5c3f6f59d7fd9d12d464
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Feb 10 07:19:23 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f6b39343e8da079e969d5c3f6f59d7fd9d12d464 [^]

Fixes issue 19711: Last view can not be removed/overridden without saving a view
Clear preference and remove window personalization record when standard view is chosen
Do not show triangle in front of standard view if preference/window personalization applies

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views-toolbar.js
---
(0045123)
dbaz   
2012-02-14 17:57   
Maybe I haven't understood well the second test case, but for me it fails:

* I open "Product Category"
* I increse "Search Key" column width
* I go away and come back
* "Search Key" column has increased width (it's ok)
* I increase "Name" column width
* I save the view (no default)
* I go away and come back
* "Search Key" column has increased width (it's ok), but "Name" column has increased width too (according to the second test definition, ONLY the first changes should be applied again)

PD: In this las "come back", my created view is not selected (it's ok, since it is not default)
(0045134)
mtaal   
2012-02-14 22:00   
Sorry David, wrong test description for the 2nd case...

Second test:
- run prof instance
- open a window which does not have a saved view
- change the grid and form layout
- close and open the window and see that the changes are re-applied
- make some more layout changes
- save as a view (not the default)
- close and open window
- the last changes should be applied again
- select the created view
- the view layout should be there and show as selected (triangle)
- close and open window
- the last changes should be applied again
- now set the saved view above as the default
- close and open the window
- the default saved view should be applied and it should show a triangle

Can you retry and if you are happy close the issue?
(0045254)
dbaz   
2012-02-18 22:17   
Reviewed @ changeset 15532 - c5f71c891935
(0045791)
hudsonbot   
2012-03-02 15:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test