Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0019567
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] Z. Othersminoralways2012-01-26 12:552013-02-18 17:39
ReportermaiteView Statuspublic 
Assigned Todmiguelez 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision8e07931c30b9
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket13985
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0019567: Not grouped Transaction accounting entry when order amount is higher than invoice amount

DescriptionNot grouped Transaction accounting entry when order amount is higher than invoice amount
Steps To Reproduce1. Create Purchase Order for any BP and any product with total amount 100, and a tax rate with a rate higher than 0%.
2. Create Purchase Invoice using "Create Lines From" process and selecting previous order.
3. Go to Purchase Invoice line and modify Tax to set smaller tax amount (so invoice's total amount is smaller that order's total amount): for example, an exempt tax rate.
4. Process Invoice
5. Run "Add Payment In/Out" from Invoice and pay invoice completely (selecting both lines)
6. In case the payment processing hasn't created the withdrawal, go to related Financial Account and add the transaction to the financial account.
7. Configure the payment method in the financial account to generate accounting for the withdrawals.
8. Post Transaction and realize that accounting entry lines associated to provider's account are not grouped.

Problem is that one amount is positive and other negative, and ReportGeneralLedgerJournal_data.xsql does not group this case.

[If you follow same steps but with invoice's amount higher than order's amount, accounting entry lines associated to provider's account are grouped.]

NOTE: Same behaviour experienced in Payment's accounting
Proposed SolutionA first idea for the fix is to modify in ReportGeneralLedgerJournal_data.xsql file, the four GROUP BY statements like this one:
(CASE F.AMTACCTDR WHEN 0 THEN (CASE SIGN(F.AMTACCTCR) WHEN -1 THEN 1 ELSE 2 END) ELSE (CASE SIGN(F.AMTACCTDR) WHEN -1 THEN 3 ELSE 4 END) END)
must be modified to just generate 2 different values (no four): positive debit and negative credit will generate one value; negative debit and positive credit the other value.

As mentioned: it's, in principle, a simple change. Nevertheless, given that the report is used in several ways, and from different places of the ERP; and given that it's a quite critical piece of the financial management area of the ERP, IMHO, it must go to a risky release.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0024990 closededuardo_Argal Modules Not grouped Remittance's accounting entry when there is a negative remittance line 
related to defect 0034432 closedcollazoandy4 Openbravo ERP Accounting information should be grouped by invoice when posting payment/transaction/reconciliation 

-  Notes
(0045706)
eduardo_Argal (viewer)
2012-03-02 13:53

 When selecting allow negatives for a particular document info should be merged.
Have you tried?
(0045708)
jonalegriaesarte (viewer)
2012-03-02 13:57

 Changed to MP10 due to other priorities
(0046230)
dalsasua (viewer)
2012-03-09 12:36
edited on: 2012-03-09 12:36

 As it is a risky change, needs to be included in a risky release. Next one is MP12.

Yes, Eduardo, I tried, and it's failing :o(
(0055808)
hgbot (developer)
2013-01-24 12:12

 Repository: erp/devel/pi
Changeset: 8e07931c30b939d1c8f92eba1fc28a44b2dfe5fb
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jan 24 11:04:36 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8e07931c30b939d1c8f92eba1fc28a44b2dfe5fb [^]

Fixes Issue 19567: When Posting, checks if a Payment Schedule Detail
is an adjust between an Order and an Invoice, and if so, merges it
with another line.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
M src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java
M src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
M src/org/openbravo/erpCommon/ad_forms/DocFINReconciliation.java
---
(0055828)
hudsonbot (viewer)
2013-01-24 21:41

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/fbbe21bdfeff [^]

Maturity status: Test
(0056140)
hgbot (developer)
2013-02-04 20:04

 Repository: erp/devel/pi
Changeset: 8f647753ac34451577bd692a7b53c35692b3709d
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Feb 04 20:03:46 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8f647753ac34451577bd692a7b53c35692b3709d [^]

Related to Issue 0019567: Fixes problem when Posting a Reconciliataion
without Posting the Payment and the Transaction.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
M src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java
M src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
M src/org/openbravo/erpCommon/ad_forms/DocFINReconciliation.java
---
(0056141)
hgbot (developer)
2013-02-04 20:41

 Repository: erp/devel/pi
Changeset: 4130d55738b877f8d3b23a415fba06cb919c1a25
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Feb 04 20:40:52 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4130d55738b877f8d3b23a415fba06cb919c1a25 [^]

Related to Issue 19567: Fixes wrong set of amount.

---
M src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java
M src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
M src/org/openbravo/erpCommon/ad_forms/DocFINReconciliation.java
---
(0056144)
hgbot (developer)
2013-02-05 09:36

 Repository: erp/devel/pi
Changeset: 9bbd07a91478244bc79f62e8e0b46d078e0bc962
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Feb 05 09:35:36 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9bbd07a91478244bc79f62e8e0b46d078e0bc962 [^]

Related to Issue 19567: Fixes Issue with Invoices without related
Order.

---
M src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java
M src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
M src/org/openbravo/erpCommon/ad_forms/DocFINReconciliation.java
---
(0056156)
hgbot (developer)
2013-02-05 12:16

 Repository: erp/devel/pi
Changeset: d47fbb19ff2c8934f895dd710c450bfd4f9629f2
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Feb 05 12:16:10 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d47fbb19ff2c8934f895dd710c450bfd4f9629f2 [^]

Related to Issue 19567. Centralizes code.

---
M src/org/openbravo/erpCommon/ad_forms/AcctServer.java
M src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java
M src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
M src/org/openbravo/erpCommon/ad_forms/DocFINReconciliation.java
---
(0056191)
hudsonbot (viewer)
2013-02-05 22:44

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/86db3ad54671 [^]

Maturity status: Test
(0056192)
hudsonbot (viewer)
2013-02-05 22:44

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/86db3ad54671 [^]

Maturity status: Test
(0056193)
hudsonbot (viewer)
2013-02-05 22:44

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/86db3ad54671 [^]

Maturity status: Test
(0056195)
hudsonbot (viewer)
2013-02-05 22:44

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/86db3ad54671 [^]

Maturity status: Test
(0056529)
maite (viewer)
2013-02-18 17:39

 verified

- Issue History
Date Modified Username Field Change
2012-01-26 12:55 maite New Issue
2012-01-26 12:55 maite Assigned To => jonalegriaesarte
2012-01-26 12:55 maite Modules => Advanced Payables and Receivables Mngmt
2012-01-26 12:55 maite OBNetwork customer => Yes
2012-01-26 12:55 maite Support ticket => 13985
2012-01-26 12:56 maite Assigned To jonalegriaesarte => dalsasua
2012-01-26 19:07 maite Issue Monitored: networkb
2012-02-10 08:44 maite Steps to Reproduce Updated View Revisions
2012-02-20 18:20 jonalegriaesarte Assigned To dalsasua => eduardo_Argal
2012-03-02 13:53 eduardo_Argal Note Added: 0045706
2012-03-02 13:53 eduardo_Argal Status new => feedback
2012-03-02 13:53 eduardo_Argal Assigned To eduardo_Argal => vmromanos
2012-03-02 13:57 jonalegriaesarte Note Added: 0045708
2012-03-02 13:57 jonalegriaesarte Target Version 3.0MP9 => 3.0MP10
2012-03-02 14:09 jonalegriaesarte Assigned To vmromanos => jonalegriaesarte
2012-03-02 14:11 jonalegriaesarte Status feedback => new
2012-03-06 17:53 jonalegriaesarte Assigned To jonalegriaesarte => jecharri
2012-03-09 12:30 dalsasua Steps to Reproduce Updated View Revisions
2012-03-09 12:34 dalsasua Status new => scheduled
2012-03-09 12:34 dalsasua fix_in_branch => pi
2012-03-09 12:35 dalsasua Target Version 3.0MP10 => 3.0MP12
2012-03-09 12:35 dalsasua fix_in_branch pi =>
2012-03-09 12:36 dalsasua Note Added: 0046230
2012-03-09 12:36 dalsasua Note Edited: 0046230 View Revisions
2012-03-09 12:54 dalsasua Proposed Solution updated
2012-04-13 10:11 jecharri Assigned To jecharri => ioritzCia
2012-04-17 13:56 jonalegriaesarte Type defect => design defect
2012-05-30 16:15 ioritzCia Target Version 3.0MP12 =>
2012-09-13 10:42 jonalegriaesarte Assigned To ioritzCia => dmiguelez
2013-01-24 12:12 hgbot Checkin
2013-01-24 12:12 hgbot Note Added: 0055808
2013-01-24 12:12 hgbot Status scheduled => resolved
2013-01-24 12:12 hgbot Resolution open => fixed
2013-01-24 12:12 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8e07931c30b939d1c8f92eba1fc28a44b2dfe5fb [^]
2013-01-24 21:41 hudsonbot Checkin
2013-01-24 21:41 hudsonbot Note Added: 0055828
2013-02-04 20:04 hgbot Checkin
2013-02-04 20:04 hgbot Note Added: 0056140
2013-02-04 20:41 hgbot Checkin
2013-02-04 20:41 hgbot Note Added: 0056141
2013-02-05 09:36 hgbot Checkin
2013-02-05 09:36 hgbot Note Added: 0056144
2013-02-05 12:16 hgbot Checkin
2013-02-05 12:16 hgbot Note Added: 0056156
2013-02-05 22:44 hudsonbot Checkin
2013-02-05 22:44 hudsonbot Note Added: 0056191
2013-02-05 22:44 hudsonbot Checkin
2013-02-05 22:44 hudsonbot Note Added: 0056192
2013-02-05 22:44 hudsonbot Checkin
2013-02-05 22:44 hudsonbot Note Added: 0056193
2013-02-05 22:44 hudsonbot Checkin
2013-02-05 22:44 hudsonbot Note Added: 0056195
2013-02-18 17:39 maite Note Added: 0056529
2013-02-18 17:39 maite Status resolved => closed
2013-10-22 17:13 maite Relationship added related to 0024990
2016-11-08 17:08 maite Relationship added related to 0034432

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker