0019567: Not grouped Transaction accounting entry when order amount is higher than invoice amount - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

ID

Project

Category

View Status

Date Submitted

Last Update

0019567

Openbravo ERP

Z. Others

public

2012-01-26 12:55

2013-02-18 17:39

Reporter

maite

Assigned To

dmiguelez

Priority

high

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS

5

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Advanced Payables and Receivables Mngmt

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0019567: Not grouped Transaction accounting entry when order amount is higher than invoice amount

Description

Not grouped Transaction accounting entry when order amount is higher than invoice amount

Steps To Reproduce

1. Create Purchase Order for any BP and any product with total amount 100, and a tax rate with a rate higher than 0%.
2. Create Purchase Invoice using "Create Lines From" process and selecting previous order.
3. Go to Purchase Invoice line and modify Tax to set smaller tax amount (so invoice's total amount is smaller that order's total amount): for example, an exempt tax rate.
4. Process Invoice
5. Run "Add Payment In/Out" from Invoice and pay invoice completely (selecting both lines)
6. In case the payment processing hasn't created the withdrawal, go to related Financial Account and add the transaction to the financial account.
7. Configure the payment method in the financial account to generate accounting for the withdrawals.
8. Post Transaction and realize that accounting entry lines associated to provider's account are not grouped.

Problem is that one amount is positive and other negative, and ReportGeneralLedgerJournal_data.xsql does not group this case.

[If you follow same steps but with invoice's amount higher than order's amount, accounting entry lines associated to provider's account are grouped.]

NOTE: Same behaviour experienced in Payment's accounting

Proposed Solution

A first idea for the fix is to modify in ReportGeneralLedgerJournal_data.xsql file, the four GROUP BY statements like this one:
(CASE F.AMTACCTDR WHEN 0 THEN (CASE SIGN(F.AMTACCTCR) WHEN -1 THEN 1 ELSE 2 END) ELSE (CASE SIGN(F.AMTACCTDR) WHEN -1 THEN 3 ELSE 4 END) END)
must be modified to just generate 2 different values (no four): positive debit and negative credit will generate one value; negative debit and positive credit the other value.

As mentioned: it's, in principle, a simple change. Nevertheless, given that the report is used in several ways, and from different places of the ERP; and given that it's a quite critical piece of the financial management area of the ERP, IMHO, it must go to a risky release.

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0024990		closed	eduardo_Argal	Modules	Not grouped Remittance's accounting entry when there is a negative remittance line
related to	defect	0034432		closed	collazoandy4	Openbravo ERP	Accounting information should be grouped by invoice when posting payment/transaction/reconciliation

Attached Files

Issue History

Date Modified

Username

Field

Change

2012-01-26 12:55

New Issue

2012-01-26 12:55

Assigned To

=> jonalegriaesarte

2012-01-26 12:55

Modules

=> Advanced Payables and Receivables Mngmt

2012-01-26 12:56

Assigned To

jonalegriaesarte => dalsasua

2012-01-26 19:07

Issue Monitored: networkb

2012-02-10 08:44

Steps to Reproduce Updated

bug_revision_view_page.php?rev_id=3152#r3152

2012-02-20 18:20

jonalegriaesarte

Assigned To

dalsasua => eduardo_Argal

2012-03-02 13:53

Note Added: 0045706

2012-03-02 13:53

Status

new => feedback

2012-03-02 13:53

Assigned To

eduardo_Argal => vmromanos

2012-03-02 13:57

jonalegriaesarte

Note Added: 0045708

2012-03-02 13:57

jonalegriaesarte

Target Version

3.0MP9 => 3.0MP10

2012-03-02 14:09

jonalegriaesarte

Assigned To

vmromanos => jonalegriaesarte

2012-03-02 14:11

jonalegriaesarte

Status

feedback => new

2012-03-06 17:53

jonalegriaesarte

Assigned To

jonalegriaesarte => jecharri

2012-03-09 12:30

Steps to Reproduce Updated

bug_revision_view_page.php?rev_id=3261#r3261

2012-03-09 12:34

Status

new => scheduled

2012-03-09 12:34

fix_in_branch

=> pi

2012-03-09 12:35

Target Version

3.0MP10 => 3.0MP12

2012-03-09 12:35

fix_in_branch

pi =>

2012-03-09 12:36

Note Added: 0046230

2012-03-09 12:36

Note Edited: 0046230

bug_revision_view_page.php?bugnote_id=0046230#r3263

2012-03-09 12:54

Proposed Solution updated

2012-04-13 10:11

Assigned To

jecharri => ioritzCia

2012-04-17 13:56

jonalegriaesarte

Type

defect => design defect

2012-05-30 16:15

Target Version

3.0MP12 =>

2012-09-13 10:42

jonalegriaesarte

Assigned To

ioritzCia => dmiguelez

2013-01-24 12:12

Checkin

2013-01-24 12:12

Note Added: 0055808

2013-01-24 12:12

Status

scheduled => resolved

2013-01-24 12:12

Resolution

open => fixed

2013-01-24 12:12

Fixed in SCM revision

=> http://code.openbravo.com/erp/devel/pi/rev/8e07931c30b939d1c8f92eba1fc28a44b2dfe5fb [^]

2013-01-24 21:41

Checkin

2013-01-24 21:41

Note Added: 0055828

2013-02-04 20:04

Checkin

2013-02-04 20:04

Note Added: 0056140

2013-02-04 20:41

Checkin

2013-02-04 20:41

Note Added: 0056141

2013-02-05 09:36

Checkin

2013-02-05 09:36

Note Added: 0056144

2013-02-05 12:16

Checkin

2013-02-05 12:16

Note Added: 0056156

2013-02-05 22:44

Checkin

2013-02-05 22:44

Note Added: 0056191

2013-02-05 22:44

Checkin

2013-02-05 22:44

Note Added: 0056192

2013-02-05 22:44

Checkin

2013-02-05 22:44

Note Added: 0056193

2013-02-05 22:44

Checkin

2013-02-05 22:44

Note Added: 0056195

2013-02-18 17:39

Note Added: 0056529

2013-02-18 17:39

Status

resolved => closed

2013-10-22 17:13

Relationship added

related to 0024990

2016-11-08 17:08

Relationship added

related to 0034432

Notes