Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0019406
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] A. Platformmajoralways2012-01-03 21:402012-01-24 18:04
ReporterdbazView Statuspublic 
Assigned Todbaz 
PriorityhighResolutionfixedFixed in Version3.0MP8
StatusclosedFix in branchFixed in SCM revision4eb3ae89cc0a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0019406: Email configuration only can use port 25 and no connection security

DescriptionEmail configuration only can use port 25 and no connection security.

It should be able also to use a different port or a connection security STARTTLS or SSL.

As it is now, port 25 is used (default port) and no connection security
Steps To ReproduceAs "Openbravo Admin"
* Go to "Client" -> "Email Configuration"
* Click "New"

Notice that you can not specify neither port nor connection security
Proposed SolutionSee attached diff.
TagsNo tags attached.
Attached Filesdiff file icon email.diff [^] (24,601 bytes) 2012-01-03 21:40 [Show Content]
diff file icon email-callout.diff [^] (8,048 bytes) 2012-01-04 16:07 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate feature request 0013957 closeddbaz To Configure SMTP Sever Port 

-  Notes
(0044105)
dbaz (developer)
2012-01-03 21:46
edited on: 2012-01-05 16:31

 The following tests should be done before close the issue:

Ensure that previous defined email configurations still work:
* Create a working email configuration BEFORE apply the patch
* Update your instance with the patch (the diff) content
* Go to "Email Configuration" window and ensure that the following fields:
"Smtp Connection Security" : None
"Smtp Port" : 25
have been added
* Ensure that the email sending still works.

Ensure that STARTTLS option works:
* Apply the patch and compile
* Create a valid email configuration which uses STARTTLS. Example: any valid gmail account with these values:
"Smtp Connection Security" : STARTTLS
"Smtp Port" : 587
* Ensure that the email sending works
* Change the port to other different than 587
* Check that the email sending DOESN'T work

Ensure that SSL option works:
* Apply the patch and compile
* Create a valid email configuration which uses SSL. Example: any valid gmail account with these values:
"Smtp Connection Security" : SSL
"Smtp Port" : 465
* Ensure that the email sending works
* Change the port to other different than 465
* Check that the email sending DOESN'T work
(0044122)
dbaz (developer)
2012-01-04 16:15
edited on: 2012-01-04 16:15

 Added "email-callout.diff"

This diff provides a callout to set automatically the "Smtp Port" field with the most common port for the "Smtp Connection Security" provided.

The user always can set manually the "Smtp Port" value, but this pre-set would be useful for several smtp servers.

To test it just change the "Smtp Connection Security" field and check that the following change:
"Smtp Connection Security" : None --> "Smtp Port" : 25
"Smtp Connection Security" : STARTTLS --> "Smtp Port" : 587
"Smtp Connection Security" : SSL --> "Smtp Port" : 465
(0044131)
shuehner (administrator)
2012-01-05 16:41

 Note for testing: STARTTLS can also be used on ports != 587. It's i.e. normal to use it (optionally) on port 25. Depends on smtp-server config.
(0044136)
iperdomo (reporter)
2012-01-09 06:55

 @shuehner:
I don't see a problem in "suggesting" the default port for the "Connection Security" type. The user can change it.

http://en.wikipedia.org/wiki/Simple_Mail_Transfer_Protocol#cite_note-13 [^]
(0044140)
shuehner (administrator)
2012-01-09 10:55

 Agreed, no harm in that. My comment was just related to the testplan, the callout proposing a initial value looked fine to me.
(0044172)
hgbot (developer)
2012-01-10 12:45

 Repository: erp/devel/pi
Changeset: 4eb3ae89cc0adf08bbfe502fb5854460453f5e70
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Jan 10 12:44:31 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4eb3ae89cc0adf08bbfe502fb5854460453f5e70 [^]

Fixed issue 19406: Added 'connection security' and 'port' to 'Email Configuration' tab

---
M src-db/database/model/tables/C_POC_CONFIGURATION.xml
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/erpCommon/businessUtility/EMail.java
M src/org/openbravo/erpCommon/utility/poc/EmailManager.java
M src/org/openbravo/erpCommon/utility/poc/Poc_Configuration_data.xsql
A src/org/openbravo/erpCommon/ad_callouts/EmailConfiguration_Port.java
---
(0044174)
hgbot (developer)
2012-01-10 13:11

 Repository: erp/devel/pi
Changeset: ea235d08e58cde2d5800cfe3e4b15df483d99bef
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Jan 10 13:11:21 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ea235d08e58cde2d5800cfe3e4b15df483d99bef [^]

Related to issue 19406: removed unneeded parameter in callout

---
M src/org/openbravo/erpCommon/ad_callouts/EmailConfiguration_Port.java
---
(0044343)
hudsonbot (developer)
2012-01-14 21:20

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test
(0044345)
hudsonbot (developer)
2012-01-14 21:20

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test
(0044523)
alostale (manager)
2012-01-24 18:04

 Code reviewed and tested on pi@a44439184a15

- Issue History
Date Modified Username Field Change
2012-01-03 21:40 dbaz New Issue
2012-01-03 21:40 dbaz Assigned To => dbaz
2012-01-03 21:40 dbaz File Added: email.diff
2012-01-03 21:40 dbaz Modules => Core
2012-01-03 21:46 dbaz Note Added: 0044105
2012-01-04 16:07 dbaz File Added: email-callout.diff
2012-01-04 16:15 dbaz Note Added: 0044122
2012-01-04 16:15 dbaz Note Edited: 0044122 View Revisions
2012-01-05 16:31 dbaz Note Edited: 0044105 View Revisions
2012-01-05 16:32 shuehner Relationship added related to 0013957
2012-01-05 16:41 shuehner Note Added: 0044131
2012-01-09 06:55 iperdomo Note Added: 0044136
2012-01-09 10:55 shuehner Note Added: 0044140
2012-01-10 12:45 hgbot Checkin
2012-01-10 12:45 hgbot Note Added: 0044172
2012-01-10 12:45 hgbot Status new => resolved
2012-01-10 12:45 hgbot Resolution open => fixed
2012-01-10 12:45 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4eb3ae89cc0adf08bbfe502fb5854460453f5e70 [^]
2012-01-10 13:11 hgbot Checkin
2012-01-10 13:11 hgbot Note Added: 0044174
2012-01-10 13:15 dbaz Relationship replaced has duplicate 0013957
2012-01-14 21:20 hudsonbot Checkin
2012-01-14 21:20 hudsonbot Note Added: 0044343
2012-01-14 21:20 hudsonbot Checkin
2012-01-14 21:20 hudsonbot Note Added: 0044345
2012-01-24 18:04 alostale Note Added: 0044523
2012-01-24 18:04 alostale Status resolved => closed
2012-01-24 18:04 alostale Fixed in Version => 3.0MP8

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker