Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019406Openbravo ERPA. Platformpublic2012-01-03 21:402012-01-24 18:04
Reporterdbaz 
Assigned Todbaz 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP8 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019406: Email configuration only can use port 25 and no connection security
DescriptionEmail configuration only can use port 25 and no connection security.

It should be able also to use a different port or a connection security STARTTLS or SSL.

As it is now, port 25 is used (default port) and no connection security
Steps To ReproduceAs "Openbravo Admin"
* Go to "Client" -> "Email Configuration"
* Click "New"

Notice that you can not specify neither port nor connection security
Proposed SolutionSee attached diff.
Additional Information
TagsNo tags attached.
Relationships
has duplicate feature request 0013957 closed dbaz To Configure SMTP Sever Port 
Attached Filesdiff email.diff (24,601) 2012-01-03 21:40
https://issues.openbravo.com/file_download.php?file_id=4875&type=bug
diff email-callout.diff (8,048) 2012-01-04 16:07
https://issues.openbravo.com/file_download.php?file_id=4879&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-01-03 21:40dbazNew Issue
2012-01-03 21:40dbazAssigned To => dbaz
2012-01-03 21:40dbazFile Added: email.diff
2012-01-03 21:40dbazModules => Core
2012-01-03 21:46dbazNote Added: 0044105
2012-01-04 16:07dbazFile Added: email-callout.diff
2012-01-04 16:15dbazNote Added: 0044122
2012-01-04 16:15dbazNote Edited: 0044122bug_revision_view_page.php?bugnote_id=0044122#r3017
2012-01-05 16:31dbazNote Edited: 0044105bug_revision_view_page.php?bugnote_id=0044105#r3021
2012-01-05 16:32shuehnerRelationship addedrelated to 0013957
2012-01-05 16:41shuehnerNote Added: 0044131
2012-01-09 06:55iperdomoNote Added: 0044136
2012-01-09 10:55shuehnerNote Added: 0044140
2012-01-10 12:45hgbotCheckin
2012-01-10 12:45hgbotNote Added: 0044172
2012-01-10 12:45hgbotStatusnew => resolved
2012-01-10 12:45hgbotResolutionopen => fixed
2012-01-10 12:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4eb3ae89cc0adf08bbfe502fb5854460453f5e70 [^]
2012-01-10 13:11hgbotCheckin
2012-01-10 13:11hgbotNote Added: 0044174
2012-01-10 13:15dbazRelationship replacedhas duplicate 0013957
2012-01-14 21:20hudsonbotCheckin
2012-01-14 21:20hudsonbotNote Added: 0044343
2012-01-14 21:20hudsonbotCheckin
2012-01-14 21:20hudsonbotNote Added: 0044345
2012-01-24 18:04alostaleNote Added: 0044523
2012-01-24 18:04alostaleStatusresolved => closed
2012-01-24 18:04alostaleFixed in Version => 3.0MP8

Notes
(0044105)
dbaz   
2012-01-03 21:46   
(edited on: 2012-01-05 16:31)
The following tests should be done before close the issue:

Ensure that previous defined email configurations still work:
* Create a working email configuration BEFORE apply the patch
* Update your instance with the patch (the diff) content
* Go to "Email Configuration" window and ensure that the following fields:
"Smtp Connection Security" : None
"Smtp Port" : 25
have been added
* Ensure that the email sending still works.

Ensure that STARTTLS option works:
* Apply the patch and compile
* Create a valid email configuration which uses STARTTLS. Example: any valid gmail account with these values:
"Smtp Connection Security" : STARTTLS
"Smtp Port" : 587
* Ensure that the email sending works
* Change the port to other different than 587
* Check that the email sending DOESN'T work

Ensure that SSL option works:
* Apply the patch and compile
* Create a valid email configuration which uses SSL. Example: any valid gmail account with these values:
"Smtp Connection Security" : SSL
"Smtp Port" : 465
* Ensure that the email sending works
* Change the port to other different than 465
* Check that the email sending DOESN'T work
(0044122)
dbaz   
2012-01-04 16:15   
Added "email-callout.diff"

This diff provides a callout to set automatically the "Smtp Port" field with the most common port for the "Smtp Connection Security" provided.

The user always can set manually the "Smtp Port" value, but this pre-set would be useful for several smtp servers.

To test it just change the "Smtp Connection Security" field and check that the following change:
"Smtp Connection Security" : None --> "Smtp Port" : 25
"Smtp Connection Security" : STARTTLS --> "Smtp Port" : 587
"Smtp Connection Security" : SSL --> "Smtp Port" : 465
(0044131)
shuehner   
2012-01-05 16:41   
Note for testing: STARTTLS can also be used on ports != 587. It's i.e. normal to use it (optionally) on port 25. Depends on smtp-server config.
(0044136)
iperdomo   
2012-01-09 06:55   
@shuehner:
I don't see a problem in "suggesting" the default port for the "Connection Security" type. The user can change it.

http://en.wikipedia.org/wiki/Simple_Mail_Transfer_Protocol#cite_note-13 [^]
(0044140)
shuehner   
2012-01-09 10:55   
Agreed, no harm in that. My comment was just related to the testplan, the callout proposing a initial value looked fine to me.
(0044172)
hgbot   
2012-01-10 12:45   
Repository: erp/devel/pi
Changeset: 4eb3ae89cc0adf08bbfe502fb5854460453f5e70
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Jan 10 12:44:31 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4eb3ae89cc0adf08bbfe502fb5854460453f5e70 [^]

Fixed issue 19406: Added 'connection security' and 'port' to 'Email Configuration' tab

---
M src-db/database/model/tables/C_POC_CONFIGURATION.xml
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/erpCommon/businessUtility/EMail.java
M src/org/openbravo/erpCommon/utility/poc/EmailManager.java
M src/org/openbravo/erpCommon/utility/poc/Poc_Configuration_data.xsql
A src/org/openbravo/erpCommon/ad_callouts/EmailConfiguration_Port.java
---
(0044174)
hgbot   
2012-01-10 13:11   
Repository: erp/devel/pi
Changeset: ea235d08e58cde2d5800cfe3e4b15df483d99bef
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Jan 10 13:11:21 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ea235d08e58cde2d5800cfe3e4b15df483d99bef [^]

Related to issue 19406: removed unneeded parameter in callout

---
M src/org/openbravo/erpCommon/ad_callouts/EmailConfiguration_Port.java
---
(0044343)
hudsonbot   
2012-01-14 21:20   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test
(0044345)
hudsonbot   
2012-01-14 21:20   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test
(0044523)
alostale   
2012-01-24 18:04   
Code reviewed and tested on pi@a44439184a15