Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0019352
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] B. User interfaceminoralways2011-12-22 16:202012-03-02 15:34
ReporterdbazView Statuspublic 
Assigned Todbaz 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionc2df24bab7bf
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0019352: "Pick & Execute" bottom buttons should be in the bottom

Description"Pick & Execute" bottom buttons should be in the bottom

Reproduced in: Windows 7 + Google Chrome 16 (other environments not tested)
Steps To Reproduce* Install the application examples module:
https://code.openbravo.com/erp/mods/org.openbravo.client.application.examples/ [^]
* Go to the sales order header.

* Click in "Pick Example 1" button. The popup opens.
Notice that there is a big white gap between the bottom buttons and the end of the popup. [Bad.png]

This big gap should be removed. [Good.png]

PD: The distance between the grid and the buttons should be also a bit shorter.
TagsNo tags attached.
Attached Filespng file icon Bad.png [^] (59,701 bytes) 2011-12-22 16:21


png file icon Good.png [^] (66,528 bytes) 2011-12-22 16:21

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0019349 closediperdomo "Pick & Execute" popup is not resized if browser window do 
related to design defect 0020406 newAugustoMauch Styling issues in Modify Payment plan window 

-  Notes
(0044222)
dbaz (developer)
2012-01-10 20:23

Due to fix of issue:

https://issues.openbravo.com/view.php?id=19349 [^]

Now button position is still worst, since the button space is taken based on a %, so the buttons area space and the buttons gap depends on window size, which is wrong.

The only thing that should change its size with a window resize is the grid. The buttons area space and buttons gap should be always fixed.
(0044265)
dbaz (developer)
2012-01-11 15:32

With a fix similar to this you can get a fixed button layout height, and a liquid grid layout height


--- a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-view.js
+++ b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-view.js
@@ -82,7 +82,7 @@
     this.viewGrid = isc.OBPickAndExecuteGrid.create({
       view: this,
       fields: this.gridFields,
- height: '80%',
+ height: '*',
       dataSource: this.dataSource,
       gridProperties: this.viewProperties.gridProperties
     });
@@ -118,6 +118,7 @@
     this.items = [this.viewGrid, isc.HLayout.create({
       align: 'center',
       width: '100%',
+ height: 80,
       members: [isc.HLayout.create({
         width: 1,
         overflow: 'visible',
(0044818)
hgbot (developer)
2012-02-02 15:49

Repository: erp/devel/pi
Changeset: c2df24bab7bfb1756fdfe11f3f3a5c48973ca8b1
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Thu Feb 02 15:48:16 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c2df24bab7bfb1756fdfe11f3f3a5c48973ca8b1 [^]

Fixed issue 19352: 'Pick & Executed' button layout now has a fixed height

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-view.js
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-process-styles.js
---
(0044974)
iperdomo (reporter)
2012-02-09 16:57

Tested in pi @ rev 2d73d1ed6bf1
(0045736)
hudsonbot (developer)
2012-03-02 15:34

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2011-12-22 16:20 dbaz New Issue
2011-12-22 16:20 dbaz Assigned To => iperdomo
2011-12-22 16:20 dbaz Modules => Core
2011-12-22 16:21 dbaz File Added: Bad.png
2011-12-22 16:21 dbaz File Added: Good.png
2011-12-22 16:31 iperdomo Priority high => normal
2011-12-22 16:55 iperdomo Severity major => minor
2012-01-10 20:19 dbaz Relationship added related to 0019349
2012-01-10 20:23 dbaz Note Added: 0044222
2012-01-11 15:32 dbaz Note Added: 0044265
2012-01-24 13:49 iperdomo Assigned To iperdomo => dbaz
2012-02-02 15:49 hgbot Checkin
2012-02-02 15:49 hgbot Note Added: 0044818
2012-02-02 15:49 hgbot Status new => resolved
2012-02-02 15:49 hgbot Resolution open => fixed
2012-02-02 15:49 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c2df24bab7bfb1756fdfe11f3f3a5c48973ca8b1 [^]
2012-02-09 16:57 iperdomo Note Added: 0044974
2012-02-09 16:57 iperdomo Status resolved => closed
2012-03-02 15:34 hudsonbot Checkin
2012-03-02 15:34 hudsonbot Note Added: 0045736
2012-05-03 13:24 rgoris Relationship added related to 0020406


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker