Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019352Openbravo ERPB. User interfacepublic2011-12-22 16:202012-03-02 15:34
Reporterdbaz 
Assigned Todbaz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019352: "Pick & Execute" bottom buttons should be in the bottom
Description"Pick & Execute" bottom buttons should be in the bottom

Reproduced in: Windows 7 + Google Chrome 16 (other environments not tested)
Steps To Reproduce* Install the application examples module:
https://code.openbravo.com/erp/mods/org.openbravo.client.application.examples/ [^]
* Go to the sales order header.

* Click in "Pick Example 1" button. The popup opens.
Notice that there is a big white gap between the bottom buttons and the end of the popup. [Bad.png]

This big gap should be removed. [Good.png]

PD: The distance between the grid and the buttons should be also a bit shorter.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0019349 closed iperdomo "Pick & Execute" popup is not resized if browser window do 
related to design defect 0020406 new AugustoMauch Styling issues in Modify Payment plan window 
Attached Filespng Bad.png (59,701) 2011-12-22 16:21
https://issues.openbravo.com/file_download.php?file_id=4853&type=bug
png

png Good.png (66,528) 2011-12-22 16:21
https://issues.openbravo.com/file_download.php?file_id=4854&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-12-22 16:20dbazNew Issue
2011-12-22 16:20dbazAssigned To => iperdomo
2011-12-22 16:20dbazModules => Core
2011-12-22 16:20dbazOBNetwork customer => No
2011-12-22 16:21dbazFile Added: Bad.png
2011-12-22 16:21dbazFile Added: Good.png
2011-12-22 16:31iperdomoPriorityhigh => normal
2011-12-22 16:55iperdomoSeveritymajor => minor
2012-01-10 20:19dbazRelationship addedrelated to 0019349
2012-01-10 20:23dbazNote Added: 0044222
2012-01-11 15:32dbazNote Added: 0044265
2012-01-24 13:49iperdomoAssigned Toiperdomo => dbaz
2012-02-02 15:49hgbotCheckin
2012-02-02 15:49hgbotNote Added: 0044818
2012-02-02 15:49hgbotStatusnew => resolved
2012-02-02 15:49hgbotResolutionopen => fixed
2012-02-02 15:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c2df24bab7bfb1756fdfe11f3f3a5c48973ca8b1 [^]
2012-02-09 16:57iperdomoNote Added: 0044974
2012-02-09 16:57iperdomoStatusresolved => closed
2012-03-02 15:34hudsonbotCheckin
2012-03-02 15:34hudsonbotNote Added: 0045736
2012-05-03 13:24rgorisRelationship addedrelated to 0020406

Notes
(0044222)
dbaz   
2012-01-10 20:23   
Due to fix of issue:

https://issues.openbravo.com/view.php?id=19349 [^]

Now button position is still worst, since the button space is taken based on a %, so the buttons area space and the buttons gap depends on window size, which is wrong.

The only thing that should change its size with a window resize is the grid. The buttons area space and buttons gap should be always fixed.
(0044265)
dbaz   
2012-01-11 15:32   
With a fix similar to this you can get a fixed button layout height, and a liquid grid layout height


--- a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-view.js
+++ b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-view.js
@@ -82,7 +82,7 @@
     this.viewGrid = isc.OBPickAndExecuteGrid.create({
       view: this,
       fields: this.gridFields,
- height: '80%',
+ height: '*',
       dataSource: this.dataSource,
       gridProperties: this.viewProperties.gridProperties
     });
@@ -118,6 +118,7 @@
     this.items = [this.viewGrid, isc.HLayout.create({
       align: 'center',
       width: '100%',
+ height: 80,
       members: [isc.HLayout.create({
         width: 1,
         overflow: 'visible',
(0044818)
hgbot   
2012-02-02 15:49   
Repository: erp/devel/pi
Changeset: c2df24bab7bfb1756fdfe11f3f3a5c48973ca8b1
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Thu Feb 02 15:48:16 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c2df24bab7bfb1756fdfe11f3f3a5c48973ca8b1 [^]

Fixed issue 19352: 'Pick & Executed' button layout now has a fixed height

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-view.js
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-process-styles.js
---
(0044974)
iperdomo   
2012-02-09 16:57   
Tested in pi @ rev 2d73d1ed6bf1
(0045736)
hudsonbot   
2012-03-02 15:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test