Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0019275 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2011-12-09 16:08 | 2012-04-01 20:37 | |||
| Reporter | rgoris | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | pi | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 6efaffed3b3f | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0019275: Old Error message | |||||||
| Description | Still see the 2.50 messages here and there | |||||||
| Steps To Reproduce | See image. After trying to send an invoice by email | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  olderrors.PNG [^] (134,119 bytes) 2011-12-09 16:08
 19275.export [^] (25,949 bytes) 2012-03-02 15:25 | |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0044864) hgbot (developer) 2012-02-03 15:37 |
Repository: erp/devel/pi Changeset: 3840dfec4bb4f996d6b7230eec8f369754d67fde Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Fri Feb 03 15:36:25 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/3840dfec4bb4f996d6b7230eec8f369754d67fde [^] fixed bug 18063, fixed bug 19275: 2.50 style popup errors --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/classic/ob-classic-compatibility.js M src/org/openbravo/base/secureApp/ErrorPopUp.html --- |
|
(0044866) alostale (manager) 2012-02-03 15:42 |
See note in 0018063 |
|
(0044966) rgoris (developer) 2012-02-09 15:33 |
Asier, problem persists (checked today) - your note in 18063 does not clarify how we are going to solve it. Can you clarify? |
|
(0045527) AugustoMauch (administrator) 2012-02-28 12:29 |
Code reviewed and verified |
|
(0045565) AugustoMauch (administrator) 2012-02-29 10:08 |
The issue is still reproducible. Steps to reproduce: - Open pi Openbravo in live.builds.openbravo.com - Using the F&B Group Admin role, open the Client window and enter the email configuration: * Active: yes * Smtp Server: smtp.openbravo.com * Smtp Server Account: smtp.openbravo.com * Smtp Server Sender Address: user.openbravo.com - Open Sales Order and select a completed order - Click the Email button in the toolbar, a popup will emerge. - Click the Send button in the popup. The old error message will appear. |
|
(0045713) alostale (manager) 2012-03-02 15:23 |
This concrete popup was not fixed by 0018063 because it is doing a multipart request making not to work the standard variable retrieval used to decide if it is a popup or not. New fix applies to this case catching the exception and showing the proper message instead of throwing it up to HSAS. Adds no risk. |
|
(0045752) hudsonbot (developer) 2012-03-02 15:34 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^] Maturity status: Test |
|
(0046066) hgbot (developer) 2012-03-06 08:45 |
Repository: erp/devel/pi Changeset: 6efaffed3b3ff5b43a5dffba21707e469ac37a67 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Fri Mar 02 15:25:09 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/6efaffed3b3ff5b43a5dffba21707e469ac37a67 [^] fixed bug 19275: Old Error message Fixed PrintController popup error messages --- M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java --- |
|
(0046746) rgoris (developer) 2012-03-27 09:45 |
Tested and approved. Please note that this kind of error message (in a modal popup) is not our generic error message pattern. Normally it would be shown in a red horizontal message bar across the top of the parent level view. In this case - although I did not have your current solution in mind - using a modal message popup is ok (or even better) as the error was caused by an interstitial popup (email dialog). Thanks. |
|
(0047041) hudsonbot (developer) 2012-04-01 20:37 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/640de9acc2d5 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-12-09 16:08 | rgoris | New Issue | |
| 2011-12-09 16:08 | rgoris | Assigned To | => alostale |
| 2011-12-09 16:08 | rgoris | File Added: olderrors.PNG | |
| 2011-12-09 16:08 | rgoris | Modules | => Core |
| 2011-12-15 08:59 | alostale | Relationship added | related to 0018063 |
| 2012-02-03 15:37 | hgbot | Checkin | |
| 2012-02-03 15:37 | hgbot | Note Added: 0044864 | |
| 2012-02-03 15:37 | hgbot | Status | new => resolved |
| 2012-02-03 15:37 | hgbot | Resolution | open => fixed |
| 2012-02-03 15:37 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/3840dfec4bb4f996d6b7230eec8f369754d67fde [^] |
| 2012-02-03 15:42 | alostale | Note Added: 0044866 | |
| 2012-02-09 15:33 | rgoris | Note Added: 0044966 | |
| 2012-02-28 12:29 | AugustoMauch | Note Added: 0045527 | |
| 2012-02-28 12:29 | AugustoMauch | Status | resolved => closed |
| 2012-02-28 12:29 | AugustoMauch | Fixed in Version | => 3.0MP9 |
| 2012-02-29 10:08 | AugustoMauch | Note Added: 0045565 | |
| 2012-02-29 10:08 | AugustoMauch | Status | closed => new |
| 2012-02-29 10:08 | AugustoMauch | Resolution | fixed => open |
| 2012-02-29 10:08 | AugustoMauch | Fixed in Version | 3.0MP9 => |
| 2012-03-02 15:23 | alostale | Note Added: 0045713 | |
| 2012-03-02 15:25 | alostale | File Added: 19275.export | |
| 2012-03-02 15:34 | hudsonbot | Checkin | |
| 2012-03-02 15:34 | hudsonbot | Note Added: 0045752 | |
| 2012-03-06 08:45 | hgbot | Checkin | |
| 2012-03-06 08:45 | hgbot | Note Added: 0046066 | |
| 2012-03-06 08:45 | hgbot | Status | new => resolved |
| 2012-03-06 08:45 | hgbot | Resolution | open => fixed |
| 2012-03-06 08:45 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/3840dfec4bb4f996d6b7230eec8f369754d67fde [^] => http://code.openbravo.com/erp/devel/pi/rev/6efaffed3b3ff5b43a5dffba21707e469ac37a67 [^] |
| 2012-03-27 09:45 | rgoris | Note Added: 0046746 | |
| 2012-03-27 09:45 | rgoris | Status | resolved => closed |
| 2012-03-27 09:45 | rgoris | Fixed in Version | => pi |
| 2012-04-01 20:37 | hudsonbot | Checkin | |
| 2012-04-01 20:37 | hudsonbot | Note Added: 0047041 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |