Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019275Openbravo ERPA. Platformpublic2011-12-09 16:082012-04-01 20:37
Reporterrgoris 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019275: Old Error message
DescriptionStill see the 2.50 messages here and there
Steps To ReproduceSee image. After trying to send an invoice by email
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0018063 closed alostale Wrong back button is shown when no access to table is shown 
Attached Filespng olderrors.PNG (134,119) 2011-12-09 16:08
https://issues.openbravo.com/file_download.php?file_id=4827&type=bug
png

? 19275.export (25,949) 2012-03-02 15:25
https://issues.openbravo.com/file_download.php?file_id=5051&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-12-09 16:08rgorisNew Issue
2011-12-09 16:08rgorisAssigned To => alostale
2011-12-09 16:08rgorisFile Added: olderrors.PNG
2011-12-09 16:08rgorisModules => Core
2011-12-15 08:59alostaleRelationship addedrelated to 0018063
2012-02-03 15:37hgbotCheckin
2012-02-03 15:37hgbotNote Added: 0044864
2012-02-03 15:37hgbotStatusnew => resolved
2012-02-03 15:37hgbotResolutionopen => fixed
2012-02-03 15:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3840dfec4bb4f996d6b7230eec8f369754d67fde [^]
2012-02-03 15:42alostaleNote Added: 0044866
2012-02-09 15:33rgorisNote Added: 0044966
2012-02-28 12:29AugustoMauchNote Added: 0045527
2012-02-28 12:29AugustoMauchStatusresolved => closed
2012-02-28 12:29AugustoMauchFixed in Version => 3.0MP9
2012-02-29 10:08AugustoMauchNote Added: 0045565
2012-02-29 10:08AugustoMauchStatusclosed => new
2012-02-29 10:08AugustoMauchResolutionfixed => open
2012-02-29 10:08AugustoMauchFixed in Version3.0MP9 =>
2012-03-02 15:23alostaleNote Added: 0045713
2012-03-02 15:25alostaleFile Added: 19275.export
2012-03-02 15:34hudsonbotCheckin
2012-03-02 15:34hudsonbotNote Added: 0045752
2012-03-06 08:45hgbotCheckin
2012-03-06 08:45hgbotNote Added: 0046066
2012-03-06 08:45hgbotStatusnew => resolved
2012-03-06 08:45hgbotResolutionopen => fixed
2012-03-06 08:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/3840dfec4bb4f996d6b7230eec8f369754d67fde [^] => http://code.openbravo.com/erp/devel/pi/rev/6efaffed3b3ff5b43a5dffba21707e469ac37a67 [^]
2012-03-27 09:45rgorisNote Added: 0046746
2012-03-27 09:45rgorisStatusresolved => closed
2012-03-27 09:45rgorisFixed in Version => pi
2012-04-01 20:37hudsonbotCheckin
2012-04-01 20:37hudsonbotNote Added: 0047041

Notes
(0044864)
hgbot   
2012-02-03 15:37   
Repository: erp/devel/pi
Changeset: 3840dfec4bb4f996d6b7230eec8f369754d67fde
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 03 15:36:25 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3840dfec4bb4f996d6b7230eec8f369754d67fde [^]

fixed bug 18063, fixed bug 19275: 2.50 style popup errors

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/classic/ob-classic-compatibility.js
M src/org/openbravo/base/secureApp/ErrorPopUp.html
---
(0044866)
alostale   
2012-02-03 15:42   
See note in 0018063
(0044966)
rgoris   
2012-02-09 15:33   
Asier, problem persists (checked today) - your note in 18063 does not clarify how we are going to solve it. Can you clarify?
(0045527)
AugustoMauch   
2012-02-28 12:29   
Code reviewed and verified
(0045565)
AugustoMauch   
2012-02-29 10:08   
The issue is still reproducible.

Steps to reproduce:
- Open pi Openbravo in live.builds.openbravo.com
- Using the F&B Group Admin role, open the Client window and enter the email configuration:
  * Active: yes
  * Smtp Server: smtp.openbravo.com
  * Smtp Server Account: smtp.openbravo.com
  * Smtp Server Sender Address: user.openbravo.com
- Open Sales Order and select a completed order
- Click the Email button in the toolbar, a popup will emerge.
- Click the Send button in the popup. The old error message will appear.
(0045713)
alostale   
2012-03-02 15:23   
This concrete popup was not fixed by 0018063 because it is doing a multipart request making not to work the standard variable retrieval used to decide if it is a popup or not.

New fix applies to this case catching the exception and showing the proper message instead of throwing it up to HSAS.

Adds no risk.
(0045752)
hudsonbot   
2012-03-02 15:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0046066)
hgbot   
2012-03-06 08:45   
Repository: erp/devel/pi
Changeset: 6efaffed3b3ff5b43a5dffba21707e469ac37a67
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Mar 02 15:25:09 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6efaffed3b3ff5b43a5dffba21707e469ac37a67 [^]

fixed bug 19275: Old Error message

  Fixed PrintController popup error messages

---
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---
(0046746)
rgoris   
2012-03-27 09:45   
Tested and approved. Please note that this kind of error message (in a modal popup) is not our generic error message pattern. Normally it would be shown in a red horizontal message bar across the top of the parent level view.

In this case - although I did not have your current solution in mind - using a modal message popup is ok (or even better) as the error was caused by an interstitial popup (email dialog).

Thanks.
(0047041)
hudsonbot   
2012-04-01 20:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/640de9acc2d5 [^]

Maturity status: Test