Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0019254 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] A. Platform | minor | always | 2011-12-06 20:40 | 2011-12-20 11:14 | |||
| Reporter | roklenardic | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 391f37b71c5d | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0019254: TabView wrapper class | |||||||
| Description | When creating view implementation that will be viewed within tabs, the developer finds him or herself repeatedly adding this piece of code that takes care of the history and refresh: getBookMarkParams: function() { var result = {}; result.viewId = this.getClassName(); result.labelContent = this.labelContent; result.tabTitle = this.tabTitle; return result; }, (see http://wiki.openbravo.com/wiki/How_to_implement_a_new_main_view#Taking_care_of_history.2Fback_button.2Fpage_refresh [^]) I suggest a wrapper OBTabView is created for the View implementation that embeds the above code in a new class, so instead of: isc.ClassFactory.defineClass('EXAMPLE_MyNewView', isc.VLayout); the developer could write: isc.ClassFactory.defineClass('EXAMPLE_MyNewView', isc.OBTabView); | |||||||
| Steps To Reproduce | see above | |||||||
| Proposed Solution | new wrapper OBTabView | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0043798) hgbot (developer) 2011-12-12 12:24 |
Repository: erp/devel/pi Changeset: 391f37b71c5d96fabba6d6280e5ba2578355237f Author: Martin Taal <martin.taal <at> openbravo.com> Date: Mon Dec 12 12:21:31 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/391f37b71c5d96fabba6d6280e5ba2578355237f [^] Fixes issue 19254: TabView wrapper class --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-base-view.js --- |
|
(0043799) mtaal (manager) 2011-12-12 12:25 |
Added a remark in the howto: http://wiki.openbravo.com/wiki/How_to_implement_a_new_main_view#Create_a_javascript_file_with_the_class_definition_of_the_view [^] |
|
(0043800) iperdomo (reporter) 2011-12-12 12:47 |
@mtaal: Please add a note in the documentation, that the TabView wrapper class will be available from 3.0MP7. |
|
(0043801) mtaal (manager) 2011-12-12 12:52 |
I did not add a TabView class, there was already an existing BaseView class which I adapted a bit. So afaics no additional remark is needed. gr. Martin |
|
(0043846) hudsonbot (developer) 2011-12-13 16:44 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8a06361cc265 [^] Maturity status: Test |
|
(0043970) iperdomo (reporter) 2011-12-20 11:14 |
Tested on pi @ rev 02b1c160d9eb |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-12-06 20:40 | roklenardic | New Issue | |
| 2011-12-06 20:40 | roklenardic | Assigned To | => mtaal |
| 2011-12-06 20:40 | roklenardic | Modules | => Core |
| 2011-12-12 12:24 | hgbot | Checkin | |
| 2011-12-12 12:24 | hgbot | Note Added: 0043798 | |
| 2011-12-12 12:24 | hgbot | Status | new => resolved |
| 2011-12-12 12:24 | hgbot | Resolution | open => fixed |
| 2011-12-12 12:24 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/391f37b71c5d96fabba6d6280e5ba2578355237f [^] |
| 2011-12-12 12:25 | mtaal | Note Added: 0043799 | |
| 2011-12-12 12:47 | iperdomo | Note Added: 0043800 | |
| 2011-12-12 12:52 | mtaal | Note Added: 0043801 | |
| 2011-12-13 16:44 | hudsonbot | Checkin | |
| 2011-12-13 16:44 | hudsonbot | Note Added: 0043846 | |
| 2011-12-20 11:14 | iperdomo | Note Added: 0043970 | |
| 2011-12-20 11:14 | iperdomo | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |