Openbravo Issue Tracking System - Openbravo ERP |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0019254 | Openbravo ERP | A. Platform | public | 2011-12-06 20:40 | 2011-12-20 11:14 |
|
Reporter | roklenardic | |
Assigned To | mtaal | |
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | pi | |
Target Version | | Fixed in Version | | |
Merge Request Status | |
Review Assigned To | |
OBNetwork customer | |
Web browser | |
Modules | Core |
Support ticket | |
Regression level | |
Regression date | |
Regression introduced in release | |
Regression introduced by commit | |
Triggers an Emergency Pack | No |
|
Summary | 0019254: TabView wrapper class |
Description | When creating view implementation that will be viewed within tabs, the developer finds him or herself repeatedly adding this piece of code that takes care of the history and refresh:
getBookMarkParams: function() {
var result = {};
result.viewId = this.getClassName();
result.labelContent = this.labelContent;
result.tabTitle = this.tabTitle;
return result;
},
(see http://wiki.openbravo.com/wiki/How_to_implement_a_new_main_view#Taking_care_of_history.2Fback_button.2Fpage_refresh [^])
I suggest a wrapper OBTabView is created for the View implementation that embeds the above code in a new class, so instead of:
isc.ClassFactory.defineClass('EXAMPLE_MyNewView', isc.VLayout);
the developer could write:
isc.ClassFactory.defineClass('EXAMPLE_MyNewView', isc.OBTabView);
|
Steps To Reproduce | see above |
Proposed Solution | new wrapper OBTabView |
Additional Information | |
Tags | No tags attached. |
Relationships | |
Attached Files | |
|
Issue History |
Date Modified | Username | Field | Change |
2011-12-06 20:40 | roklenardic | New Issue | |
2011-12-06 20:40 | roklenardic | Assigned To | => mtaal |
2011-12-06 20:40 | roklenardic | Modules | => Core |
2011-12-12 12:24 | hgbot | Checkin | |
2011-12-12 12:24 | hgbot | Note Added: 0043798 | |
2011-12-12 12:24 | hgbot | Status | new => resolved |
2011-12-12 12:24 | hgbot | Resolution | open => fixed |
2011-12-12 12:24 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/391f37b71c5d96fabba6d6280e5ba2578355237f [^] |
2011-12-12 12:25 | mtaal | Note Added: 0043799 | |
2011-12-12 12:47 | iperdomo | Note Added: 0043800 | |
2011-12-12 12:52 | mtaal | Note Added: 0043801 | |
2011-12-13 16:44 | hudsonbot | Checkin | |
2011-12-13 16:44 | hudsonbot | Note Added: 0043846 | |
2011-12-20 11:14 | iperdomo | Note Added: 0043970 | |
2011-12-20 11:14 | iperdomo | Status | resolved => closed |
Notes |
|
(0043798)
|
hgbot
|
2011-12-12 12:24
|
|
|
|
(0043799)
|
mtaal
|
2011-12-12 12:25
|
|
|
|
|
@mtaal:
Please add a note in the documentation, that the TabView wrapper class will be available from 3.0MP7. |
|
|
(0043801)
|
mtaal
|
2011-12-12 12:52
|
|
I did not add a TabView class, there was already an existing BaseView class which I adapted a bit. So afaics no additional remark is needed.
gr. Martin |
|
|
|
|
|
|
Tested on pi @ rev 02b1c160d9eb |
|