Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019254Openbravo ERPA. Platformpublic2011-12-06 20:402011-12-20 11:14
Reporterroklenardic 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019254: TabView wrapper class
DescriptionWhen creating view implementation that will be viewed within tabs, the developer finds him or herself repeatedly adding this piece of code that takes care of the history and refresh:

  getBookMarkParams: function() {
        var result = {};
        result.viewId = this.getClassName();
        result.labelContent = this.labelContent;
        result.tabTitle = this.tabTitle;
        return result;
      },

(see http://wiki.openbravo.com/wiki/How_to_implement_a_new_main_view#Taking_care_of_history.2Fback_button.2Fpage_refresh [^])

I suggest a wrapper OBTabView is created for the View implementation that embeds the above code in a new class, so instead of:

isc.ClassFactory.defineClass('EXAMPLE_MyNewView', isc.VLayout);

the developer could write:
isc.ClassFactory.defineClass('EXAMPLE_MyNewView', isc.OBTabView);
Steps To Reproducesee above
Proposed Solutionnew wrapper OBTabView
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-12-06 20:40roklenardicNew Issue
2011-12-06 20:40roklenardicAssigned To => mtaal
2011-12-06 20:40roklenardicModules => Core
2011-12-06 20:40roklenardicOBNetwork customer => No
2011-12-12 12:24hgbotCheckin
2011-12-12 12:24hgbotNote Added: 0043798
2011-12-12 12:24hgbotStatusnew => resolved
2011-12-12 12:24hgbotResolutionopen => fixed
2011-12-12 12:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/391f37b71c5d96fabba6d6280e5ba2578355237f [^]
2011-12-12 12:25mtaalNote Added: 0043799
2011-12-12 12:47iperdomoNote Added: 0043800
2011-12-12 12:52mtaalNote Added: 0043801
2011-12-13 16:44hudsonbotCheckin
2011-12-13 16:44hudsonbotNote Added: 0043846
2011-12-20 11:14iperdomoNote Added: 0043970
2011-12-20 11:14iperdomoStatusresolved => closed

Notes
(0043798)
hgbot   
2011-12-12 12:24   
Repository: erp/devel/pi
Changeset: 391f37b71c5d96fabba6d6280e5ba2578355237f
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Dec 12 12:21:31 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/391f37b71c5d96fabba6d6280e5ba2578355237f [^]

Fixes issue 19254: TabView wrapper class

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-base-view.js
---
(0043799)
mtaal   
2011-12-12 12:25   
Added a remark in the howto:
http://wiki.openbravo.com/wiki/How_to_implement_a_new_main_view#Create_a_javascript_file_with_the_class_definition_of_the_view [^]
(0043800)
iperdomo   
2011-12-12 12:47   
@mtaal:
Please add a note in the documentation, that the TabView wrapper class will be available from 3.0MP7.
(0043801)
mtaal   
2011-12-12 12:52   
I did not add a TabView class, there was already an existing BaseView class which I adapted a bit. So afaics no additional remark is needed.

gr. Martin
(0043846)
hudsonbot   
2011-12-13 16:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8a06361cc265 [^]

Maturity status: Test
(0043970)
iperdomo   
2011-12-20 11:14   
Tested on pi @ rev 02b1c160d9eb