Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0019158 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | always | 2011-11-23 18:02 | 2011-12-13 16:43 | |||
| Reporter | jecharri | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 5c986866991f | ||||
| Projection | none | ETA | none | Target Version | 3.0MP7 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | Google Chrome | |||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0019158: If you use a manual process but you define as Standard process it doesn't fail | |||||||
| Description | If you want to use a manual "process" but when you are definning the process in the application you put in "UI Pattern" field the "Standard" type, if you do "ant smartbuild" it doesn't fail (this is not correct) but if you do "ant compile.complete", build failled. | |||||||
| Steps To Reproduce | As "System Administrator" go to "Reports and Process": -Find the process "AlertProcess". - In the filed "UI Pattern", change to Standard. After that, do "ant smartbuild" and see that all goes ok. Now do "ant compile.complete", you will see next error: Compiling 955 source files to /home/openbravo/src/30POSTGRES/pi/build/classes /home/openbravo/src/30POSTGRES/pi/srcAD/org/openbravo/erpCommon/ad_actionButton/ActionButtonJava_Responser.java:1258: <identifier> expected The problem is that the "ant smartbuild" must detect this failures new ().execute(pb); | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0043596) alostale (manager) 2011-11-30 18:09 edited on: 2011-12-01 10:00 |
There are two problems: -If the Standard UI process is not in the menu, changes on it are not detected by smartbuild. -Solution: detect them by smartbuild -When a Standard UI process has no java class, it fails in compilation but it is difficult to identify which process is the one causing the problem. -Solution: Add a new WADValidation to inform about the failing processes in a readable manner. |
|
(0043624) alostale (manager) 2011-12-01 10:04 |
Test plan: *Execute ant smartuild to ensure there is no pending modifications to build. *Find the process "AlertProcess". *In the filed "UI Pattern", change to Standard. *Execute ant smartbuild. -Build should fail in compilation because of this incorrect process. -This problem should be reported within initial validations. Regression risk: This fix just adds to smarbuild some processes that were not compiled but they should. It cannot add any functional regression as it is part of the build. In build it won't add regressions as smartbuild is now compiling processes that were not compiled before but that were compiled by compile.complete. |
|
(0043770) hgbot (developer) 2011-12-12 08:31 |
Repository: erp/devel/pi Changeset: a9240f52094573682911db827767e815c774688f Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Thu Dec 01 10:09:16 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/a9240f52094573682911db827767e815c774688f [^] fixed bug 19158: Incorrect processes are not failing in smartbuild -smartbuild detects now processes not in menu -new build validation complains about Standard UI processes without java --- M src-wad/src/org/openbravo/wad/ActionButton_Relation_data.xsql M src-wad/src/org/openbravo/wad/validation/WADValidationResult.java M src-wad/src/org/openbravo/wad/validation/WADValidator.java M src-wad/src/org/openbravo/wad/validation/WADValidator_data.xsql --- |
|
(0043784) marvintm (developer) 2011-12-12 10:36 |
The validation works, the process is generated and the compilation fails. However, once the process is changed back to manual, the process class is not regenerated, and the compilation fails again. |
|
(0043785) hgbot (developer) 2011-12-12 11:16 |
Repository: erp/devel/pi Changeset: 5c986866991f92505038f9616a86928517a87a1b Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Mon Dec 12 11:16:00 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/5c986866991f92505038f9616a86928517a87a1b [^] fixed bug 19158: Incorrect processes are not failing in smartbuild ActionButtonJavaResposer is regenerated on any modification in processes, not just for Standard UI ones. Covering in this way the case of moving an invalid Standard UI process to Manual. --- M src-wad/src/org/openbravo/wad/ActionButton_Relation_data.xsql --- |
|
(0043788) marvintm (developer) 2011-12-12 11:32 |
Verified again, this time it correctly detects the change and regenerates the file, and the compilation works again. |
|
(0043837) hudsonbot (developer) 2011-12-13 16:43 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8a06361cc265 [^] Maturity status: Test |
|
(0043840) hudsonbot (developer) 2011-12-13 16:43 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8a06361cc265 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-11-23 18:02 | jecharri | New Issue | |
| 2011-11-23 18:02 | jecharri | Assigned To | => alostale |
| 2011-11-23 18:02 | jecharri | Web browser | => Google Chrome |
| 2011-11-23 18:02 | jecharri | Modules | => Core |
| 2011-11-23 18:02 | jecharri | Resolution time | => 1329174000 |
| 2011-11-30 18:09 | alostale | Note Added: 0043596 | |
| 2011-12-01 10:00 | alostale | Note Edited: 0043596 | View Revisions |
| 2011-12-01 10:04 | alostale | Note Added: 0043624 | |
| 2011-12-12 08:31 | hgbot | Checkin | |
| 2011-12-12 08:31 | hgbot | Note Added: 0043770 | |
| 2011-12-12 08:31 | hgbot | Status | new => resolved |
| 2011-12-12 08:31 | hgbot | Resolution | open => fixed |
| 2011-12-12 08:31 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/a9240f52094573682911db827767e815c774688f [^] |
| 2011-12-12 10:36 | marvintm | Note Added: 0043784 | |
| 2011-12-12 10:36 | marvintm | Status | resolved => new |
| 2011-12-12 10:36 | marvintm | Resolution | fixed => open |
| 2011-12-12 11:16 | hgbot | Checkin | |
| 2011-12-12 11:16 | hgbot | Note Added: 0043785 | |
| 2011-12-12 11:16 | hgbot | Status | new => resolved |
| 2011-12-12 11:16 | hgbot | Resolution | open => fixed |
| 2011-12-12 11:16 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/a9240f52094573682911db827767e815c774688f [^] => http://code.openbravo.com/erp/devel/pi/rev/5c986866991f92505038f9616a86928517a87a1b [^] |
| 2011-12-12 11:32 | marvintm | Note Added: 0043788 | |
| 2011-12-12 11:32 | marvintm | Status | resolved => closed |
| 2011-12-13 16:43 | hudsonbot | Checkin | |
| 2011-12-13 16:43 | hudsonbot | Note Added: 0043837 | |
| 2011-12-13 16:43 | hudsonbot | Checkin | |
| 2011-12-13 16:43 | hudsonbot | Note Added: 0043840 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |