Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019158Openbravo ERPA. Platformpublic2011-11-23 18:022011-12-13 16:43
Reporterjecharri 
Assigned Toalostale 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP7Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019158: If you use a manual process but you define as Standard process it doesn't fail
DescriptionIf you want to use a manual "process" but when you are definning the process in the application you put in "UI Pattern" field the "Standard" type, if you do "ant smartbuild" it doesn't fail (this is not correct) but if you do "ant compile.complete", build failled.

Steps To ReproduceAs "System Administrator" go to "Reports and Process":
-Find the process "AlertProcess".
- In the filed "UI Pattern", change to Standard.

After that, do "ant smartbuild" and see that all goes ok.
Now do "ant compile.complete", you will see next error:

Compiling 955 source files to /home/openbravo/src/30POSTGRES/pi/build/classes
/home/openbravo/src/30POSTGRES/pi/srcAD/org/openbravo/erpCommon/ad_actionButton/ActionButtonJava_Responser.java:1258: <identifier> expected

The problem is that the "ant smartbuild" must detect this failures
           new ().execute(pb);
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-11-23 18:02jecharriNew Issue
2011-11-23 18:02jecharriAssigned To => alostale
2011-11-23 18:02jecharriWeb browser => Google Chrome
2011-11-23 18:02jecharriModules => Core
2011-11-23 18:02jecharriResolution time => 1329174000
2011-11-30 18:09alostaleNote Added: 0043596
2011-12-01 10:00alostaleNote Edited: 0043596bug_revision_view_page.php?bugnote_id=0043596#r2957
2011-12-01 10:04alostaleNote Added: 0043624
2011-12-12 08:31hgbotCheckin
2011-12-12 08:31hgbotNote Added: 0043770
2011-12-12 08:31hgbotStatusnew => resolved
2011-12-12 08:31hgbotResolutionopen => fixed
2011-12-12 08:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a9240f52094573682911db827767e815c774688f [^]
2011-12-12 10:36marvintmNote Added: 0043784
2011-12-12 10:36marvintmStatusresolved => new
2011-12-12 10:36marvintmResolutionfixed => open
2011-12-12 11:16hgbotCheckin
2011-12-12 11:16hgbotNote Added: 0043785
2011-12-12 11:16hgbotStatusnew => resolved
2011-12-12 11:16hgbotResolutionopen => fixed
2011-12-12 11:16hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/a9240f52094573682911db827767e815c774688f [^] => http://code.openbravo.com/erp/devel/pi/rev/5c986866991f92505038f9616a86928517a87a1b [^]
2011-12-12 11:32marvintmNote Added: 0043788
2011-12-12 11:32marvintmStatusresolved => closed
2011-12-13 16:43hudsonbotCheckin
2011-12-13 16:43hudsonbotNote Added: 0043837
2011-12-13 16:43hudsonbotCheckin
2011-12-13 16:43hudsonbotNote Added: 0043840

Notes
(0043596)
alostale   
2011-11-30 18:09   
(edited on: 2011-12-01 10:00)
There are two problems:
 -If the Standard UI process is not in the menu, changes on it are not detected by smartbuild.
     -Solution: detect them by smartbuild
 -When a Standard UI process has no java class, it fails in compilation but it is difficult to identify which process is the one causing the problem.
     -Solution: Add a new WADValidation to inform about the failing processes in a readable manner.
(0043624)
alostale   
2011-12-01 10:04   
Test plan:
  *Execute ant smartuild to ensure there is no pending modifications to build.
  *Find the process "AlertProcess".
  *In the filed "UI Pattern", change to Standard.
  *Execute ant smartbuild.
     -Build should fail in compilation because of this incorrect process.
     -This problem should be reported within initial validations.
Regression risk:
  This fix just adds to smarbuild some processes that were not compiled but they should. It cannot add any functional regression as it is part of the build. In build it won't add regressions as smartbuild is now compiling processes that were not compiled before but that were compiled by compile.complete.
(0043770)
hgbot   
2011-12-12 08:31   
Repository: erp/devel/pi
Changeset: a9240f52094573682911db827767e815c774688f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Dec 01 10:09:16 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a9240f52094573682911db827767e815c774688f [^]

fixed bug 19158: Incorrect processes are not failing in smartbuild
  -smartbuild detects now processes not in menu
  -new build validation complains about Standard UI processes without java

---
M src-wad/src/org/openbravo/wad/ActionButton_Relation_data.xsql
M src-wad/src/org/openbravo/wad/validation/WADValidationResult.java
M src-wad/src/org/openbravo/wad/validation/WADValidator.java
M src-wad/src/org/openbravo/wad/validation/WADValidator_data.xsql
---
(0043784)
marvintm   
2011-12-12 10:36   
The validation works, the process is generated and the compilation fails. However, once the process is changed back to manual, the process class is not regenerated, and the compilation fails again.
(0043785)
hgbot   
2011-12-12 11:16   
Repository: erp/devel/pi
Changeset: 5c986866991f92505038f9616a86928517a87a1b
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Dec 12 11:16:00 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5c986866991f92505038f9616a86928517a87a1b [^]

fixed bug 19158: Incorrect processes are not failing in smartbuild

  ActionButtonJavaResposer is regenerated on any modification in processes,
  not just for Standard UI ones. Covering in this way the case of moving an
  invalid Standard UI process to Manual.

---
M src-wad/src/org/openbravo/wad/ActionButton_Relation_data.xsql
---
(0043788)
marvintm   
2011-12-12 11:32   
Verified again, this time it correctly detects the change and regenerates the file, and the compilation works again.
(0043837)
hudsonbot   
2011-12-13 16:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8a06361cc265 [^]

Maturity status: Test
(0043840)
hudsonbot   
2011-12-13 16:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8a06361cc265 [^]

Maturity status: Test