Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0019157 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | critical | have not tried | 2011-11-23 17:10 | 2011-11-30 12:29 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | a281ac41f2b4 | |||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0019157: API changes due to /view.php?id=18470 | |||||||
| Description | Fix for issue 0018470 introduced two hidden API changes in tab definition: 1. Before there was a property called inpkeyColumnId which contained the *name* of the tab's primary key column, this property is still present but now it contains the *id* of the column. 2. Before there was a property with named as the primary key column in database containing the record pk value, this property has been completely removed. As these properties were passed as request parameters to all 2.50 style servlets, they are now failing. | |||||||
| Steps To Reproduce | The following core components are not working properly: -In module window, select a module as default. A callout is executed, it raises an exception (can be seen in the log). -Same for the callout executed in Payment Proposal window | |||||||
| Proposed Solution | Revert these API changes to the status they were before 0018470 | |||||||
| Tags | Regression | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0043123) alostale (manager) 2011-11-23 18:30 |
Test plan: -Check the 2 broken components defined in the steps to reproduce are now working. -Check when calling a process is possible to retrieve its pk value as parameter named table name + _ID Regression checks: -This fix adds a small regression possibility. As it is reverting an API change introduced in mp4, it is creating an API change from mp4. So components implemented in the mp4 way might be broken, even this is unlikely. |
|
(0043124) hgbot (developer) 2011-11-23 18:34 |
Repository: erp/devel/pi Changeset: a281ac41f2b409df4462ff8943f5e847c66869c7 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Wed Nov 23 18:32:11 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/a281ac41f2b409df4462ff8943f5e847c66869c7 [^] fixed bug 19157: API changes due to 0018470 --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-tab.js.ftl M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewTab.java --- |
|
(0043205) marvintm (developer) 2011-11-25 10:57 |
Reviewed the diff, verified that (apart from the very unlikely risk of a regression in a component implemented in MP4) there are no regressions. Tested broken callouts, verified that they receive the properties with a correct value and that they work fine. Verified also that a process called through a button receives both properties correctly. |
|
(0043430) hudsonbot (developer) 2011-11-30 12:29 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/01809c7b3135 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-11-23 17:10 | alostale | New Issue | |
| 2011-11-23 17:10 | alostale | Assigned To | => alostale |
| 2011-11-23 17:10 | alostale | Modules | => Core |
| 2011-11-23 17:40 | jonalegriaesarte | Issue Monitored: jonalegriaesarte | |
| 2011-11-23 18:30 | alostale | Note Added: 0043123 | |
| 2011-11-23 18:34 | hgbot | Checkin | |
| 2011-11-23 18:34 | hgbot | Note Added: 0043124 | |
| 2011-11-23 18:34 | hgbot | Status | new => resolved |
| 2011-11-23 18:34 | hgbot | Resolution | open => fixed |
| 2011-11-23 18:34 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/a281ac41f2b409df4462ff8943f5e847c66869c7 [^] |
| 2011-11-24 12:18 | alostale | Tag Attached: Regression | |
| 2011-11-24 12:19 | alostale | Status | resolved => new |
| 2011-11-24 12:19 | alostale | Resolution | fixed => open |
| 2011-11-24 12:19 | alostale | Relationship added | related to 0018470 |
| 2011-11-24 12:20 | alostale | Status | new => scheduled |
| 2011-11-24 12:20 | alostale | fix_in_branch | => pi |
| 2011-11-24 12:20 | alostale | Status | scheduled => resolved |
| 2011-11-24 12:20 | alostale | Resolution | open => fixed |
| 2011-11-25 10:57 | marvintm | Note Added: 0043205 | |
| 2011-11-25 10:57 | marvintm | Status | resolved => closed |
| 2011-11-30 12:29 | hudsonbot | Checkin | |
| 2011-11-30 12:29 | hudsonbot | Note Added: 0043430 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |