Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019157Openbravo ERPA. Platformpublic2011-11-23 17:102011-11-30 12:29
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019157: API changes due to /view.php?id=18470
DescriptionFix for issue 0018470 introduced two hidden API changes in tab definition:
1. Before there was a property called inpkeyColumnId which contained the *name* of the tab's primary key column, this property is still present but now it contains the *id* of the column.
2. Before there was a property with named as the primary key column in database containing the record pk value, this property has been completely removed.

As these properties were passed as request parameters to all 2.50 style servlets, they are now failing.
Steps To ReproduceThe following core components are not working properly:
-In module window, select a module as default. A callout is executed, it raises an exception (can be seen in the log).
-Same for the callout executed in Payment Proposal window
Proposed SolutionRevert these API changes to the status they were before 0018470
Additional Information
TagsRegression
Relationships
related to defect 00184703.0MP4 closed mtaal Performance: generate smaller javascript for a window, improve view generation performance 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-11-23 17:10alostaleNew Issue
2011-11-23 17:10alostaleAssigned To => alostale
2011-11-23 17:10alostaleModules => Core
2011-11-23 17:40jonalegriaesarteIssue Monitored: jonalegriaesarte
2011-11-23 18:30alostaleNote Added: 0043123
2011-11-23 18:34hgbotCheckin
2011-11-23 18:34hgbotNote Added: 0043124
2011-11-23 18:34hgbotStatusnew => resolved
2011-11-23 18:34hgbotResolutionopen => fixed
2011-11-23 18:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a281ac41f2b409df4462ff8943f5e847c66869c7 [^]
2011-11-24 12:18alostaleTag Attached: Regression
2011-11-24 12:19alostaleStatusresolved => new
2011-11-24 12:19alostaleResolutionfixed => open
2011-11-24 12:19alostaleRelationship addedrelated to 0018470
2011-11-24 12:20alostaleStatusnew => scheduled
2011-11-24 12:20alostalefix_in_branch => pi
2011-11-24 12:20alostaleStatusscheduled => resolved
2011-11-24 12:20alostaleResolutionopen => fixed
2011-11-25 10:57marvintmNote Added: 0043205
2011-11-25 10:57marvintmStatusresolved => closed
2011-11-30 12:29hudsonbotCheckin
2011-11-30 12:29hudsonbotNote Added: 0043430

Notes
(0043123)
alostale   
2011-11-23 18:30   
Test plan:
-Check the 2 broken components defined in the steps to reproduce are now working.
-Check when calling a process is possible to retrieve its pk value as parameter named table name + _ID

Regression checks:
-This fix adds a small regression possibility. As it is reverting an API change introduced in mp4, it is creating an API change from mp4. So components implemented in the mp4 way might be broken, even this is unlikely.
(0043124)
hgbot   
2011-11-23 18:34   
Repository: erp/devel/pi
Changeset: a281ac41f2b409df4462ff8943f5e847c66869c7
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Nov 23 18:32:11 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a281ac41f2b409df4462ff8943f5e847c66869c7 [^]

fixed bug 19157: API changes due to 0018470

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-tab.js.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewTab.java
---
(0043205)
marvintm   
2011-11-25 10:57   
Reviewed the diff, verified that (apart from the very unlikely risk of a regression in a component implemented in MP4) there are no regressions.

Tested broken callouts, verified that they receive the properties with a correct value and that they work fine. Verified also that a process called through a button receives both properties correctly.
(0043430)
hudsonbot   
2011-11-30 12:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/01809c7b3135 [^]

Maturity status: Test