0019135: FIN_AddPayment - savePayment method not managing properly exceptions

Description

org.openbravo.advpaymentmngt.process.FIN_AddPayment

savePayment method not managing properly exceptions.

it should raise the exception to be caught by caller method.

Steps To Reproduce

1) Modify APRM_FIN_PMT_CHECK_TRG adding a raise exception at the beginning
RAISE EXCEPTION '%', '@20501@'; --OBTG:-20000--
2) Create a new sales invoice and complete
3) Click on Add Payment In button
4) On the popup click on OK button
Realize that the message shown is a generic message (it provides useless information to the user) and if you raise the exception using the message search key (i.e. @20501@) the exception is not translated.

Proposed Solution

catch the flush event
OBDal.getInstance().flush();

when calling this method you should manage then catch the exception this method can return. (for example in AddPaymentFromInvoice.)

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0018752

closed

ioritzCia

FIN_AddPayment - savePayment method not managing properly exceptions

Notes
(0043648) hgbot (developer) 2011-12-01 12:04	Repository: erp/pmods/org.openbravo.advpaymentmngt Changeset: 21de7a16a9b74067f2b707ef22ee1298d8d8b8db Author: Ioritz Cia <ioritz.cia <at> openbravo.com> Date: Tue Nov 22 12:42:53 2011 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/21de7a16a9b74067f2b707ef22ee1298d8d8b8db [^] Fixes issue 19135: FIN_AddPayment - savePayment method not managing properly exceptions. --- M src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.java M src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java ---

(0066027) plujan (manager) 2014-04-02 09:04	Closed as it was in Resolved for too long

Issue History
Date Modified	Username	Field	Change
2011-11-22 12:34	ioritzCia	Type	defect => backport
2011-11-22 12:34	ioritzCia	fix_in_branch	=> 2.50
2011-12-01 12:04	hgbot	Checkin
2011-12-01 12:04	hgbot	Note Added: 0043648
2011-12-01 12:04	hgbot	Status	scheduled => resolved
2011-12-01 12:04	hgbot	Resolution	open => fixed
2011-12-01 12:04	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/21de7a16a9b74067f2b707ef22ee1298d8d8b8db [^]
2014-04-02 09:04	plujan	Note Added: 0066027
2014-04-02 09:04	plujan	Status	resolved => closed