Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019135Openbravo ERP09. Financial managementpublic2011-10-11 13:102014-04-02 09:04
Reportermirurita 
Assigned ToioritzCia 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019135: FIN_AddPayment - savePayment method not managing properly exceptions
Descriptionorg.openbravo.advpaymentmngt.process.FIN_AddPayment

savePayment method not managing properly exceptions.

it should raise the exception to be caught by caller method.
Steps To Reproduce1) Modify APRM_FIN_PMT_CHECK_TRG adding a raise exception at the beginning
RAISE EXCEPTION '%', '@20501@'; --OBTG:-20000--
2) Create a new sales invoice and complete
3) Click on Add Payment In button
4) On the popup click on OK button
Realize that the message shown is a generic message (it provides useless information to the user) and if you raise the exception using the message search key (i.e. @20501@) the exception is not translated.
Proposed Solutioncatch the flush event
 OBDal.getInstance().flush();

when calling this method you should manage then catch the exception this method can return. (for example in AddPaymentFromInvoice.)

Additional Information
TagsNo tags attached.
Relationships
blocks defect 0018752 closed ioritzCia FIN_AddPayment - savePayment method not managing properly exceptions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-11-22 12:34ioritzCiaTypedefect => backport
2011-11-22 12:34ioritzCiafix_in_branch => 2.50
2011-12-01 12:04hgbotCheckin
2011-12-01 12:04hgbotNote Added: 0043648
2011-12-01 12:04hgbotStatusscheduled => resolved
2011-12-01 12:04hgbotResolutionopen => fixed
2011-12-01 12:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/21de7a16a9b74067f2b707ef22ee1298d8d8b8db [^]
2014-04-02 09:04plujanNote Added: 0066027
2014-04-02 09:04plujanStatusresolved => closed

Notes
(0043648)
hgbot   
2011-12-01 12:04   
Repository: erp/pmods/org.openbravo.advpaymentmngt
Changeset: 21de7a16a9b74067f2b707ef22ee1298d8d8b8db
Author: Ioritz Cia <ioritz.cia <at> openbravo.com>
Date: Tue Nov 22 12:42:53 2011 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/21de7a16a9b74067f2b707ef22ee1298d8d8b8db [^]

Fixes issue 19135: FIN_AddPayment - savePayment method
not managing properly exceptions.

---
M src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.java
M src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
---
(0066027)
plujan   
2014-04-02 09:04   
Closed as it was in Resolved for too long